chromium/src
0
Fork 0
Code Activity

Convert StringPiece to std::string_view in password_ui_utils.cc

Browse Source 
Bug: 40506050
Change-Id: I4bfdcebf34c3845a8cad5bcc6ad2722cb00ac7f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5445523
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1289909}
This commit is contained in:
Codebind001
2024-04-19 14:07:31 +00:00
committed by Chromium LUCI CQ
parent 56c9ca2014
commit 226402b86c
2 changed files with 6 additions and 5 deletions
AUTHORS
components/password_manager/core/browser
password_ui_utils.cc

1
AUTHORS

@ -706,6 +706,7 @@ Joshua Lock <joshua.lock@intel.com>
Joshua Roesslein <jroesslein@gmail.com>
Josué Ratelle <jorat1346@gmail.com>
Josyula Venkat Narasimham <venkat.nj@samsung.com>
Joy Roy <joy.roy.nil76@gmail.com>
Joyer Huang <collger@gmail.com>
Juan Cruz Viotti <jv@jviotti.com>
Juan Jose Lopez Jaimez <jj.lopezjaimez@gmail.com>

10
components/password_manager/core/browser/password_ui_utils.cc

@ -6,11 +6,11 @@
#include <algorithm>
#include <string>
#include <string_view>
#include <vector>
#include "base/metrics/histogram_macros.h"
#include "base/strings/strcat.h"
#include "base/strings/string_piece.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "components/affiliations/core/browser/affiliation_utils.h"
@ -72,8 +72,8 @@ std::string GetShownOrigin(const url::Origin& origin) {
std::string original =
base::UTF16ToUTF8(url_formatter::FormatOriginForSecurityDisplay(
origin, url_formatter::SchemeDisplay::OMIT_HTTP_AND_HTTPS));
base::StringPiece result = original;
for (base::StringPiece prefix : kRemovedPrefixes) {
std::string_view result = original;
for (std::string_view prefix : kRemovedPrefixes) {
if (base::StartsWith(result, prefix,
base::CompareCase::INSENSITIVE_ASCII)) {
result.remove_prefix(prefix.length());
@ -81,8 +81,8 @@ std::string GetShownOrigin(const url::Origin& origin) {
}
}
return result.find('.') != base::StringPiece::npos ? std::string(result)
: original;
return result.find('.') != std::string_view::npos ? std::string(result)
: original;
}
void UpdatePasswordFormUsernameAndPassword(