Revert "Crash logging to confirm theory for detached context inconsistency."
This reverts commit221b27ba6b
. Reason for revert: theory for crash has been confirmed, no longer needed Original change's description: > Crash logging to confirm theory for detached context inconsistency. > > There are some weird crashes where WebLocalFrameImpl is still attached > but ScreenOrientationController no longer appears to have a DOMWindow > associated with it. Add some crash logging to confirm if this is > happening due to forcibly purging v8 memory on Android. > > Bug:1154141
> Change-Id: I1181fd80803629e2c56c2937e20e5d1de9ca07d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2670707 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#849971} TBR=dcheng@chromium.org,haraken@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug:1154141
Change-Id: I31ea66c2c0e784e2f4fbb01182c3ac384044d505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2679231 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#851430}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
5008fe3f8e
commit
226e9a9712
third_party/blink/renderer
bindings
modules
screen_orientation
@ -167,8 +167,6 @@ class WindowProxy : public GarbageCollected<WindowProxy> {
|
||||
|
||||
enum FrameReuseStatus { kFrameWillNotBeReused, kFrameWillBeReused };
|
||||
|
||||
int LifecycleForDebugging() const { return static_cast<int>(lifecycle_); }
|
||||
|
||||
protected:
|
||||
// Lifecycle represents the following four states.
|
||||
//
|
||||
|
@ -48,10 +48,6 @@ class WindowProxyManager : public GarbageCollected<WindowProxyManager> {
|
||||
|
||||
CORE_EXPORT void ResetIsolatedWorldsForTesting();
|
||||
|
||||
int LifecycleForDebugging() const {
|
||||
return window_proxy_->LifecycleForDebugging();
|
||||
}
|
||||
|
||||
protected:
|
||||
using IsolatedWorldMap = HeapHashMap<int, Member<WindowProxy>>;
|
||||
enum class FrameType { kLocal, kRemote };
|
||||
|
@ -13,7 +13,6 @@
|
||||
#include "third_party/blink/public/common/privacy_budget/identifiability_study_settings.h"
|
||||
#include "third_party/blink/public/common/widget/screen_info.h"
|
||||
#include "third_party/blink/public/platform/task_type.h"
|
||||
#include "third_party/blink/renderer/bindings/core/v8/window_proxy_manager.h"
|
||||
#include "third_party/blink/renderer/core/dom/events/event.h"
|
||||
#include "third_party/blink/renderer/core/frame/local_dom_window.h"
|
||||
#include "third_party/blink/renderer/core/frame/local_frame.h"
|
||||
@ -168,11 +167,6 @@ void ScreenOrientationController::NotifyOrientationChanged() {
|
||||
reinterpret_cast<uintptr_t>(GetExecutionContext()));
|
||||
SCOPED_CRASH_KEY_BOOL("debug-1154141", "is_context_destroyed",
|
||||
GetSupplementable()->IsContextDestroyed());
|
||||
SCOPED_CRASH_KEY_NUMBER("debug-1154141", "window_proxy_lifecycle",
|
||||
static_cast<int>(GetSupplementable()
|
||||
->GetFrame()
|
||||
->GetWindowProxyManager()
|
||||
->LifecycleForDebugging()));
|
||||
base::debug::DumpWithoutCrashing();
|
||||
return;
|
||||
}
|
||||
|
Reference in New Issue
Block a user