chromium/src
0
Fork 0
Code Activity

[heap] Clean up declarations of v8::Local

Browse Source 
This CL cleans up forward declarations of the v8::Local template in
several files. In case this template is transparently modified in
v8/include/v8-local-handle.h, e.g., by adding an extra template
parameter with a default value, these declaration would result in
compiler errors.

It also fixes a number of includes to v8/include files that did not use
the full path.

Change-Id: Ia51c443d82ab73dcc46c51461f01a1573c73955f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625197
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1160513}
This commit is contained in:
Nikolaos Papaspyrou
2023-06-21 07:23:24 +00:00
committed by Chromium LUCI CQ
parent 23abb713ec
commit 22c0db4c92
22 changed files with 26 additions and 44 deletions

3
chrome/renderer/extensions/chrome_extensions_renderer_client.h

@ -11,6 +11,7 @@
#include "extensions/renderer/extensions_renderer_client.h"
#include "services/service_manager/public/cpp/binder_registry.h"
#include "ui/base/page_transition_types.h"
#include "v8/include/v8-local-handle.h"
class GURL;
@ -49,8 +50,6 @@ class MojoUkmRecorder;
namespace v8 {
class Isolate;
template <typename T>
class Local;
class Object;
} // namespace v8

2
content/public/renderer/chrome_object_extensions_utils.h

@ -6,11 +6,11 @@
#define CONTENT_PUBLIC_RENDERER_CHROME_OBJECT_EXTENSIONS_UTILS_H_
#include "content/common/content_export.h"
#include "v8/include/v8-local-handle.h"
#include <string>
namespace v8 {
template<class T> class Local;
class Context;
class Object;
class Isolate;

4
content/services/auction_worklet/register_ad_beacon_bindings.cc

@ -15,12 +15,12 @@
#include "gin/converter.h"
#include "url/gurl.h"
#include "url/url_constants.h"
#include "v8-context.h"
#include "v8-object.h"
#include "v8/include/v8-context.h"
#include "v8/include/v8-exception.h"
#include "v8/include/v8-external.h"
#include "v8/include/v8-function-callback.h"
#include "v8/include/v8-function.h"
#include "v8/include/v8-object.h"
namespace auction_worklet {

2
extensions/renderer/script_context.h

@ -22,8 +22,8 @@
#include "extensions/renderer/safe_builtins.h"
#include "third_party/blink/public/web/web_script_execution_callback.h"
#include "url/gurl.h"
#include "v8-exception.h"
#include "v8/include/v8-context.h"
#include "v8/include/v8-exception.h"
#include "v8/include/v8-forward.h"
#include "v8/include/v8-script.h"

2
gin/v8_platform_page_allocator.h

@ -14,7 +14,7 @@
#include "base/allocator/partition_allocator/page_allocator.h"
#include "gin/gin_export.h"
#include "v8-platform.h"
#include "v8/include/v8-platform.h"
namespace gin {

2
gin/v8_platform_thread_isolated_allocator.h

@ -15,7 +15,7 @@
#include "base/allocator/partition_allocator/partition_alloc.h"
#include "gin/gin_export.h"
#include "v8-platform.h"
#include "v8/include/v8-platform.h"
namespace gin {

2
services/accessibility/features/mojo/mojo.cc

@ -18,7 +18,7 @@
#include "services/accessibility/features/mojo/mojo_handle.h"
#include "services/accessibility/features/registered_wrappable.h"
#include "services/accessibility/features/v8_manager.h"
#include "v8-context.h"
#include "v8/include/v8-context.h"
#include "v8/include/v8-isolate.h"
#include "v8/include/v8-local-handle.h"
#include "v8/include/v8-primitive.h"

4
services/accessibility/features/text_encoder.cc

@ -15,11 +15,11 @@
#include "gin/handle.h"
#include "gin/public/wrapper_info.h"
#include "services/accessibility/features/registered_wrappable.h"
#include "v8-array-buffer.h"
#include "v8-typed-array.h"
#include "v8/include/v8-array-buffer.h"
#include "v8/include/v8-isolate.h"
#include "v8/include/v8-local-handle.h"
#include "v8/include/v8-primitive.h"
#include "v8/include/v8-typed-array.h"
namespace ax {

3
third_party/blink/public/platform/platform.h vendored

@ -63,6 +63,7 @@
#include "third_party/blink/public/platform/websocket_handshake_throttle_provider.h"
#include "third_party/webrtc/api/video/video_codec_type.h"
#include "ui/base/resource/resource_scale_factor.h"
#include "v8/include/v8-local-handle.h"
class SkCanvas;
class SkBitmap;
@ -106,8 +107,6 @@ class Origin;
namespace v8 {
class Context;
template <class T>
class Local;
} // namespace v8
namespace viz {

3
third_party/blink/public/web/web_array_buffer_converter.h vendored

@ -33,13 +33,12 @@
#include "third_party/blink/public/platform/web_common.h"
#include "third_party/blink/public/web/web_array_buffer.h"
#include "v8/include/v8-local-handle.h"
namespace v8 {
class Isolate;
class Object;
class Value;
template <class T>
class Local;
}
namespace blink {

3
third_party/blink/public/web/web_blob.h vendored

@ -36,12 +36,11 @@
#include "third_party/blink/public/platform/web_private_ptr.h"
#include "third_party/blink/public/platform/web_string.h"
#include "third_party/blink/public/platform/web_url.h"
#include "v8/include/v8-local-handle.h"
namespace v8 {
class Isolate;
class Value;
template <class T>
class Local;
}
namespace blink {

3
third_party/blink/public/web/web_console_message.h vendored

@ -35,11 +35,10 @@
#include "third_party/blink/public/platform/web_common.h"
#include "third_party/blink/public/platform/web_string.h"
#include "third_party/blink/public/web/web_node.h"
#include "v8/include/v8-local-handle.h"
namespace v8 {
class Context;
template <typename T>
class Local;
} // namespace v8
namespace blink {

4
third_party/blink/public/web/web_crypto_normalize.h vendored

@ -32,14 +32,12 @@
#define THIRD_PARTY_BLINK_PUBLIC_WEB_WEB_CRYPTO_NORMALIZE_H_
#include "third_party/blink/public/platform/web_common.h"
#include "third_party/blink/public/platform/web_crypto_algorithm.h"
#include "v8/include/v8-local-handle.h"
namespace v8 {
class Isolate;
class Object;
template <class T>
class Local;
}
namespace blink {

3
third_party/blink/public/web/web_dom_file_system.h vendored

@ -36,13 +36,12 @@
#include "third_party/blink/public/platform/web_string.h"
#include "third_party/blink/public/platform/web_url.h"
#include "third_party/blink/public/web/web_frame.h"
#include "v8/include/v8-local-handle.h"
namespace v8 {
class Isolate;
class Object;
class Value;
template <class T>
class Local;
}
namespace blink {

3
third_party/blink/public/web/web_dom_media_stream_track.h vendored

@ -34,11 +34,10 @@
#include "third_party/blink/public/platform/modules/mediastream/web_media_stream_track.h"
#include "third_party/blink/public/platform/web_common.h"
#include "third_party/blink/public/platform/web_private_ptr.h"
#include "v8/include/v8-local-handle.h"
namespace v8 {
class Value;
template <class T>
class Local;
}
namespace blink {

3
third_party/blink/public/web/web_message_port_converter.h vendored

@ -7,11 +7,10 @@
#include "third_party/abseil-cpp/absl/types/optional.h"
#include "third_party/blink/public/platform/web_common.h"
#include "v8/include/v8-local-handle.h"
namespace v8 {
class Isolate;
template <class T>
class Local;
class Value;
} // namespace v8

3
third_party/blink/public/web/web_serialized_script_value.h vendored

@ -33,12 +33,11 @@
#include "third_party/blink/public/platform/web_common.h"
#include "third_party/blink/public/platform/web_private_ptr.h"
#include "v8/include/v8-local-handle.h"
namespace v8 {
class Isolate;
class Value;
template <class T>
class Local;
}
namespace blink {

2
third_party/blink/renderer/core/inspector/inspector_trace_events.h vendored

@ -34,8 +34,6 @@ class QuadF;
namespace v8 {
class Function;
template <typename T>
class Local;
} // namespace v8
namespace WTF {

5
third_party/blink/renderer/core/script/detect_javascript_frameworks.cc vendored

@ -19,11 +19,6 @@
#include "third_party/blink/renderer/platform/bindings/v8_binding.h"
#include "third_party/blink/renderer/platform/wtf/std_lib_extras.h"
#include "third_party/blink/renderer/platform/wtf/text/atomic_string.h"
#include "v8-container.h"
#include "v8-local-handle.h"
#include "v8-object.h"
#include "v8-primitive.h"
#include "v8-regexp.h"
#include "v8/include/v8.h"
namespace blink {

8
third_party/blink/renderer/core/view_transition/view_transition_test.cc vendored

@ -41,10 +41,10 @@
#include "third_party/blink/renderer/platform/testing/unit_test_helpers.h"
#include "third_party/blink/renderer/platform/wtf/allocator/allocator.h"
#include "third_party/blink/renderer/platform/wtf/text/atomic_string.h"
#include "v8-external.h"
#include "v8-function-callback.h"
#include "v8-function.h"
#include "v8-value.h"
#include "v8/include/v8-external.h"
#include "v8/include/v8-function-callback.h"
#include "v8/include/v8-function.h"
#include "v8/include/v8-value.h"
namespace blink {

4
third_party/blink/renderer/modules/peerconnection/rtc_stats_report.cc vendored

@ -37,8 +37,8 @@
#include "third_party/webrtc/api/stats/rtc_stats.h"
#include "third_party/webrtc/api/stats/rtc_stats_report.h"
#include "third_party/webrtc/api/stats/rtcstats_objects.h"
#include "v8-local-handle.h"
#include "v8-object.h"
#include "v8/include/v8-local-handle.h"
#include "v8/include/v8-object.h"
namespace blink {

2
third_party/blink/renderer/platform/heap/thread_state.h vendored

@ -12,11 +12,11 @@
#include "third_party/blink/renderer/platform/heap/thread_state_storage.h"
#include "third_party/blink/renderer/platform/wtf/allocator/allocator.h"
#include "third_party/blink/renderer/platform/wtf/threading.h"
#include "v8-profiler.h"
#include "v8/include/cppgc/common.h"
#include "v8/include/cppgc/heap-consistency.h"
#include "v8/include/v8-callbacks.h"
#include "v8/include/v8-cppgc.h"
#include "v8/include/v8-profiler.h"
namespace v8 {
class CppHeap;