chromium/src
0
Fork 0
Code Activity

Add check to make sure to make surethe production code is not calling a function in test namespace

Browse Source 
BUG=None
NOTRY=true

Review URL: https://codereview.chromium.org/285623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270300 0039d316-1c4b-4281-b951-d872f2087c98
This commit is contained in:
oshima@chromium.org
2014-05-14 02:06:09 +00:00
parent 8847049d49
commit 2350182901
1 changed files with 2 additions and 2 deletions

4
PRESUBMIT.py

@ -279,9 +279,9 @@ def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api):
# calls to such functions without a proper C++ parser.
file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS
base_function_pattern = r'ForTest(ing)?|for_test(ing)?'
base_function_pattern = r'[ :]test::[^\s]+|ForTest(ing)?|for_test(ing)?'
inclusion_pattern = input_api.re.compile(r'(%s)\s*\(' % base_function_pattern)
comment_pattern = input_api.re.compile(r'//.*%s' % base_function_pattern)
comment_pattern = input_api.re.compile(r'//.*(%s)' % base_function_pattern)
exclusion_pattern = input_api.re.compile(
r'::[A-Za-z0-9_]+(%s)|(%s)[^;]+\{' % (
base_function_pattern, base_function_pattern))