chromium/src
0
Fork 0
Code Activity

SC Education: Fix dialog accessibility text

Browse Source 
Add a new accessible string for the Arm 2 dialog title, so screen
readers can properly announce its contents.

Bug: b/315494131
Test: manual
Change-Id: I16dabc70e10d3fd07daacffc9d64f8f7e2aa8436
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5116032
Commit-Queue: Elijah Hewer <hewer@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1236652}
This commit is contained in:
Elijah Hewer
2023-12-12 23:21:53 +00:00
committed by Chromium LUCI CQ
parent 2d0f1807c5
commit 2373df3c78
3 changed files with 6 additions and 0 deletions

3
ash/ash_strings.grd

@ -6163,6 +6163,9 @@ Here are some things you can try to get started.
<message name="IDS_ASH_SCREEN_CAPTURE_EDUCATION_TUTORIAL_TITLE" desc="The title of the tutorial dialog for Screen Capture Education (Arm 2).">
Press the screenshot shortcut
</message>
<message name="IDS_ASH_SCREEN_CAPTURE_EDUCATION_TUTORIAL_ACCESSIBLE_TITLE" desc="The accessible title of the tutorial dialog for Screen Capture Education (Arm 2).">
Press the screenshot shortcut, Ctrl plus Shift plus Overview mode key
</message>
<message name="IDS_ASH_SCREEN_CAPTURE_EDUCATION_SETTINGS_NUDGE_LABEL" desc="The label of the Screen Capture Education settings nudge (Arm 3) for using the quick settings menu.">
Use the screen capture tool in quick settings to take screenshots
</message>

1
ash/ash_strings_grd/IDS_ASH_SCREEN_CAPTURE_EDUCATION_TUTORIAL_ACCESSIBLE_TITLE.png.sha1 Normal file

@ -0,0 +1 @@
517e577881a719b45a6f7a0a0bb929a6bd99dba9

2
ash/capture_mode/capture_mode_education_controller.cc

@ -136,6 +136,8 @@ std::unique_ptr<SystemDialogDelegateView> CreateDialogView() {
auto dialog = std::make_unique<SystemDialogDelegateView>();
dialog->SetTitleText(l10n_util::GetStringUTF16(
IDS_ASH_SCREEN_CAPTURE_EDUCATION_TUTORIAL_TITLE));
dialog->SetAccessibleTitle(l10n_util::GetStringUTF16(
IDS_ASH_SCREEN_CAPTURE_EDUCATION_TUTORIAL_ACCESSIBLE_TITLE));
dialog->SetMiddleContentView(CreateContentView());
dialog->SetMiddleContentAlignment(views::LayoutAlignment::kStretch);
// Override the title margins to be zero, as the space between the title and