chromium/src
0
Fork 0
Code Activity

Document the dcheck_always_on caveat with pre-built ash.

Browse Source 
Since dcheck_always_on setting is different on linux-lacros
CQ builder for ToT Ash and version skew ash, it may lead to
different behavior for ToT test vs version skew tests if
DCHECK is involved, which can cause confusion. Therefore, add
a note in the documentation about this caveat.

Bug: 339654892
Change-Id: Idd30fa7961e1b48efeab1cc1d0a0a3e3ed2054df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5529629
Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1299474}
This commit is contained in:
Jenny Zhang
2024-05-10 20:14:32 +00:00
committed by Chromium LUCI CQ
parent 1d9360ee95
commit 237fa107a3
1 changed files with 7 additions and 0 deletions

7
docs/lacros/test_linux_lacros.md

@ -43,6 +43,10 @@ symbol_level = 0
target_os = "chromeos"
use_remoteexec = true
```
Caveat: On CQ builder, ToT ash is built with `dcheck_always_on=true`; however, older ash used
for version skew tests is pre-built on a separate builder and is built with `dcheck_always_on=false`.
This could lead to different behavior between ToT and version skew tests if dcheck is hit in code path.
CI gn args:
```
@ -150,6 +154,9 @@ you can pass --ash-chrome-path-override=/absolute/path/out/ashdesktop/test_ash_c
If you’re debugging, we suggest you have 2 checkouts, one for (older) ash and
the other for (newer) lacros.
Note: The prebuilt ash mentioned in #1 is built with `dcheck_always_on=false`,
while the ash built localled in #2 can have `dcheck_always_on=true`.
### Ash browser tests require Lacros
Use the following gn args((this is the bot config, other args would likely to