Replicate LayoutTestRuntimeFlags across secondary window renderers.
Before this CL, LayoutTestRuntimeFlags would only be replicated across renderers with frames belonging to the main test window. After this CL, LayoutTestRuntimeFlags are replicated across all renderers (including renderers for secondary window frames). This CL also switches to use control/process IPC messages (rather than RenderView messages) for propagating changes to LayoutTestRuntimeFlags. This is desirable, because LayoutTestRuntimeFlags are a global object, not really associated with a specific RenderView and/or BlinkTestRunner. This is also nice from code clean-up perspective - this approach doesn't need a swapped-out exception in LayoutTestContentClient and other baroque pieces of code in BlinkTestRunner and BlinkTestController. Regrettably, even after this CL, TestRunner continues to notify the world about LayoutTestRuntimeFlags changes via an arbitrarily picked BlinkTestRunner / WebTestDelegate. After this CL (and after the earlier https://crrev.com/1875303002) flags controlling WebContentSettingsClient are replicated to secondary renderers. This means that a few extra mixed content layout tests are passing in --site-per-process mode and allows to remove test expectations for this mode. BUG=587175, 582525, 595895 Review URL: https://codereview.chromium.org/1878863002 Cr-Commit-Position: refs/heads/master@{#387977}
This commit is contained in:
components/test_runner
content/shell
browser
layout_test
common
renderer
third_party/WebKit/LayoutTests/FlagExpectations
@ -1852,6 +1852,7 @@ void TestRunner::DumpPixelsAsync(
|
||||
|
||||
void TestRunner::ReplicateLayoutTestRuntimeFlagsChanges(
|
||||
const base::DictionaryValue& changed_values) {
|
||||
DCHECK(test_is_running_);
|
||||
layout_test_runtime_flags_.tracked_dictionary().ApplyUntrackedChanges(
|
||||
changed_values);
|
||||
}
|
||||
|
@ -45,6 +45,7 @@
|
||||
#include "content/shell/browser/shell_browser_context.h"
|
||||
#include "content/shell/browser/shell_content_browser_client.h"
|
||||
#include "content/shell/browser/shell_devtools_frontend.h"
|
||||
#include "content/shell/common/layout_test/layout_test_messages.h"
|
||||
#include "content/shell/common/layout_test/layout_test_switches.h"
|
||||
#include "content/shell/common/shell_messages.h"
|
||||
#include "content/shell/renderer/layout_test/blink_test_helpers.h"
|
||||
@ -379,7 +380,7 @@ void BlinkTestController::OpenURL(const GURL& url) {
|
||||
gfx::Size());
|
||||
}
|
||||
|
||||
void BlinkTestController::TestFinishedInSecondaryRenderer() {
|
||||
void BlinkTestController::OnTestFinishedInSecondaryRenderer() {
|
||||
RenderViewHost* render_view_host =
|
||||
main_window_->web_contents()->GetRenderViewHost();
|
||||
render_view_host->Send(
|
||||
@ -446,8 +447,6 @@ bool BlinkTestController::OnMessageReceived(
|
||||
bool handled = true;
|
||||
IPC_BEGIN_MESSAGE_MAP_WITH_PARAM(BlinkTestController, message,
|
||||
render_frame_host)
|
||||
IPC_MESSAGE_HANDLER(ShellViewHostMsg_LayoutTestRuntimeFlagsChanged,
|
||||
OnLayoutTestRuntimeFlagsChanged)
|
||||
IPC_MESSAGE_HANDLER(ShellViewHostMsg_LayoutDumpResponse,
|
||||
OnLayoutDumpResponse)
|
||||
IPC_MESSAGE_UNHANDLED(handled = false)
|
||||
@ -608,8 +607,7 @@ void BlinkTestController::HandleNewRenderFrameHost(RenderFrameHost* frame) {
|
||||
|
||||
if (did_send_initial_test_configuration_) {
|
||||
frame->Send(new ShellViewMsg_ReplicateTestConfiguration(
|
||||
frame->GetRoutingID(), params,
|
||||
accumulated_layout_test_runtime_flags_changes_));
|
||||
frame->GetRoutingID(), params));
|
||||
} else {
|
||||
did_send_initial_test_configuration_ = true;
|
||||
frame->Send(
|
||||
@ -626,6 +624,9 @@ void BlinkTestController::HandleNewRenderFrameHost(RenderFrameHost* frame) {
|
||||
frame->Send(
|
||||
new ShellViewMsg_SetupSecondaryRenderer(frame->GetRoutingID()));
|
||||
}
|
||||
|
||||
process->Send(new LayoutTestMsg_ReplicateLayoutTestRuntimeFlagsChanges(
|
||||
accumulated_layout_test_runtime_flags_changes_));
|
||||
}
|
||||
}
|
||||
|
||||
@ -697,29 +698,22 @@ void BlinkTestController::OnInitiateLayoutDump() {
|
||||
}
|
||||
|
||||
void BlinkTestController::OnLayoutTestRuntimeFlagsChanged(
|
||||
RenderFrameHost* sender,
|
||||
int sender_process_host_id,
|
||||
const base::DictionaryValue& changed_layout_test_runtime_flags) {
|
||||
// Stash the changes for future renderers.
|
||||
// Stash the accumulated changes for future, not-yet-created renderers.
|
||||
accumulated_layout_test_runtime_flags_changes_.MergeDictionary(
|
||||
&changed_layout_test_runtime_flags);
|
||||
|
||||
// Only need to send the propagation message once per renderer process.
|
||||
std::set<int> already_covered_process_ids;
|
||||
// Propagate the changes to all the tracked renderer processes.
|
||||
for (RenderProcessHost* process : all_observed_render_process_hosts_) {
|
||||
// Do not propagate the changes back to the process that originated them.
|
||||
// (propagating them back could also clobber subsequent changes in the
|
||||
// originator).
|
||||
if (process->GetID() == sender_process_host_id)
|
||||
continue;
|
||||
|
||||
// No need to propagate the changes back to the process that originated them.
|
||||
// (propagating them back could also clobber subsequent changes in the
|
||||
// originator).
|
||||
already_covered_process_ids.insert(sender->GetProcess()->GetID());
|
||||
|
||||
// Propagate the changes to all the renderer processes associated with the
|
||||
// main window.
|
||||
for (RenderFrameHost* frame : main_window_->web_contents()->GetAllFrames()) {
|
||||
bool inserted_new_item =
|
||||
already_covered_process_ids.insert(frame->GetProcess()->GetID()).second;
|
||||
if (inserted_new_item) {
|
||||
frame->Send(new ShellViewMsg_ReplicateLayoutTestRuntimeFlagsChanges(
|
||||
frame->GetRoutingID(), changed_layout_test_runtime_flags));
|
||||
}
|
||||
process->Send(new LayoutTestMsg_ReplicateLayoutTestRuntimeFlagsChanges(
|
||||
changed_layout_test_runtime_flags));
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -134,6 +134,12 @@ class BlinkTestController : public base::NonThreadSafe,
|
||||
// True if the controller was reset successfully.
|
||||
bool ResetAfterLayoutTest();
|
||||
|
||||
// IPC messages forwarded from elsewhere.
|
||||
void OnLayoutTestRuntimeFlagsChanged(
|
||||
int sender_process_host_id,
|
||||
const base::DictionaryValue& changed_layout_test_runtime_flags);
|
||||
void OnTestFinishedInSecondaryRenderer();
|
||||
|
||||
// Makes sure that the potentially new renderer associated with |frame| is 1)
|
||||
// initialized for the test, 2) kept-up-to-date wrt test flags and 3)
|
||||
// monitored for crashes.
|
||||
@ -143,7 +149,6 @@ class BlinkTestController : public base::NonThreadSafe,
|
||||
void RendererUnresponsive();
|
||||
void OverrideWebkitPrefs(WebPreferences* prefs);
|
||||
void OpenURL(const GURL& url);
|
||||
void TestFinishedInSecondaryRenderer();
|
||||
bool IsMainWindow(WebContents* web_contents) const;
|
||||
std::unique_ptr<BluetoothChooser> RunBluetoothChooser(
|
||||
RenderFrameHost* frame,
|
||||
@ -196,9 +201,6 @@ class BlinkTestController : public base::NonThreadSafe,
|
||||
void OnImageDump(const std::string& actual_pixel_hash, const SkBitmap& image);
|
||||
void OnTextDump(const std::string& dump);
|
||||
void OnInitiateLayoutDump();
|
||||
void OnLayoutTestRuntimeFlagsChanged(
|
||||
RenderFrameHost* sender,
|
||||
const base::DictionaryValue& changed_layout_test_runtime_flags);
|
||||
void OnLayoutDumpResponse(RenderFrameHost* sender, const std::string& dump);
|
||||
void OnPrintMessage(const std::string& message);
|
||||
void OnOverridePreferences(const WebPreferences& prefs);
|
||||
|
@ -11,6 +11,7 @@
|
||||
#include "content/public/browser/child_process_security_policy.h"
|
||||
#include "content/public/browser/permission_type.h"
|
||||
#include "content/public/test/layouttest_support.h"
|
||||
#include "content/shell/browser/layout_test/blink_test_controller.h"
|
||||
#include "content/shell/browser/layout_test/layout_test_browser_context.h"
|
||||
#include "content/shell/browser/layout_test/layout_test_content_browser_client.h"
|
||||
#include "content/shell/browser/layout_test/layout_test_notification_manager.h"
|
||||
@ -46,13 +47,18 @@ LayoutTestMessageFilter::~LayoutTestMessageFilter() {
|
||||
|
||||
void LayoutTestMessageFilter::OverrideThreadForMessage(
|
||||
const IPC::Message& message, BrowserThread::ID* thread) {
|
||||
if (message.type() == LayoutTestHostMsg_ClearAllDatabases::ID)
|
||||
*thread = BrowserThread::FILE;
|
||||
if (message.type() == LayoutTestHostMsg_SimulateWebNotificationClick::ID ||
|
||||
message.type() == LayoutTestHostMsg_SimulateWebNotificationClose::ID ||
|
||||
message.type() == LayoutTestHostMsg_SetPermission::ID ||
|
||||
message.type() == LayoutTestHostMsg_ResetPermissions::ID)
|
||||
*thread = BrowserThread::UI;
|
||||
switch (message.type()) {
|
||||
case LayoutTestHostMsg_ClearAllDatabases::ID:
|
||||
*thread = BrowserThread::FILE;
|
||||
break;
|
||||
case LayoutTestHostMsg_SimulateWebNotificationClick::ID:
|
||||
case LayoutTestHostMsg_SimulateWebNotificationClose::ID:
|
||||
case LayoutTestHostMsg_SetPermission::ID:
|
||||
case LayoutTestHostMsg_ResetPermissions::ID:
|
||||
case LayoutTestHostMsg_LayoutTestRuntimeFlagsChanged::ID:
|
||||
*thread = BrowserThread::UI;
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
bool LayoutTestMessageFilter::OnMessageReceived(const IPC::Message& message) {
|
||||
@ -72,6 +78,8 @@ bool LayoutTestMessageFilter::OnMessageReceived(const IPC::Message& message) {
|
||||
IPC_MESSAGE_HANDLER(LayoutTestHostMsg_DeleteAllCookies, OnDeleteAllCookies)
|
||||
IPC_MESSAGE_HANDLER(LayoutTestHostMsg_SetPermission, OnSetPermission)
|
||||
IPC_MESSAGE_HANDLER(LayoutTestHostMsg_ResetPermissions, OnResetPermissions)
|
||||
IPC_MESSAGE_HANDLER(LayoutTestHostMsg_LayoutTestRuntimeFlagsChanged,
|
||||
OnLayoutTestRuntimeFlagsChanged)
|
||||
IPC_MESSAGE_UNHANDLED(handled = false)
|
||||
IPC_END_MESSAGE_MAP()
|
||||
|
||||
@ -179,4 +187,10 @@ void LayoutTestMessageFilter::OnResetPermissions() {
|
||||
->ResetPermissions();
|
||||
}
|
||||
|
||||
void LayoutTestMessageFilter::OnLayoutTestRuntimeFlagsChanged(
|
||||
const base::DictionaryValue& changed_layout_test_runtime_flags) {
|
||||
BlinkTestController::Get()->OnLayoutTestRuntimeFlagsChanged(
|
||||
render_process_id_, changed_layout_test_runtime_flags);
|
||||
}
|
||||
|
||||
} // namespace content
|
||||
|
@ -15,6 +15,10 @@
|
||||
|
||||
class GURL;
|
||||
|
||||
namespace base {
|
||||
class DictionaryValue;
|
||||
}
|
||||
|
||||
namespace net {
|
||||
class URLRequestContextGetter;
|
||||
}
|
||||
@ -66,6 +70,8 @@ class LayoutTestMessageFilter : public BrowserMessageFilter {
|
||||
const GURL& origin,
|
||||
const GURL& embedding_origin);
|
||||
void OnResetPermissions();
|
||||
void OnLayoutTestRuntimeFlagsChanged(
|
||||
const base::DictionaryValue& changed_layout_test_runtime_flags);
|
||||
|
||||
int render_process_id_;
|
||||
|
||||
|
@ -29,7 +29,7 @@ bool SecondaryTestWindowObserver::OnMessageReceived(
|
||||
}
|
||||
|
||||
void SecondaryTestWindowObserver::OnTestFinishedInSecondaryRenderer() {
|
||||
BlinkTestController::Get()->TestFinishedInSecondaryRenderer();
|
||||
BlinkTestController::Get()->OnTestFinishedInSecondaryRenderer();
|
||||
}
|
||||
|
||||
void SecondaryTestWindowObserver::RenderFrameCreated(
|
||||
|
@ -13,7 +13,6 @@ bool LayoutTestContentClient::CanSendWhileSwappedOut(
|
||||
switch (message->type()) {
|
||||
// Used in layout tests; handled in BlinkTestController.
|
||||
case ShellViewHostMsg_PrintMessage::ID:
|
||||
case ShellViewHostMsg_LayoutTestRuntimeFlagsChanged::ID:
|
||||
return true;
|
||||
|
||||
default:
|
||||
|
@ -42,3 +42,16 @@ IPC_MESSAGE_ROUTED4(LayoutTestHostMsg_SetPermission,
|
||||
GURL /* origin */,
|
||||
GURL /* embedding_origin */)
|
||||
IPC_MESSAGE_ROUTED0(LayoutTestHostMsg_ResetPermissions)
|
||||
|
||||
// Notifies the browser that one of renderers has changed layout test runtime
|
||||
// flags (i.e. has set dump_as_text).
|
||||
IPC_MESSAGE_CONTROL1(
|
||||
LayoutTestHostMsg_LayoutTestRuntimeFlagsChanged,
|
||||
base::DictionaryValue /* changed_layout_test_runtime_flags */)
|
||||
|
||||
// Used send flag changes to renderers - either when
|
||||
// 1) broadcasting change happening in one renderer to all other renderers, or
|
||||
// 2) sending accumulated changes to a single new renderer.
|
||||
IPC_MESSAGE_CONTROL1(
|
||||
LayoutTestMsg_ReplicateLayoutTestRuntimeFlagsChanges,
|
||||
base::DictionaryValue /* changed_layout_test_runtime_flags */)
|
||||
|
@ -43,20 +43,13 @@ IPC_MESSAGE_ROUTED1(ShellViewMsg_SetTestConfiguration,
|
||||
|
||||
// Replicates test config (for an already started test) to a new renderer
|
||||
// that hosts parts of the main test window.
|
||||
IPC_MESSAGE_ROUTED2(
|
||||
ShellViewMsg_ReplicateTestConfiguration,
|
||||
content::ShellTestConfiguration,
|
||||
base::DictionaryValue /* accumulated_layout_test_runtime_flags_changes */)
|
||||
IPC_MESSAGE_ROUTED1(ShellViewMsg_ReplicateTestConfiguration,
|
||||
content::ShellTestConfiguration)
|
||||
|
||||
// Sets up a secondary renderer (renderer that doesn't [yet] host parts of the
|
||||
// main test window) for a layout test.
|
||||
IPC_MESSAGE_ROUTED0(ShellViewMsg_SetupSecondaryRenderer)
|
||||
|
||||
// Used to broadcast changes happening in one renderer to all other renderers.
|
||||
IPC_MESSAGE_ROUTED1(
|
||||
ShellViewMsg_ReplicateLayoutTestRuntimeFlagsChanges,
|
||||
base::DictionaryValue /* changed_layout_test_runtime_flags */)
|
||||
|
||||
// Tells the main window that a secondary renderer in a different process thinks
|
||||
// the test is finished.
|
||||
IPC_MESSAGE_ROUTED0(ShellViewMsg_NotifyDone)
|
||||
@ -81,12 +74,6 @@ IPC_MESSAGE_ROUTED0(ShellViewMsg_LayoutDumpRequest)
|
||||
IPC_MESSAGE_ROUTED1(ShellViewMsg_LayoutDumpCompleted,
|
||||
std::string /* completed/stitched layout dump */)
|
||||
|
||||
// Notifies the browser that one of renderers has changed layout test runtime
|
||||
// flags (i.e. has set dump_as_text).
|
||||
IPC_MESSAGE_ROUTED1(
|
||||
ShellViewHostMsg_LayoutTestRuntimeFlagsChanged,
|
||||
base::DictionaryValue /* changed_layout_test_runtime_flags */)
|
||||
|
||||
// Send a text dump of the WebContents to the render host.
|
||||
IPC_MESSAGE_ROUTED1(ShellViewHostMsg_TextDump,
|
||||
std::string /* dump */)
|
||||
|
@ -529,20 +529,8 @@ void BlinkTestRunner::OnLayoutTestRuntimeFlagsChanged(
|
||||
if (!is_main_window_)
|
||||
return;
|
||||
|
||||
// Message needs to be send via a local frame to eventually reach
|
||||
// WebContentsObserver via OnMessage(..., RenderFrameHost*) overload - this
|
||||
// lets BlinkTestController figure out the originator of the message.
|
||||
RenderFrame* local_frame = nullptr;
|
||||
for (WebFrame* frame = render_view()->GetWebView()->mainFrame(); frame;
|
||||
frame = frame->traverseNext(false)) {
|
||||
if (frame->isWebLocalFrame()) {
|
||||
local_frame = RenderFrame::FromWebFrame(frame);
|
||||
break;
|
||||
}
|
||||
}
|
||||
DCHECK(local_frame);
|
||||
Send(new ShellViewHostMsg_LayoutTestRuntimeFlagsChanged(
|
||||
local_frame->GetRoutingID(), changed_values));
|
||||
RenderThread::Get()->Send(
|
||||
new LayoutTestHostMsg_LayoutTestRuntimeFlagsChanged(changed_values));
|
||||
}
|
||||
|
||||
void BlinkTestRunner::TestFinished() {
|
||||
|
@ -32,8 +32,6 @@ bool LayoutTestRenderFrameObserver::OnMessageReceived(
|
||||
bool handled = true;
|
||||
IPC_BEGIN_MESSAGE_MAP(LayoutTestRenderFrameObserver, message)
|
||||
IPC_MESSAGE_HANDLER(ShellViewMsg_LayoutDumpRequest, OnLayoutDumpRequest)
|
||||
IPC_MESSAGE_HANDLER(ShellViewMsg_ReplicateLayoutTestRuntimeFlagsChanges,
|
||||
OnReplicateLayoutTestRuntimeFlagsChanges)
|
||||
IPC_MESSAGE_HANDLER(ShellViewMsg_ReplicateTestConfiguration,
|
||||
OnReplicateTestConfiguration)
|
||||
IPC_MESSAGE_HANDLER(ShellViewMsg_SetTestConfiguration,
|
||||
@ -55,24 +53,10 @@ void LayoutTestRenderFrameObserver::OnLayoutDumpRequest() {
|
||||
Send(new ShellViewHostMsg_LayoutDumpResponse(routing_id(), dump));
|
||||
}
|
||||
|
||||
void LayoutTestRenderFrameObserver::OnReplicateLayoutTestRuntimeFlagsChanges(
|
||||
const base::DictionaryValue& changed_layout_test_runtime_flags) {
|
||||
LayoutTestRenderThreadObserver::GetInstance()
|
||||
->test_interfaces()
|
||||
->TestRunner()
|
||||
->ReplicateLayoutTestRuntimeFlagsChanges(
|
||||
changed_layout_test_runtime_flags);
|
||||
}
|
||||
|
||||
void LayoutTestRenderFrameObserver::OnReplicateTestConfiguration(
|
||||
const ShellTestConfiguration& test_config,
|
||||
const base::DictionaryValue&
|
||||
accumulated_layout_test_runtime_flags_changes) {
|
||||
const ShellTestConfiguration& test_config) {
|
||||
BlinkTestRunner::Get(render_frame()->GetRenderView())
|
||||
->OnReplicateTestConfiguration(test_config);
|
||||
|
||||
OnReplicateLayoutTestRuntimeFlagsChanges(
|
||||
accumulated_layout_test_runtime_flags_changes);
|
||||
}
|
||||
|
||||
void LayoutTestRenderFrameObserver::OnSetTestConfiguration(
|
||||
|
@ -30,13 +30,8 @@ class LayoutTestRenderFrameObserver : public RenderFrameObserver {
|
||||
|
||||
private:
|
||||
void OnLayoutDumpRequest();
|
||||
void OnReplicateLayoutTestRuntimeFlagsChanges(
|
||||
const base::DictionaryValue& changed_layout_test_runtime_flags);
|
||||
void OnSetTestConfiguration(const ShellTestConfiguration& test_config);
|
||||
void OnReplicateTestConfiguration(
|
||||
const ShellTestConfiguration& test_config,
|
||||
const base::DictionaryValue&
|
||||
accumulated_layout_test_runtime_flags_changes);
|
||||
void OnReplicateTestConfiguration(const ShellTestConfiguration& test_config);
|
||||
void OnSetupSecondaryRenderer();
|
||||
|
||||
DISALLOW_COPY_AND_ASSIGN(LayoutTestRenderFrameObserver);
|
||||
|
@ -7,10 +7,12 @@
|
||||
#include "base/command_line.h"
|
||||
#include "components/test_runner/test_interfaces.h"
|
||||
#include "components/test_runner/web_test_interfaces.h"
|
||||
#include "components/test_runner/web_test_runner.h"
|
||||
#include "content/common/input/input_event_utils.h"
|
||||
#include "content/public/common/content_client.h"
|
||||
#include "content/public/renderer/render_thread.h"
|
||||
#include "content/public/test/layouttest_support.h"
|
||||
#include "content/shell/common/layout_test/layout_test_messages.h"
|
||||
#include "content/shell/common/layout_test/layout_test_switches.h"
|
||||
#include "content/shell/common/shell_messages.h"
|
||||
#include "content/shell/renderer/layout_test/blink_test_runner.h"
|
||||
@ -82,6 +84,8 @@ bool LayoutTestRenderThreadObserver::OnControlMessageReceived(
|
||||
bool handled = true;
|
||||
IPC_BEGIN_MESSAGE_MAP(LayoutTestRenderThreadObserver, message)
|
||||
IPC_MESSAGE_HANDLER(ShellViewMsg_SetWebKitSourceDir, OnSetWebKitSourceDir)
|
||||
IPC_MESSAGE_HANDLER(LayoutTestMsg_ReplicateLayoutTestRuntimeFlagsChanges,
|
||||
OnReplicateLayoutTestRuntimeFlagsChanges)
|
||||
IPC_MESSAGE_UNHANDLED(handled = false)
|
||||
IPC_END_MESSAGE_MAP()
|
||||
|
||||
@ -93,4 +97,10 @@ void LayoutTestRenderThreadObserver::OnSetWebKitSourceDir(
|
||||
webkit_source_dir_ = webkit_source_dir;
|
||||
}
|
||||
|
||||
void LayoutTestRenderThreadObserver::OnReplicateLayoutTestRuntimeFlagsChanges(
|
||||
const base::DictionaryValue& changed_layout_test_runtime_flags) {
|
||||
test_interfaces()->TestRunner()->ReplicateLayoutTestRuntimeFlagsChanges(
|
||||
changed_layout_test_runtime_flags);
|
||||
}
|
||||
|
||||
} // namespace content
|
||||
|
@ -13,6 +13,10 @@
|
||||
#include "content/public/renderer/render_thread_observer.h"
|
||||
#include "ipc/ipc_platform_file.h"
|
||||
|
||||
namespace base {
|
||||
class DictionaryValue;
|
||||
}
|
||||
|
||||
namespace blink {
|
||||
class WebFrame;
|
||||
}
|
||||
@ -48,6 +52,8 @@ class LayoutTestRenderThreadObserver : public RenderThreadObserver {
|
||||
private:
|
||||
// Message handlers.
|
||||
void OnSetWebKitSourceDir(const base::FilePath& webkit_source_dir);
|
||||
void OnReplicateLayoutTestRuntimeFlagsChanges(
|
||||
const base::DictionaryValue& changed_layout_test_runtime_flags);
|
||||
|
||||
test_runner::WebTestDelegate* test_delegate_;
|
||||
std::unique_ptr<test_runner::WebTestInterfaces> test_interfaces_;
|
||||
|
@ -1,7 +1,7 @@
|
||||
# These tests currently fail when they run with --site-per-process.
|
||||
# See https://crbug.com/477150.
|
||||
|
||||
# https://crbug.com/584984 - Recent, uninvestigated yet regression.
|
||||
# https://crbug.com/584984 - crash in content::NavigationEntryImpl::SetBindings
|
||||
http/tests/security/opened-document-security-origin-resets-on-navigation.html [ Crash ]
|
||||
|
||||
# https://crbug.com/582494 - [sigsegv / av] blink::Document::styleEngine.
|
||||
@ -50,9 +50,6 @@ http/tests/security/xssAuditor/full-block-script-tag-cross-domain.html [ Failure
|
||||
http/tests/security/xssAuditor/full-block-post-from-iframe.html [ Failure ]
|
||||
http/tests/security/xssAuditor/xss-protection-parsing-01.html [ Failure ]
|
||||
|
||||
# https://crbug.com/582522 - extra mixedContent checks reported with --site-per-process
|
||||
http/tests/security/mixedContent/insecure-iframe-in-iframe.html [ Failure ]
|
||||
|
||||
# https://crbug.com/582176 - InspectorTest.changeExecutionContext doesn't like OOPIFs.
|
||||
http/tests/inspector/console-cd-completions.html [ Failure ]
|
||||
http/tests/inspector/console-cd.html [ Failure ]
|
||||
@ -60,13 +57,15 @@ http/tests/inspector/console-cd.html [ Failure ]
|
||||
# https://crbug.com/554119 - Popup menu is in the wrong location.
|
||||
http/tests/webfont/popup-menu-load-webfont-after-open.html [ Failure ]
|
||||
|
||||
# https://crbug.com/582525 - testRunner.setAllowDisplayOfInsecureContent is not replicated to OOPIFs.
|
||||
http/tests/security/mixedContent/active-subresource-in-http-iframe-not-blocked.https.html [ Failure Timeout ]
|
||||
# https://crbug.com/602493 - Layout tests harness doesn't support history dump across OOPIFs
|
||||
http/tests/security/mixedContent/insecure-iframe-in-main-frame.html [ Crash ]
|
||||
|
||||
# https://crbug.com/582522 - extra mixedContent checks reported with --site-per-process
|
||||
# https://crbug.com/602497 - Inconsistent console messages about mixed content,
|
||||
# when running with or without --site-per-process
|
||||
http/tests/security/mixedContent/active-subresource-in-http-iframe-not-blocked.https.html [ Failure ]
|
||||
http/tests/security/mixedContent/insecure-iframe-in-iframe.html [ Failure ]
|
||||
http/tests/security/mixedContent/insecure-iframe-in-main-frame-allowed.html [ Failure ]
|
||||
http/tests/security/mixedContent/insecure-iframe-in-main-frame.html [ Failure Crash ]
|
||||
http/tests/security/mixedContent/insecure-image-in-main-frame-allowed.html [ Failure ]
|
||||
http/tests/security/mixedContent/insecure-script-in-main-frame-allowed.html [ Failure ]
|
||||
http/tests/security/referrer-policy-conflicting-policies.html [ Failure ]
|
||||
|
||||
# https://crbug.com/585171 - iframe restored from history should be excluded from performance entries.
|
||||
http/tests/misc/resource-timing-iframe-restored-from-history.html [ Failure Timeout ]
|
||||
|
Reference in New Issue
Block a user