chromium/src
0
Fork 0
Code Activity

capture-mode-projector: Change the string for the low-disk space notification

Browse Source 
Replace the current low-disk string "Recording ended due to critically low
disk space" to “Recording ended due to critically low storage space” so
that it works for both local disk storage and DriveFS.

Change-Id: Ie8244fbde2a76892ef3ba4f0c78bc7f36f97ae5b
Bug: 1303981
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3541095
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Michele Fan <michelefan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#983571}
This commit is contained in:
Michele Fan
2022-03-22 00:22:00 +00:00
committed by Chromium LUCI CQ
parent 76490bdd68
commit 24ca011e55
4 changed files with 4 additions and 4 deletions

4
ash/ash_strings.grd

@ -3907,8 +3907,8 @@ Here are some things you can try to get started.
<message name="IDS_ASH_SCREEN_CAPTURE_MESSAGE" desc="The message shows in the screenshot or screen recording notification.">
Show in folder
</message>
<message name="IDS_ASH_SCREEN_CAPTURE_LOW_DISK_SPACE_MESSAGE" desc="The message shows in the screen recording notification when recording ends due to low disk space.">
Recording ended due to critically low disk space
<message name="IDS_ASH_SCREEN_CAPTURE_LOW_STORAGE_SPACE_MESSAGE" desc="The message shows in the screen recording notification when recording ends due to low storage space.">
Recording ended due to critically low storage space
</message>
<message name="IDS_ASH_SCREEN_CAPTURE_BUTTON_EDIT" desc="The edit button label for the screen capture notification.">
Edit

1
ash/ash_strings_grd/IDS_ASH_SCREEN_CAPTURE_LOW_DISK_SPACE_MESSAGE.png.sha1

@ -1 +0,0 @@
7a2faef8ba50e589e93a386c6baebe85dcde4e62

1
ash/ash_strings_grd/IDS_ASH_SCREEN_CAPTURE_LOW_STORAGE_SPACE_MESSAGE.png.sha1 Normal file

@ -0,0 +1 @@
5de36dd2bf06141745a6b1f7109654bbf76c54ee

2
ash/capture_mode/capture_mode_controller.cc

@ -1232,7 +1232,7 @@ void CaptureModeController::ShowPreviewNotification(
const int title_id = for_video ? IDS_ASH_SCREEN_CAPTURE_RECORDING_TITLE
: IDS_ASH_SCREEN_CAPTURE_SCREENSHOT_TITLE;
const int message_id = for_video && low_disk_space_threshold_reached_
? IDS_ASH_SCREEN_CAPTURE_LOW_DISK_SPACE_MESSAGE
? IDS_ASH_SCREEN_CAPTURE_LOW_STORAGE_SPACE_MESSAGE
: IDS_ASH_SCREEN_CAPTURE_MESSAGE;
message_center::RichNotificationData optional_fields;