Extensions: IconVariants: Remove TODO because errors trump warnings
An error would cause an extension not to be able to load. That likely means warnings are irrelevant. Another benefit of this approach is that all errors are known at the time that the errors are checked, unlike other manifest.json parsers that likely error on the first instance. That said, Icon Variants doesn't currently surface all errors and there isn't a plan to do so. However, it could be done at some point if ever there's an interest. Bug: chromium:344639840 Change-Id: Ia4153d71b9a9a733853158aa73835dbe7f3ce690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6312738 Reviewed-by: David Bertoni <dbertoni@chromium.org> Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Cr-Commit-Position: refs/heads/main@{#1427273}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
8b0ec985e2
commit
2a533b0006
@ -150,7 +150,6 @@ bool IconVariantsHandler::Parse(Extension* extension, std::u16string* error) {
|
||||
ExtensionIconVariants icon_variants = GetIconVariants(*extension);
|
||||
|
||||
// Add any install warnings, handle errors, and then clear out diagnostics.
|
||||
// TODO(crbug.com/41419485): If there is an error, warnings can be omitted.
|
||||
auto& diagnostics = icon_variants.get_diagnostics();
|
||||
for (auto& diagnostic : diagnostics) {
|
||||
// If any error exists, do not load the extension.
|
||||
|
Reference in New Issue
Block a user