chromium/src
0
Fork 0
Code Activity

Portals: Remove is_inside_portal parameter in WebView

Browse Source 
Parameter has been unused since Portals was removed.

Bug: 40287334
Change-Id: Idc6ac40e88ee05b2b8fec3098c68100f279da353
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5676924
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1323363}
This commit is contained in:
Adithya Srinivasan
2024-07-04 15:16:14 +00:00
committed by Chromium LUCI CQ
parent bfc906ee0c
commit 2b04f9ae6d
9 changed files with 7 additions and 21 deletions
components
plugins
renderer
webview_plugin.cc
printing
renderer
print_render_frame_helper.cc
content/renderer
agent_scheduling_group.cc
extensions/renderer
scoped_web_frame.cc
third_party/blink
public
web
web_view.h
renderer
core
exported
web_view_impl.ccweb_view_impl.h
frame
frame_test_helpers.cc
modules
peerconnection
webrtc_audio_renderer_test.cc

1
components/plugins/renderer/webview_plugin.cc

@ -272,7 +272,6 @@ WebViewPlugin::WebViewHelper::WebViewHelper(
/*client=*/this,
/*is_hidden=*/false,
/*prerender_param=*/nullptr,
/*is_inside_portal=*/false,
/*fenced_frame_mode=*/std::nullopt,
/*compositing_enabled=*/false,
/*widgets_never_composited=*/false,

2
components/printing/renderer/print_render_frame_helper.cc

@ -665,7 +665,6 @@ class HeaderAndFooterContext {
/*client=*/nullptr,
/*is_hidden=*/false,
/*prerender_param=*/nullptr,
/*is_inside_portal=*/false,
/*fenced_frame_mode=*/std::nullopt,
/*compositing_enabled=*/false, /*widgets_never_composited=*/false,
/*opener=*/nullptr, mojo::NullAssociatedReceiver(),
@ -941,7 +940,6 @@ void PrepareFrameAndViewForPrint::CopySelection(
/*client=*/this,
/*is_hidden=*/false,
/*prerender_param=*/nullptr,
/*is_inside_portal=*/false,
/*fenced_frame_mode=*/std::nullopt,
/*compositing_enabled=*/false,
/*widgets_never_composited=*/false,

1
content/renderer/agent_scheduling_group.cc

@ -291,7 +291,6 @@ blink::WebView* AgentSchedulingGroup::CreateWebView(
blink::WebView* web_view = blink::WebView::Create(
new SelfOwnedWebViewClient(), params->hidden,
std::move(params->prerender_param),
/*is_inside_portal=*/false,
params->type == mojom::ViewWidgetType::kFencedFrame
? std::make_optional(params->fenced_frame_mode)
: std::nullopt,

1
extensions/renderer/scoped_web_frame.cc

@ -25,7 +25,6 @@ ScopedWebFrame::ScopedWebFrame()
/*client=*/nullptr,
/*is_hidden=*/false,
/*prerender_param=*/nullptr,
/*is_inside_portal=*/false,
/*fenced_frame_mode=*/std::nullopt,
/*compositing_enabled=*/false,
/*widgets_never_composited=*/false,

1
third_party/blink/public/web/web_view.h vendored

@ -139,7 +139,6 @@ class BLINK_EXPORT WebView {
WebViewClient*,
bool is_hidden,
blink::mojom::PrerenderParamPtr prerender_param,
bool is_inside_portal,
std::optional<blink::FencedFrame::DeprecatedFencedFrameMode>
fenced_frame_mode,
bool compositing_enabled,

17
third_party/blink/renderer/core/exported/web_view_impl.cc vendored

@ -485,7 +485,6 @@ WebView* WebView::Create(
WebViewClient* client,
bool is_hidden,
blink::mojom::PrerenderParamPtr prerender_param,
bool is_inside_portal,
std::optional<blink::FencedFrame::DeprecatedFencedFrameMode>
fenced_frame_mode,
bool compositing_enabled,
@ -502,18 +501,17 @@ WebView* WebView::Create(
client,
is_hidden ? mojom::blink::PageVisibilityState::kHidden
: mojom::blink::PageVisibilityState::kVisible,
std::move(prerender_param), is_inside_portal, fenced_frame_mode,
compositing_enabled, widgets_never_composited, To<WebViewImpl>(opener),
std::move(page_handle), agent_group_scheduler,
session_storage_namespace_id, std::move(page_base_background_color),
browsing_context_group_info, color_provider_colors);
std::move(prerender_param), fenced_frame_mode, compositing_enabled,
widgets_never_composited, To<WebViewImpl>(opener), std::move(page_handle),
agent_group_scheduler, session_storage_namespace_id,
std::move(page_base_background_color), browsing_context_group_info,
color_provider_colors);
}
WebViewImpl* WebViewImpl::Create(
WebViewClient* client,
mojom::blink::PageVisibilityState visibility,
blink::mojom::PrerenderParamPtr prerender_param,
bool is_inside_portal,
std::optional<blink::FencedFrame::DeprecatedFencedFrameMode>
fenced_frame_mode,
bool compositing_enabled,
@ -526,8 +524,8 @@ WebViewImpl* WebViewImpl::Create(
const BrowsingContextGroupInfo& browsing_context_group_info,
const ColorProviderColorMaps* color_provider_colors) {
return new WebViewImpl(
client, visibility, std::move(prerender_param), is_inside_portal,
fenced_frame_mode, compositing_enabled, widgets_never_composited, opener,
client, visibility, std::move(prerender_param), fenced_frame_mode,
compositing_enabled, widgets_never_composited, opener,
std::move(page_handle), agent_group_scheduler,
session_storage_namespace_id, std::move(page_base_background_color),
browsing_context_group_info, color_provider_colors);
@ -584,7 +582,6 @@ WebViewImpl::WebViewImpl(
WebViewClient* client,
mojom::blink::PageVisibilityState visibility,
blink::mojom::PrerenderParamPtr prerender_param,
bool is_inside_portal,
std::optional<blink::FencedFrame::DeprecatedFencedFrameMode>
fenced_frame_mode,
bool does_composite,

2
third_party/blink/renderer/core/exported/web_view_impl.h vendored

@ -121,7 +121,6 @@ class CORE_EXPORT WebViewImpl final : public WebView,
WebViewClient*,
mojom::blink::PageVisibilityState visibility,
blink::mojom::PrerenderParamPtr prerender_param,
bool is_inside_portal,
std::optional<blink::FencedFrame::DeprecatedFencedFrameMode>
fenced_frame_mode,
bool compositing_enabled,
@ -706,7 +705,6 @@ class CORE_EXPORT WebViewImpl final : public WebView,
WebViewClient*,
mojom::blink::PageVisibilityState visibility,
blink::mojom::PrerenderParamPtr prerender_param,
bool is_inside_portal,
std::optional<blink::FencedFrame::DeprecatedFencedFrameMode>
fenced_frame_mode,
bool does_composite,

2
third_party/blink/renderer/core/frame/frame_test_helpers.cc vendored

@ -737,7 +737,6 @@ void WebViewHelper::InitializeWebView(
web_view_ = To<WebViewImpl>(
WebView::Create(web_view_client,
/*is_hidden=*/is_prerendering, std::move(prerender_param),
/*is_inside_portal=*/false,
/*fenced_frame_mode=*/fenced_frame_mode,
/*compositing_enabled=*/true,
/*widgets_never_composited=*/false,
@ -781,7 +780,6 @@ WebViewImpl* WebViewHelper::CreateWebView(WebViewClient* web_view_client,
WebView::Create(web_view_client,
/*is_hidden=*/false,
/*prerender_param=*/nullptr,
/*is_inside_portal=*/false,
/*fenced_frame_mode=*/std::nullopt, compositing_enabled,
/*widgets_never_composited=*/false,
/*opener=*/nullptr, mojo::NullAssociatedReceiver(),

1
third_party/blink/renderer/modules/peerconnection/webrtc_audio_renderer_test.cc vendored

@ -150,7 +150,6 @@ class WebRtcAudioRendererTest : public testing::Test {
/*client=*/nullptr,
/*is_hidden=*/false,
/*prerender_param=*/nullptr,
/*is_inside_portal=*/false,
/*fenced_frame_mode=*/std::nullopt,
/*compositing_enabled=*/false,
/*widgets_never_composited=*/false,