chromium/src
0
Fork 0
Code Activity

Remove unneeded headers from ui/views/view.h.

Browse Source 
Then fix the build for files that were missing direct includes.

Change-Id: Ibaa0b10c718398b99b6dc00d9aafddc6ac5fdbaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2881319
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881295}
This commit is contained in:
Lei Zhang
2021-05-10 23:06:22 +00:00
committed by Chromium LUCI CQ
parent 6dc460eeb4
commit 2c03d13885
35 changed files with 37 additions and 5 deletions

1
ash/app_list/views/result_selection_controller.cc

@ -8,6 +8,7 @@
#include "ash/app_list/app_list_util.h"
#include "ash/app_list/views/search_result_container_view.h"
#include "base/i18n/rtl.h"
namespace ash {

1
ash/app_list/views/result_selection_controller_unittest.cc

@ -17,6 +17,7 @@
#include "ash/app_list/views/search_result_actions_view.h"
#include "ash/app_list/views/search_result_actions_view_delegate.h"
#include "ash/app_list/views/search_result_container_view.h"
#include "base/i18n/rtl.h"
#include "base/macros.h"
#include "base/strings/stringprintf.h"
#include "ui/events/event.h"

1
ash/hud_display/memory_graph_page_view.cc

@ -10,6 +10,7 @@
#include "ash/hud_display/grid.h"
#include "ash/hud_display/hud_constants.h"
#include "base/logging.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "ui/base/metadata/metadata_impl_macros.h"

1
ash/shelf/hotseat_widget.cc

@ -25,6 +25,7 @@
#include "ash/wm/overview/overview_controller.h"
#include "ash/wm/overview/overview_observer.h"
#include "ash/wm/tablet_mode/tablet_mode_controller.h"
#include "base/i18n/rtl.h"
#include "base/metrics/histogram_macros.h"
#include "ui/aura/scoped_window_targeter.h"
#include "ui/aura/window_targeter.h"

1
ash/shelf/scroll_arrow_view.cc

@ -8,6 +8,7 @@
#include "ash/resources/vector_icons/vector_icons.h"
#include "ash/shelf/shelf_button_delegate.h"
#include "ash/style/ash_color_provider.h"
#include "base/i18n/rtl.h"
#include "ui/compositor/scoped_layer_animation_settings.h"
#include "ui/gfx/canvas.h"
#include "ui/gfx/image/image_skia_operations.h"

1
ash/shelf/scrollable_shelf_view.cc

@ -17,6 +17,7 @@
#include "ash/system/status_area_widget.h"
#include "ash/wm/tablet_mode/tablet_mode_controller.h"
#include "base/bind.h"
#include "base/i18n/rtl.h"
#include "base/metrics/histogram_functions.h"
#include "base/numerics/ranges.h"
#include "ui/base/dragdrop/mojom/drag_drop_types.mojom-shared.h"

1
ash/shelf/shelf.cc

@ -31,6 +31,7 @@
#include "base/bind.h"
#include "base/callback_helpers.h"
#include "base/check.h"
#include "base/i18n/rtl.h"
#include "base/memory/weak_ptr.h"
#include "base/notreached.h"
#include "ui/display/types/display_constants.h"

1
ash/shelf/shelf_app_button.cc

@ -18,6 +18,7 @@
#include "ash/style/default_colors.h"
#include "ash/wm/tablet_mode/tablet_mode_controller.h"
#include "base/bind.h"
#include "base/i18n/rtl.h"
#include "base/metrics/histogram_macros.h"
#include "base/stl_util.h"
#include "base/time/time.h"

1
ash/shelf/shelf_navigation_widget.cc

@ -20,6 +20,7 @@
#include "ash/system/status_area_widget.h"
#include "ash/wm/tablet_mode/tablet_mode_controller.h"
#include "base/bind.h"
#include "base/i18n/rtl.h"
#include "base/memory/weak_ptr.h"
#include "base/metrics/histogram_macros.h"
#include "ui/base/l10n/l10n_util.h"

1
ash/system/accessibility/select_to_speak_menu_view.cc

@ -13,6 +13,7 @@
#include "ash/system/accessibility/select_to_speak_metrics_utils.h"
#include "ash/system/tray/tray_constants.h"
#include "base/bind.h"
#include "base/i18n/rtl.h"
#include "base/metrics/histogram_functions.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/metadata/metadata_impl_macros.h"

1
ash/system/holding_space/holding_space_tray_icon.cc

@ -18,6 +18,7 @@
#include "base/barrier_closure.h"
#include "base/containers/adapters.h"
#include "base/containers/unique_ptr_adapters.h"
#include "base/i18n/rtl.h"
#include "base/stl_util.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/metadata/metadata_impl_macros.h"

1
ash/system/message_center/notification_swipe_control_view.cc

@ -6,6 +6,7 @@
#include "ash/system/message_center/message_center_style.h"
#include "ash/system/message_center/metrics_utils.h"
#include "base/i18n/rtl.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/compositor/layer.h"
#include "ui/events/event.h"

1
ash/wm/splitview/split_view_highlight_view.cc

@ -9,6 +9,7 @@
#include "ash/style/default_color_constants.h"
#include "ash/style/default_colors.h"
#include "ash/wm/splitview/split_view_controller.h"
#include "base/i18n/rtl.h"
#include "ui/compositor/layer.h"
#include "ui/views/view.h"
#include "ui/views/view_observer.h"

1
chrome/browser/ui/views/download/download_started_animation_views.cc

@ -4,6 +4,7 @@
#include "chrome/browser/download/download_started_animation.h"
#include "base/i18n/rtl.h"
#include "base/macros.h"
#include "base/time/time.h"
#include "chrome/app/vector_icons/vector_icons.h"

1
chrome/browser/ui/views/tabs/tab_icon.cc

@ -4,6 +4,7 @@
#include "chrome/browser/ui/views/tabs/tab_icon.h"
#include "base/i18n/rtl.h"
#include "base/metrics/histogram_macros.h"
#include "base/time/default_tick_clock.h"
#include "base/timer/elapsed_timer.h"

1
components/media_message_center/media_notification_background_ash_impl.cc

@ -4,6 +4,7 @@
#include "components/media_message_center/media_notification_background_ash_impl.h"
#include "base/i18n/rtl.h"
#include "ui/gfx/canvas.h"
#include "ui/gfx/image/image_skia_operations.h"
#include "ui/gfx/skia_util.h"

1
components/media_message_center/media_notification_background_impl.cc

@ -7,6 +7,7 @@
#include <algorithm>
#include <vector>
#include "base/i18n/rtl.h"
#include "skia/ext/image_operations.h"
#include "ui/gfx/canvas.h"
#include "ui/gfx/color_analysis.h"

1
components/media_message_center/media_notification_background_impl_unittest.cc

@ -7,6 +7,7 @@
#include <memory>
#include "base/i18n/base_i18n_switches.h"
#include "base/i18n/rtl.h"
#include "base/test/icu_test_util.h"
#include "base/test/scoped_command_line.h"
#include "testing/gtest/include/gtest/gtest.h"

1
ui/views/controls/focus_ring.cc

@ -7,6 +7,7 @@
#include <memory>
#include <utility>
#include "base/i18n/rtl.h"
#include "base/memory/ptr_util.h"
#include "base/notreached.h"
#include "ui/accessibility/ax_enums.mojom.h"

1
ui/views/controls/image_view.cc

@ -7,6 +7,7 @@
#include <utility>
#include "base/check_op.h"
#include "base/i18n/rtl.h"
#include "base/numerics/safe_conversions.h"
#include "cc/paint/paint_flags.h"
#include "skia/ext/image_operations.h"

1
ui/views/controls/menu/menu_runner_cocoa_unittest.mm

@ -7,6 +7,7 @@
#import <Cocoa/Cocoa.h>
#include "base/bind.h"
#include "base/i18n/rtl.h"
#include "base/macros.h"
#include "base/run_loop.h"
#include "base/strings/utf_string_conversions.h"

1
ui/views/controls/menu/menu_runner_impl_cocoa.mm

@ -4,6 +4,7 @@
#import "ui/views/controls/menu/menu_runner_impl_cocoa.h"
#include "base/i18n/rtl.h"
#include "base/mac/mac_util.h"
#import "base/message_loop/message_pump_mac.h"
#import "skia/ext/skia_utils_mac.h"

1
ui/views/controls/resize_area.cc

@ -4,6 +4,7 @@
#include "ui/views/controls/resize_area.h"
#include "base/i18n/rtl.h"
#include "ui/accessibility/ax_enums.mojom.h"
#include "ui/accessibility/ax_node_data.h"
#include "ui/base/cursor/cursor.h"

1
ui/views/controls/scroll_view.cc

@ -9,6 +9,7 @@
#include "base/bind.h"
#include "base/check_op.h"
#include "base/feature_list.h"
#include "base/i18n/rtl.h"
#include "base/macros.h"
#include "base/numerics/ranges.h"
#include "build/build_config.h"

1
ui/views/controls/scrollbar/base_scroll_bar_thumb.cc

@ -4,6 +4,7 @@
#include "ui/views/controls/scrollbar/base_scroll_bar_thumb.h"
#include "base/i18n/rtl.h"
#include "ui/base/metadata/metadata_impl_macros.h"
#include "ui/gfx/canvas.h"
#include "ui/gfx/geometry/rect.h"

1
ui/views/controls/scrollbar/cocoa_scroll_bar.mm

@ -5,6 +5,7 @@
#import "ui/views/controls/scrollbar/cocoa_scroll_bar.h"
#include "base/bind.h"
#include "base/i18n/rtl.h"
#include "base/stl_util.h"
#include "cc/paint/paint_shader.h"
#include "third_party/skia/include/core/SkColor.h"

1
ui/views/controls/scrollbar/overlay_scroll_bar.cc

@ -7,6 +7,7 @@
#include <memory>
#include "base/bind.h"
#include "base/i18n/rtl.h"
#include "base/macros.h"
#include "cc/paint/paint_flags.h"
#include "third_party/skia/include/core/SkColor.h"

1
ui/views/controls/slider.cc

@ -10,6 +10,7 @@
#include <utility>
#include "base/check_op.h"
#include "base/i18n/rtl.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/task/current_thread.h"

1
ui/views/controls/table/table_header.cc

@ -10,6 +10,7 @@
#include <memory>
#include <vector>
#include "base/i18n/rtl.h"
#include "cc/paint/paint_flags.h"
#include "third_party/skia/include/core/SkColor.h"
#include "third_party/skia/include/core/SkPath.h"

1
ui/views/examples/menu_example.cc

@ -7,6 +7,7 @@
#include <memory>
#include <set>
#include "base/logging.h"
#include "base/macros.h"
#include "base/strings/utf_string_conversions.h"
#include "ui/base/l10n/l10n_util.h"

1
ui/views/interaction/element_tracker_views.cc

@ -8,6 +8,7 @@
#include <map>
#include "base/containers/contains.h"
#include "base/logging.h"
#include "base/no_destructor.h"
#include "base/scoped_multi_source_observation.h"
#include "ui/base/interaction/element_identifier.h"

1
ui/views/layout/flex_layout.cc

@ -7,6 +7,7 @@
#include <algorithm>
#include <functional>
#include <numeric>
#include <sstream>
#include <string>
#include <utility>
#include <vector>

5
ui/views/view.h

@ -8,20 +8,15 @@
#include <stddef.h>
#include <algorithm>
#include <map>
#include <memory>
#include <set>
#include <string>
#include <utility>
#include <vector>
#include "base/bind.h"
#include "base/callback.h"
#include "base/callback_list.h"
#include "base/compiler_specific.h"
#include "base/i18n/rtl.h"
#include "base/logging.h"
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/optional.h"
#include "base/strings/string_piece.h"

4
ui/views/view_utils.cc

@ -4,6 +4,10 @@
#include "ui/views/view_utils.h"
#include <sstream>
#include "base/logging.h"
namespace views {
ViewDebugWrapperImpl::ViewDebugWrapperImpl(View* view) : view_(view) {}

1
ui/views/widget/widget.cc

@ -11,6 +11,7 @@
#include "base/check_op.h"
#include "base/containers/adapters.h"
#include "base/feature_list.h"
#include "base/i18n/rtl.h"
#include "base/macros.h"
#include "base/notreached.h"
#include "base/strings/utf_string_conversions.h"