0

Add RLZ build file for GN build, fix Windows build.

Some ICU settings were incorrect in the non-component build that caused functions not to get linked properly.

We set the wrong exception handling flag in non-component mode.

Add rlz to the GN build.

Some NSS files were missing.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/307993010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274298 0039d316-1c4b-4281-b951-d872f2087c98
This commit is contained in:
brettw@chromium.org
2014-06-02 19:16:36 +00:00
parent 6e2d03a37f
commit 2d6893a2a7
5 changed files with 156 additions and 10 deletions
BUILD.gn
build/config/compiler
rlz
tools/gn/secondary/third_party

@ -104,6 +104,13 @@ group("root") {
]
}
if (is_win || is_mac || is_chromeos) {
# RLZ works on these platforms.
deps += [
"//rlz:rlz_lib",
]
}
if (is_android) {
deps -= [
"//cc",

@ -43,10 +43,14 @@ config("compiler") {
cflags += [
"/Gy", # Enable function-level linking.
"/GS", # Enable buffer security checking.
"/EHsc", # Assume C functions can't throw exceptions and don't catch
# structured exceptions (only C++ ones).
"/FS", # Preserve previous PDB behavior.
]
if (is_component_build) {
cflags += [
"/EHsc", # Assume C functions can't throw exceptions and don't catch
# structured exceptions (only C++ ones).
]
}
} else {
# Common GCC compiler flags setup.
# --------------------------------

136
rlz/BUILD.gn Normal file

@ -0,0 +1,136 @@
# Copyright 2014 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
# Note that this build file assumes rlz_use_chrome_net which is a condition in
# the GYP file, but is always true for Chrome builds.
config("rlz_config") {
defines = [ "RLZ_NETWORK_IMPLEMENTATION_CHROME_NET" ]
}
source_set("rlz_lib") {
sources = [
"chromeos/lib/machine_id_chromeos.cc",
"chromeos/lib/rlz_value_store_chromeos.cc",
"chromeos/lib/rlz_value_store_chromeos.h",
"ios/lib/machine_id_ios.cc",
"lib/assert.cc",
"lib/assert.h",
"lib/crc32.h",
"lib/crc32_wrapper.cc",
"lib/crc8.h",
"lib/crc8.cc",
"lib/financial_ping.cc",
"lib/financial_ping.h",
"lib/lib_values.cc",
"lib/machine_id.cc",
"lib/machine_id.h",
"lib/recursive_cross_process_lock_posix.cc",
"lib/recursive_cross_process_lock_posix.h",
"lib/rlz_enums.h",
"lib/rlz_lib.cc",
"lib/rlz_lib.h",
"lib/rlz_lib_clear.cc",
"lib/lib_values.h",
"lib/rlz_value_store.h",
"lib/string_utils.cc",
"lib/string_utils.h",
"mac/lib/machine_id_mac.cc",
"mac/lib/rlz_value_store_mac.mm",
"mac/lib/rlz_value_store_mac.h",
"win/lib/lib_mutex.cc",
"win/lib/lib_mutex.h",
"win/lib/machine_deal.cc",
"win/lib/machine_deal.h",
"win/lib/machine_id_win.cc",
"win/lib/process_info.cc",
"win/lib/process_info.h",
"win/lib/registry_util.cc",
"win/lib/registry_util.h",
"win/lib/rlz_lib_win.cc",
"win/lib/rlz_value_store_registry.cc",
"win/lib/rlz_value_store_registry.h",
]
direct_dependent_configs = [ ":rlz_config" ]
deps = [
"//base",
"//base/third_party/dynamic_annotations",
"//net",
]
if (is_ios) {
# These _mac files are also used on iOS.
set_sources_assignment_filter([])
sources += [
"mac/lib/rlz_value_store_mac.mm",
"mac/lib/rlz_value_store_mac.h",
]
set_sources_assignment_filter(sources_assignment_filter)
} else if (is_win) {
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
cflags = [ "/wd4267" ]
}
}
source_set("test_support") {
sources = [
"test/rlz_test_helpers.cc",
"test/rlz_test_helpers.h",
]
deps = [
":rlz_lib",
"//base",
"//base/test:test_support",
"//testing/gtest",
]
}
test("rlz_unittests") {
sources = [
"lib/crc32_unittest.cc",
"lib/crc8_unittest.cc",
"lib/financial_ping_test.cc",
"lib/lib_values_unittest.cc",
"lib/machine_id_unittest.cc",
"lib/rlz_lib_test.cc",
"lib/string_utils_unittest.cc",
"test/rlz_unittest_main.cc",
"win/lib/machine_deal_test.cc",
]
deps = [
":rlz_lib",
":test_support",
"//base",
"//base:prefs",
"//net:test_support",
"//testing/gmock",
"//testing/gtest",
"//third_party/zlib",
]
}
executable("rlz_id") {
sources = [
"examples/rlz_id.cc",
]
deps = [
":rlz_lib",
]
}
if (is_win) {
shared_library("rlz") {
sources = [
"win/dll/dll_main.cc",
"win/dll/exports.cc",
]
deps = [
":rlz_lib",
"//third_party/zlib",
]
}
}

@ -16,6 +16,11 @@ config("icu_config") {
defines = [
"U_USING_ICU_NAMESPACE=0",
]
if (component_mode != "shared_library") {
defines += [ "U_STATIC_IMPLEMENTATION" ]
}
include_dirs = [
"source/common",
"source/i18n",
@ -24,10 +29,6 @@ config("icu_config") {
# Config used only by ICU code.
config("icu_code") {
if (component_mode != "shared_library") {
defines = [ "U_STATIC_IMPLEMENTATION" ]
}
if (is_win) {
# Disable some compiler warnings.
cflags = [

@ -1090,10 +1090,6 @@ if (is_linux) {
}
if (is_win) {
sources -= [
"nss/lib/freebl/mpi/mpi_amd64.c",
"nss/lib/freebl/mpi/mpi_x86_asm.c",
]
defines += [
"SHLIB_SUFFIX=\"dll\"",
"SHLIB_PREFIX=\"\"",
@ -1104,6 +1100,7 @@ if (is_linux) {
]
if (cpu_arch == "x86") {
sources -= [ "nss/lib/freebl/mpi/mpi_amd64.c" ]
defines += [
"NSS_X86_OR_X64",
"NSS_X86",
@ -1115,6 +1112,7 @@ if (is_linux) {
"MP_NO_MP_WORD",
]
} else if (cpu_arch == "x64") {
sources -= [ "nss/lib/freebl/mpi/mpi_x86_asm.c" ]
defines += [
"NSS_USE_64",
"NSS_X86_OR_X64",