chromium/src
0
Fork 0
Code Activity

Fix the references to the ui.ChromeLogin

Browse Source 
ui.ChromeLogin and ui.ChromeLoginGAIA were renamed in
http://crrev/c/2981353

Bug: b:187788829, 1227801, 1167243, 1115622
Change-Id: I00b843ebd8eb45600dbde0d1a4893df2e0d909e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3015347
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900543}
This commit is contained in:
Roman Sorokin
2021-07-12 17:30:22 +00:00
committed by Chromium LUCI CQ
parent d12ff5461f
commit 2f61daf119
2 changed files with 8 additions and 8 deletions

2
build/chromeos/test_runner.py

@ -970,7 +970,7 @@ def main():
'-t',
action='append',
dest='tests',
help='A Tast test to run in the device (eg: "ui.ChromeLogin").')
help='A Tast test to run in the device (eg: "login.Chrome").')
tast_test_parser.add_argument(
'--gtest_filter',
type=str,

14
build/chromeos/test_runner_test.py

@ -19,7 +19,7 @@ import six
import test_runner
_TAST_TEST_RESULTS_JSON = {
"name": "ui.ChromeLogin",
"name": "login.Chrome",
"errors": None,
"start": "2020-01-01T15:41:30.799228462-08:00",
"end": "2020-01-01T15:41:53.318914698-08:00",
@ -101,7 +101,7 @@ class TastTests(TestRunnerTest):
args = self.get_common_tast_args(False) + [
'--attr-expr=( "group:mainline" && "dep:chrome" && !informational)',
'--gtest_filter=ui.ChromeLogin:ui.WindowControl',
'--gtest_filter=login.Chrome:ui.WindowControl',
]
with mock.patch.object(sys, 'argv', args),\
mock.patch.object(test_runner.subprocess, 'Popen') as mock_popen:
@ -111,7 +111,7 @@ class TastTests(TestRunnerTest):
# The gtest filter should cause the Tast expr to be replaced with a list
# of the tests in the filter.
expected_cmd = self.get_common_tast_expectations(False) + [
'--tast=("name:ui.ChromeLogin" || "name:ui.WindowControl")'
'--tast=("name:login.Chrome" || "name:ui.WindowControl")'
]
self.safeAssertItemsEqual(expected_cmd, mock_popen.call_args[0][0])
@ -179,7 +179,7 @@ class TastTests(TestRunnerTest):
json.dump(_TAST_TEST_RESULTS_JSON, f)
args = self.get_common_tast_args(use_vm) + [
'-t=ui.ChromeLogin',
'-t=login.Chrome',
'--tast-var=key=value',
]
with mock.patch.object(sys, 'argv', args),\
@ -187,7 +187,7 @@ class TastTests(TestRunnerTest):
mock_popen.return_value.returncode = 0
test_runner.main()
expected_cmd = self.get_common_tast_expectations(use_vm) + [
'--tast', 'ui.ChromeLogin', '--tast-var', 'key=value'
'--tast', 'login.Chrome', '--tast-var', 'key=value'
]
self.safeAssertItemsEqual(expected_cmd, mock_popen.call_args[0][0])
@ -202,7 +202,7 @@ class TastTests(TestRunnerTest):
json.dump(_TAST_TEST_RESULTS_JSON, f)
args = self.get_common_tast_args(use_vm) + [
'-t=ui.ChromeLogin',
'-t=login.Chrome',
]
with mock.patch.object(sys, 'argv', args),\
mock.patch.object(test_runner.subprocess, 'Popen') as mock_popen:
@ -210,7 +210,7 @@ class TastTests(TestRunnerTest):
test_runner.main()
expected_cmd = self.get_common_tast_expectations(use_vm) + [
'--tast', 'ui.ChromeLogin'
'--tast', 'login.Chrome'
]
self.safeAssertItemsEqual(expected_cmd, mock_popen.call_args[0][0])