chromium/src
0
Fork 0
Code Activity

Make use of rtc_common_public_deps

Browse Source 
Context: This is a follow-up to:
https://webrtc-review.googlesource.com/c/src/+/316660

WebRTC do not use GN `public_deps`. See:
https://webrtc-review.googlesource.com/c/src/+/316660
WebRTC developers made this decision, because GN config are "translated"
toward different kind of downstream build system who do not really
support the `public` dependencies concept.

Instead, WebRTC provides its embedders (e.g. chromium here) a variable
to define a set of dependencies used commonly by every WebRTC targets.
This patch makes use of it, by adding a public dependency over "//base".
This is used amon others by `webrtc::Location`, because it is
implemented by `base::Location`.

Bug: chromium:1467773
Change-Id: I5988e16b69d0357a335ea8ef2fa5e80b7c6eb441
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4818407
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1207060}
This commit is contained in:
Arthur Sonzogni
2023-10-09 14:13:14 +00:00
committed by Chromium LUCI CQ
parent 3e42b13a57
commit 2f9404dba9
1 changed files with 6 additions and 0 deletions

6
.gn

@ -39,6 +39,12 @@ default_args = {
# Don't include webrtc's builtin task queue implementation.
rtc_link_task_queue_impl = false
# When building with Chromium, `webrtc::Location` is replaced by
# `base::Location`. Since WebRTC doesn't use `public_deps` (webrtc:8603), it
# would fail to propagate the dependency internally. Instead WebRTC let its
# embedders to define it globally for all of its targets.
rtc_common_public_deps = [ "//base" ]
# Don't include the iLBC audio codec.
# TODO(bugs.webrtc.org/8396): Once WebRTC gets rid of its internal
# deps on codecs, we can remove this.