chromium/src
0
Fork 0
Code Activity

Remove gl_renderer_screenshot_sync_tests

Browse Source 
These tests are for an obsolete code path. Removing them.

Bug: 1289372
Change-Id: I3f73f082428fc50acc28a877b60ba6116de82d34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3483803
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#974333}
This commit is contained in:
Jonathan Ross
2022-02-23 21:36:22 +00:00
committed by Chromium LUCI CQ
parent 9c6468ea1f
commit 2fee48c9bf
5 changed files with 0 additions and 164 deletions

1
docs/gpu/gpu_testing.md

@ -320,7 +320,6 @@ of all suites and resulting step names as of April 15th 2021:
* `power`
* `power_measurement_test`
* `screenshot_sync`
* `gl_renderer_screenshot_sync_tests`
* `screenshot_sync_passthrough_tests`
* `screenshot_sync_tests`
* `screenshot_sync_validating_tests`

52
testing/buildbot/chromium.gpu.fyi.json

@ -5635,58 +5635,6 @@
},
"test_id_prefix": "ninja://chrome/test:telemetry_gpu_integration_test/"
},
{
"args": [
"screenshot_sync",
"--show-stdout",
"--browser=cros-chrome",
"--passthrough",
"-v",
"--extra-browser-args=--log-level=0 --js-flags=--expose-gc --disable-features=UseSkiaRenderer",
"--dont-restore-color-profile-after-test",
"--remote=127.0.0.1",
"--remote-ssh-port=9222"
],
"isolate_name": "telemetry_gpu_integration_test",
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "gl_renderer_screenshot_sync_tests",
"resultdb": {
"enable": true,
"has_native_resultdb_integration": true
},
"should_retry_with_patch": false,
"swarming": {
"can_use_on_swarming_builders": true,
"containment_type": "AUTO",
"dimension_sets": [
{
"cpu": "x86",
"kvm": "1",
"os": "Ubuntu-18.04",
"pool": "chromium.tests"
}
],
"idempotent": false,
"named_caches": [
{
"name": "cros_vm",
"path": "magic_cros_vm_cache"
}
],
"optional_dimensions": {
"60": [
{
"caches": "cros_vm"
}
]
},
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test_id_prefix": "ninja://chrome/test:telemetry_gpu_integration_test/"
},
{
"args": [
"gpu_process",

72
testing/buildbot/chromium.gpu.json

@ -571,42 +571,6 @@
},
"test_id_prefix": "ninja://chrome/test:telemetry_gpu_integration_test/"
},
{
"args": [
"screenshot_sync",
"--show-stdout",
"--browser=debug",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --disable-features=UseSkiaRenderer",
"--dont-restore-color-profile-after-test"
],
"isolate_name": "telemetry_gpu_integration_test",
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "gl_renderer_screenshot_sync_tests",
"resultdb": {
"enable": true,
"has_native_resultdb_integration": true
},
"should_retry_with_patch": false,
"swarming": {
"can_use_on_swarming_builders": true,
"containment_type": "AUTO",
"dimension_sets": [
{
"gpu": "10de:2184-440.100",
"os": "Ubuntu-18.04.5|Ubuntu-18.04.6",
"pool": "chromium.tests.gpu"
}
],
"idempotent": false,
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test_id_prefix": "ninja://chrome/test:telemetry_gpu_integration_test/"
},
{
"args": [
"gpu_process",
@ -1029,42 +993,6 @@
},
"test_id_prefix": "ninja://chrome/test:telemetry_gpu_integration_test/"
},
{
"args": [
"screenshot_sync",
"--show-stdout",
"--browser=release",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --disable-features=UseSkiaRenderer",
"--dont-restore-color-profile-after-test"
],
"isolate_name": "telemetry_gpu_integration_test",
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "gl_renderer_screenshot_sync_tests",
"resultdb": {
"enable": true,
"has_native_resultdb_integration": true
},
"should_retry_with_patch": false,
"swarming": {
"can_use_on_swarming_builders": true,
"containment_type": "AUTO",
"dimension_sets": [
{
"gpu": "10de:2184-440.100",
"os": "Ubuntu-18.04.5|Ubuntu-18.04.6",
"pool": "chromium.tests.gpu"
}
],
"idempotent": false,
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test_id_prefix": "ninja://chrome/test:telemetry_gpu_integration_test/"
},
{
"args": [
"gpu_process",

6
testing/buildbot/test_suite_exceptions.pyl

@ -1669,12 +1669,6 @@
'Lacros FYI x64 Release (Intel)',
],
},
'gl_renderer_screenshot_sync_tests': {
'remove_from': [
'ChromeOS FYI Release (kevin)',
'Lacros FYI x64 Release (Intel)',
],
},
'gl_tests_passthrough': {
'remove_from': [
'CFI Linux ToT',

33
testing/buildbot/test_suites.pyl

@ -2900,38 +2900,6 @@
'skia_gold_test',
],
},
'gl_renderer_screenshot_sync_tests': {
'telemetry_test_name': 'screenshot_sync',
'args': [
'--dont-restore-color-profile-after-test',
'--extra-browser-args=--disable-features=UseSkiaRenderer',
],
'chromeos_args': [
'$$MAGIC_SUBSTITUTION_ChromeOSTelemetryRemote',
],
'mixins': [
'has_native_resultdb_integration',
],
},
},
# Very small set of test that exercise GLRenderer and produce pixels for CQ.
# For use where SkiaRenderer is enabled by field trial or default.
'gpu_gl_renderer_small_telemetry_tests': {
'gl_renderer_screenshot_sync': {
'args': [
'--dont-restore-color-profile-after-test',
'--extra-browser-args=--disable-features=UseSkiaRenderer',
],
'android_args': [
# TODO(crbug.com/1093085): Remove this once we fix the tests.
'--extra-browser-args=--force-online-connection-state-for-indicator',
],
'telemetry_test_name': 'screenshot_sync',
'mixins': [
'has_native_resultdb_integration',
],
},
},
'gpu_gles2_conform_gtests': {
@ -6058,7 +6026,6 @@
'gpu_common_and_optional_telemetry_tests',
'gpu_passthrough_telemetry_tests',
'gpu_webgl_conformance_telemetry_tests',
'gpu_gl_renderer_small_telemetry_tests',
],
'gpu_common_telemetry_tests': [