chromium/src
0
Fork 0
Code Activity

Add production string for holding space recent files placeholder.

Browse Source 
This is the string that appears in the recent files bubble of holding
space when the user has no screen captures or downloads.

Bug: 1366615
Change-Id: I94437f494f519317f7a4e580322d33de61688587
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3929359
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1053406}
This commit is contained in:
David Black
2022-09-30 04:59:46 +00:00
committed by Chromium LUCI CQ
parent da283fa89c
commit 301094cb48
3 changed files with 8 additions and 2 deletions

3
ash/ash_strings.grd

@ -1341,6 +1341,9 @@ This file contains the strings for ash.
<message name="IDS_ASH_HOLDING_SPACE_SUGGESTIONS_TITLE" desc="Title of the suggestions area in the holding space bubble.">
Suggested files
</message>
<message name="IDS_ASH_HOLDING_SPACE_RECENT_FILES_PLACEHOLDER" desc="Text displayed in the holding space recent files bubble when the user has no downloads or screen captures.">
You'll find your recent downloads and screen captures here
</message>
<message name="IDS_ASH_HOLDING_SPACE_DOWNLOADS_TITLE" desc="Title of the downloads area in the holding space bubble.">
Downloads
</message>

1
ash/ash_strings_grd/IDS_ASH_HOLDING_SPACE_RECENT_FILES_PLACEHOLDER.png.sha1 Normal file

@ -0,0 +1 @@
3d4b637749700dd4b1d75e05d70fe2b12517e283

6
ash/system/holding_space/recent_files_bubble.cc

@ -8,8 +8,10 @@
#include "ash/constants/ash_features.h"
#include "ash/public/cpp/holding_space/holding_space_constants.h"
#include "ash/public/cpp/resources/grit/ash_public_unscaled_resources.h"
#include "ash/strings/grit/ash_strings.h"
#include "ash/system/holding_space/downloads_section.h"
#include "ash/system/holding_space/screen_captures_section.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/views/controls/image_view.h"
#include "ui/views/controls/label.h"
#include "ui/views/layout/box_layout.h"
@ -56,8 +58,8 @@ std::unique_ptr<views::View> RecentFilesBubble::CreatePlaceholder() {
views::Builder<views::Label>(
bubble_utils::CreateLabel(
bubble_utils::LabelStyle::kSubheader,
u"[i18n]Your recently downloaded files and screen captures "
u"would show up here"))
l10n_util::GetStringUTF16(
IDS_ASH_HOLDING_SPACE_RECENT_FILES_PLACEHOLDER)))
.SetHorizontalAlignment(gfx::HorizontalAlignment::ALIGN_CENTER)
.SetMultiLine(true))
.Build();