0

Roll src/third_party/pdfium/ 600248a49..eebb95eb9 (15 commits; 4 trivial rolls)

https://pdfium.googlesource.com/pdfium.git/+log/600248a4998a..eebb95eb9572

$ git log 600248a49..eebb95eb9 --date=short --no-merges --format='%ad %ae %s'
2025-02-12 awscreen Roll v8/ 75be3dcb5..d53112274 (677 commits; 1 trivial rolls)
2025-02-12 awscreen Add simdutf dependency
2025-02-12 thestig Redo FPDFText_GetLooseCharBox() top/bottom calculation
2025-02-12 awscreen Update skia/BUILD.gn to use gni filegroups for font port files
2025-02-12 thestig Remove unused CFX_Face::GetHeight()
2025-02-12 awscreen Roll abseil, build, buildtools, clang, libc++, llvm-libc, rust together
2025-02-11 thestig Make sure loose char box is at least as big as regular char box
2025-02-11 thestig Flip top/bottom values for FPDFText_GetLooseCharBox() with vertical text
2025-02-11 thestig Call FPDFText_GetCharBox() in FPDFTextEmbedderTest.TextVertical
2025-02-11 thestig Add FPDFText_GetLooseCharBox() test case for diacritics
2025-02-11 thakis fixup_pdf_template: Don't count final newline in {{streamlen}}

Created with:
  roll-dep src/third_party/pdfium

Since the PDFium changes affect pdf_unittests results, adjust the test
expectations to match. PDF text highlighting now better covers the
actual text.

Bug: 42270568, 394805680, 395640955, 395836304
Change-Id: I004d33499465735f20220a8585e1f5d80f9c1719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6261375
Reviewed-by: Alan Screen <awscreen@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1419983}
This commit is contained in:
Lei Zhang
2025-02-13 10:23:03 -08:00
committed by Chromium LUCI CQ
parent 9532fe1a59
commit 3118f0b074
24 changed files with 8 additions and 7 deletions

2
DEPS

@ -296,7 +296,7 @@ vars = {
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling PDFium
# and whatever else without interference from each other.
'pdfium_revision': '600248a4998a1154898bf9f800714c8c2bc48ee3',
'pdfium_revision': 'eebb95eb9572bc724804b4dbb2f449a73a1e96fa',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling BoringSSL
# and whatever else without interference from each other.

@ -366,14 +366,14 @@ IN_PROC_BROWSER_TEST_P(PDFExtensionInteractiveUITest,
gfx::SelectionBound start_bound = touch_selection_controller->start();
EXPECT_EQ(gfx::SelectionBound::LEFT, start_bound.type());
EXPECT_POINTF_NEAR(gfx::PointF(454.0f, 157.0f), start_bound.edge_start(),
EXPECT_POINTF_NEAR(gfx::PointF(454.0f, 152.0f), start_bound.edge_start(),
1.0f);
EXPECT_POINTF_NEAR(gfx::PointF(454.0f, 174.0f), start_bound.edge_end(), 1.0f);
EXPECT_POINTF_NEAR(gfx::PointF(454.0f, 178.0f), start_bound.edge_end(), 1.0f);
gfx::SelectionBound end_bound = touch_selection_controller->end();
EXPECT_EQ(gfx::SelectionBound::RIGHT, end_bound.type());
EXPECT_POINTF_NEAR(gfx::PointF(494.0f, 157.0f), end_bound.edge_start(), 1.0f);
EXPECT_POINTF_NEAR(gfx::PointF(494.0f, 174.0f), end_bound.edge_end(), 1.0f);
EXPECT_POINTF_NEAR(gfx::PointF(494.0f, 152.0f), end_bound.edge_start(), 1.0f);
EXPECT_POINTF_NEAR(gfx::PointF(494.0f, 178.0f), end_bound.edge_end(), 1.0f);
}
#endif // defined(TOOLKIT_VIEWS) && defined(USE_AURA)

@ -1126,7 +1126,8 @@ TEST_P(PDFiumEngineTest, DrawTextSelectionsHelloWorld) {
SetSelection(*engine, /*start_page_index=*/kPageIndex, /*start_char_index=*/1,
/*end_page_index=*/kPageIndex, /*end_char_index=*/2);
EXPECT_EQ("e", engine->GetSelectedText());
DrawSelectionAndCompare(*engine, kPageIndex, "hello_world_selection_1.png");
DrawSelectionAndCompareWithPlatformExpectations(
*engine, kPageIndex, "hello_world_selection_1.png");
SetSelection(*engine, /*start_page_index=*/kPageIndex, /*start_char_index=*/0,
/*end_page_index=*/kPageIndex, /*end_char_index=*/3);

Binary file not shown.

Before

(image error) Size: 511 B

After

(image error) Size: 513 B

Binary file not shown.

Before

(image error) Size: 481 B

After

(image error) Size: 481 B

Binary file not shown.

Before

(image error) Size: 481 B

After

(image error) Size: 480 B

Binary file not shown.

Before

(image error) Size: 481 B

After

(image error) Size: 481 B

Binary file not shown.

Before

(image error) Size: 481 B

After

(image error) Size: 481 B

Binary file not shown.

Before

(image error) Size: 490 B

After

(image error) Size: 486 B

Binary file not shown.

Before

(image error) Size: 479 B

After

(image error) Size: 479 B

Binary file not shown.

Before

(image error) Size: 480 B

After

(image error) Size: 480 B

Binary file not shown.

Before

(image error) Size: 126 B

After

(image error) Size: 127 B

Binary file not shown.

Before

(image error) Size: 128 B

After

(image error) Size: 128 B

Binary file not shown.

Before

(image error) Size: 128 B

After

(image error) Size: 128 B

Binary file not shown.

Before

(image error) Size: 142 B

After

(image error) Size: 142 B

Binary file not shown.

After

(image error) Size: 140 B

Binary file not shown.

After

(image error) Size: 140 B

Binary file not shown.

Before

(image error) Size: 138 B

After

(image error) Size: 138 B

Binary file not shown.

Before

(image error) Size: 138 B

After

(image error) Size: 136 B

Binary file not shown.

Before

(image error) Size: 138 B

After

(image error) Size: 136 B

Binary file not shown.

Before

(image error) Size: 138 B

After

(image error) Size: 139 B

Binary file not shown.

Before

(image error) Size: 138 B

After

(image error) Size: 137 B

Binary file not shown.

Before

(image error) Size: 138 B

After

(image error) Size: 137 B