chromium/src
0
Fork 0
Code Activity

video-conference:modify video conference tooltips to spec

Browse Source 
Just update to the new string provided by PMs

Bug: b/261640628
Change-Id: I1fe8edd58919035a6f54176d2f914c512397919a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4594444
Reviewed-by: Andre Le <leandre@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1154453}
This commit is contained in:
Alex Newcomer
2023-06-07 16:12:39 +00:00
committed by Chromium LUCI CQ
parent 574ed003d8
commit 324eb18a07
3 changed files with 6 additions and 7 deletions

3
ash/ash_strings.grd

@ -1556,6 +1556,9 @@ Style notes:
off
</message>
<!-- Video Conference bubble -->
<message name="IDS_ASH_VIDEO_CONFERENCE_ACCESSIBLE_NAME" desc="The accessible name and tooltip for the video conference bubble, and the button which lives in the tray that shows the bubble.">
Video Call Controls
</message>
<message name="IDS_ASH_VIDEO_CONFERENCE_RETURN_TO_APP_SUMMARY_TEXT" desc="The summary text in the return to app panel of the video conference panel, specifying how many video conferencing apps are in used.">
Used by <ph name="APP_COUNT">$1<ex>2</ex></ph> apps
</message>

1
ash/ash_strings_grd/IDS_ASH_VIDEO_CONFERENCE_ACCESSIBLE_NAME.png.sha1 Normal file

@ -0,0 +1 @@
e7a4fc2ee42d928fb0e9890c02fcb21674c7e671

9
ash/system/video_conference/video_conference_tray.cc

@ -268,16 +268,11 @@ views::Widget* VideoConferenceTray::GetBubbleWidget() const {
}
std::u16string VideoConferenceTray::GetAccessibleNameForTray() {
// TODO(b/253646076): The following is a temporary fix to pass
// https://crrev.com/c/4109611 browsertests and still needs to be replaced
// with the proper name.
return u"Placeholder";
return l10n_util::GetStringUTF16(IDS_ASH_VIDEO_CONFERENCE_ACCESSIBLE_NAME);
}
std::u16string VideoConferenceTray::GetAccessibleNameForBubble() {
// TODO(b/261640628): Replace this placeholder with the appropriate string,
// once it is decided.
return u"Placeholder2";
return GetAccessibleNameForTray();
}
void VideoConferenceTray::HideBubbleWithView(