chromium/src
0
Fork 0
Code Activity

Fix US check in price tracking promo on magic stack

Browse Source 
The force show card parameter was restricted to US users only,
however, at some point variations service started returning "US"
instead of "us" so the show card parameter isn't working properly.
Apply lowercase conversion to the country code from variations
service to fix this.

Bug: 371752295
Change-Id: I47c0d40e4c41d23bc2925d023ae005df725bf75f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5958708
Reviewed-by: Scott Yoder <scottyoder@google.com>
Commit-Queue: David Maunder <davidjm@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1372968}
This commit is contained in:
David Maunder
2024-10-23 21:54:14 +00:00
committed by Chromium LUCI CQ
parent 642314598c
commit 34981def10
1 changed files with 3 additions and 2 deletions

5
ios/chrome/browser/ui/content_suggestions/magic_stack/magic_stack_utils.mm

@ -5,6 +5,7 @@
#import "ios/chrome/browser/ui/content_suggestions/magic_stack/magic_stack_utils.h"
#import "base/metrics/field_trial_params.h"
#import "base/strings/string_util.h"
#import "base/strings/sys_string_conversions.h"
#import "components/commerce/core/commerce_feature_list.h"
#import "components/commerce/core/shopping_service.h"
@ -55,6 +56,6 @@ bool IsPriceTrackingPromoCardEnabled(commerce::ShoppingService* service,
kEphemeralCardRankerForceShowCardParam,
"") == segmentation_platform::features::
kPriceTrackingPromoForceOverride &&
GetCurrentCountryCode(
GetApplicationContext()->GetVariationsService()) == "us"));
base::ToLowerASCII(GetCurrentCountryCode(
GetApplicationContext()->GetVariationsService())) == "us"));
}