chromium/src
0
Fork 0
Code Activity

Clarify PRESUBMIT message for Lacros deprecation

Browse Source 
The Lacros platform is deprecated, and its associated code is being removed. Previously, the PRESUBMIT script was updated to recommend transitioning to the IS_CHROMEOS build flag

However, this change introduced ambiguity, leading to the misinterpretation that IS_CHROMEOS_LACROS should be renamed to IS_CHROMEOS alongside the IS_CHROMEOS_ASH build flag.

This CL refines the PRESUBMIT message to clearly state:
1) Code under IS_CHROMEOS_LACROS must be removed.
2) The IS_CHROMEOS_ASH build flag should be renamed to IS_CHROMEOS.

This update aims to eliminate confusion and provide precise guidance during the
deprecation process.

Bug: 388039763
Change-Id: I0cdd7a788da220ecca17f021a1597d2c41b2c05f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6169131
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405919}
This commit is contained in:
Maksim Sisov
2025-01-13 23:03:12 -08:00
committed by Chromium LUCI CQ
parent f71937225b
commit 34bfc576d6
1 changed files with 2 additions and 1 deletions

3
PRESUBMIT.py

@ -2122,7 +2122,8 @@ _BANNED_CPP_FUNCTIONS: Sequence[BanRule] = (
r'IS_CHROMEOS_LACROS'),
explanation=
('Lacros is deprecated. Please do not use IS_CHROMEOS_ASH and '
'IS_CHROMEOS_LACROS anymore. Prefer IS_CHROMEOS instead.',
'IS_CHROMEOS_LACROS anymore. Instead, remove the code section under '
'IS_CHROMEOS_LACROS and use IS_CHROMEOS for ChromeOS-only code.',
),
treat_as_error=False,
),