chromium/src
0
Fork 0
Code Activity

[Phone Hub] Update strings for opt-in Phone Hub sub features

Browse Source 
This CL updates strings in Phone Hub bubble for opt-in Phone Hub sub
features and their corresponding button accessible name strings.

Set up apps:
Text: https://screenshot.googleplex.com/8Vq6Gpcao9k28KR.png
Setup: https://screenshot.googleplex.com/9Lo8K7h9AAXJJ58.png
Dismiss: https://screenshot.googleplex.com/4Rj4Xd5q2k4LRVG.png

Set up photos:
Text: https://screenshot.googleplex.com/3A3A2sFLpRfja8o.png
Setup: https://screenshot.googleplex.com/7AosP39jCx8Ez8k.png
Dismiss: https://screenshot.googleplex.com/33AdTpZmE5FymnW.png

Set up notifications:
Text: https://screenshot.googleplex.com/7HVqwoc5LcxdqJq.png
Setup: https://screenshot.googleplex.com/AvuTJToJbQ52bk7.png
Dismiss: https://screenshot.googleplex.com/4C3SjSsY8gWkoiU.png

Setup apps and photos:
Text: https://screenshot.googleplex.com/3SgRwYEE2gNiqsr.png
Setup: https://screenshot.googleplex.com/9hhrkVvnQKfmHAS.png
Dismiss: https://screenshot.googleplex.com/4a5tzrxJv2Msc5M.png

Setup apps and notifications:
Text: https://screenshot.googleplex.com/5BKKEEhyTN3u2bx.png
Setup: https://screenshot.googleplex.com/BRQ5fuDgdHuaoZ8.png
Dismiss: https://screenshot.googleplex.com/AsUFdM4bt4j39nv.png

Setup photos and notifications:
Text: https://screenshot.googleplex.com/7YHw6tT3foT8PqP.png
Setup: https://screenshot.googleplex.com/46MPeZvKQkiQMkf.png
Dismiss: https://screenshot.googleplex.com/tXZkgj5zXU6oZi3.png

Setup all:
Text: https://screenshot.googleplex.com/3SVWc2gwJvZKjkq.png
Setup: https://screenshot.googleplex.com/4Q6euuPWZPyp6V7.png
Dismiss: https://screenshot.googleplex.com/4PdiQqyJ9r5kqKY.png

TESTED=deployed to DUT and verifed strings for each state are correct.
Fixed:b/295071077

Change-Id: I496b2acde14e60517f724b2adbdd2cf911d91238
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4813454
Commit-Queue: Pu Shi <pushi@google.com>
Reviewed-by: Crisrael Lucero <crisrael@google.com>
Cr-Commit-Position: refs/heads/main@{#1189127}
This commit is contained in:
Pu Shi
2023-08-28 19:59:08 +00:00
committed by Chromium LUCI CQ
parent dff39d0d0d
commit 35cbf89bed
23 changed files with 52 additions and 54 deletions
ash
ash_strings.grd
ash_strings_grd
IDS_ASH_PHONE_HUB_ALL_FEATURES_OPT_IN_DESCRIPTION.png.sha1IDS_ASH_PHONE_HUB_ALL_FEATURES_OPT_IN_DISMISS_BUTTON_ACCESSIBLE_NAME.png.sha1IDS_ASH_PHONE_HUB_ALL_FEATURES_OPT_IN_SET_UP_BUTTON_ACCESSIBLE_NAME.png.sha1IDS_ASH_PHONE_HUB_APPS_OPT_IN_DESCRIPTION.png.sha1IDS_ASH_PHONE_HUB_APPS_OPT_IN_DISMISS_BUTTON_ACCESSIBLE_NAME.png.sha1IDS_ASH_PHONE_HUB_APPS_OPT_IN_SET_UP_BUTTON_ACCESSIBLE_NAME.png.sha1IDS_ASH_PHONE_HUB_CAMERA_ROLL_AND_APPS_OPT_IN_DESCRIPTION.png.sha1IDS_ASH_PHONE_HUB_CAMERA_ROLL_AND_APPS_OPT_IN_DISMISS_BUTTON_ACCESSIBLE_NAME.png.sha1IDS_ASH_PHONE_HUB_CAMERA_ROLL_AND_APPS_OPT_IN_SET_UP_BUTTON_ACCESSIBLE_NAME.png.sha1IDS_ASH_PHONE_HUB_CAMERA_ROLL_OPT_IN_DESCRIPTION.png.sha1IDS_ASH_PHONE_HUB_CAMERA_ROLL_OPT_IN_DISMISS_BUTTON_ACCESSIBLE_NAME.png.sha1IDS_ASH_PHONE_HUB_CAMERA_ROLL_OPT_IN_SET_UP_BUTTON_ACCESSIBLE_NAME.png.sha1IDS_ASH_PHONE_HUB_NOTIFICATION_AND_APPS_OPT_IN_DESCRIPTION.png.sha1IDS_ASH_PHONE_HUB_NOTIFICATION_AND_APPS_OPT_IN_DISMISS_BUTTON_ACCESSIBLE_NAME.png.sha1IDS_ASH_PHONE_HUB_NOTIFICATION_AND_APPS_OPT_IN_SET_UP_BUTTON_ACCESSIBLE_NAME.png.sha1IDS_ASH_PHONE_HUB_NOTIFICATION_AND_CAMERA_ROLL_OPT_IN_DESCRIPTION.png.sha1IDS_ASH_PHONE_HUB_NOTIFICATION_AND_CAMERA_ROLL_OPT_IN_DISMISS_BUTTON_ACCESSIBLE_NAME.png.sha1IDS_ASH_PHONE_HUB_NOTIFICATION_AND_CAMERA_ROLL_OPT_IN_SET_UP_BUTTON_ACCESSIBLE_NAME.png.sha1IDS_ASH_PHONE_HUB_NOTIFICATION_OPT_IN_DESCRIPTION.png.sha1IDS_ASH_PHONE_HUB_NOTIFICATION_OPT_IN_DISMISS_BUTTON_ACCESSIBLE_NAME.png.sha1IDS_ASH_PHONE_HUB_NOTIFICATION_OPT_IN_SET_UP_BUTTON_ACCESSIBLE_NAME.png.sha1
system
phonehub
sub_feature_opt_in_view.cc

42
ash/ash_strings.grd

@ -1877,49 +1877,49 @@ Style notes:
Set up
</message>
<message name="IDS_ASH_PHONE_HUB_ALL_FEATURES_OPT_IN_DESCRIPTION" desc="Description for the notification and apps opt in view.">
View your phone's recent photos, media, notifications, and apps on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
View your phone's recent photos, media, notifications, and apps
</message>
<message name="IDS_ASH_PHONE_HUB_ALL_FEATURES_OPT_IN_SET_UP_BUTTON_ACCESSIBLE_NAME" desc="Accessible name of the set up button in the notification and apps opt in view">
Set up your phone's recent photos, media, notifications, and apps on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
Set up viewing your phone's recent photos, media, notifications, and apps
</message>
<message name="IDS_ASH_PHONE_HUB_ALL_FEATURES_OPT_IN_DISMISS_BUTTON_ACCESSIBLE_NAME" desc="Accessible name of the dismiss button in the notification and apps opt in view">
Dismiss setting up your phone's recent photos, media, notifications, and apps on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
Dismiss setting up viewing your phone's recent photos, media, notifications, and apps
</message>
<message name="IDS_ASH_PHONE_HUB_NOTIFICATION_AND_APPS_OPT_IN_DESCRIPTION" desc="Description for the notification and apps opt in view.">
View your phone's notifications and apps on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
View your phone's notifications and apps
</message>
<message name="IDS_ASH_PHONE_HUB_NOTIFICATION_AND_APPS_OPT_IN_SET_UP_BUTTON_ACCESSIBLE_NAME" desc="Accessible name of the set up button for the notification and apps opt in view.">
Set up your phone's notifications and apps on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
Set up viewing your phone's notifications and apps
</message>
<message name="IDS_ASH_PHONE_HUB_NOTIFICATION_AND_APPS_OPT_IN_DISMISS_BUTTON_ACCESSIBLE_NAME" desc="Accessible name the dismiss button for the notification and apps opt in view.">
Dismiss setting up your phone's notifications and apps on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
Dismiss setting up viewing your phone's notifications and apps
</message>
<message name="IDS_ASH_PHONE_HUB_NOTIFICATION_OPT_IN_DESCRIPTION" desc="Description for the notification opt in view.">
View your phone's notifications on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
View your phone's notifications
</message>
<message name="IDS_ASH_PHONE_HUB_NOTIFICATION_OPT_IN_SET_UP_BUTTON_ACCESSIBLE_NAME" desc="Accessible name of the set up button for the notification opt in view.">
Set up viewing your phone's notifications on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
Set up viewing your phone's notifications
</message>
<message name="IDS_ASH_PHONE_HUB_NOTIFICATION_OPT_IN_DISMISS_BUTTON_ACCESSIBLE_NAME" desc="Accessible name the dismiss button for the notification opt in view.">
Dismiss setting up viewing your phone's notifications on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
Dismiss setting up viewing your phone's notifications
</message>
<message name="IDS_ASH_PHONE_HUB_NOTIFICATION_AND_CAMERA_ROLL_OPT_IN_DESCRIPTION" desc="Description for the notification opt in view.">
View your phone's recent photos, media, and notifications on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
View your phone's recent photos, media, and notifications
</message>
<message name="IDS_ASH_PHONE_HUB_NOTIFICATION_AND_CAMERA_ROLL_OPT_IN_SET_UP_BUTTON_ACCESSIBLE_NAME" desc="Accessible name of the set up button for the notification opt in view.">
Set up viewing your phone's recent photos, media, and notifications on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
Set up viewing your phone's recent photos, media, and notifications
</message>
<message name="IDS_ASH_PHONE_HUB_NOTIFICATION_AND_CAMERA_ROLL_OPT_IN_DISMISS_BUTTON_ACCESSIBLE_NAME" desc="Accessible name of the dismiss button for the notification opt in view.">
Dismiss setting up viewing your phone's recent photos, media, and notifications on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
Dismiss setting up viewing your phone's recent photos, media, and notifications
</message>
<message name="IDS_ASH_PHONE_HUB_CAMERA_ROLL_AND_APPS_OPT_IN_DESCRIPTION" desc="Description for the notification opt in view.">
View your phone's recent photos, media, and apps on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
View your phone's recent photos, media, and apps
</message>
<message name="IDS_ASH_PHONE_HUB_CAMERA_ROLL_AND_APPS_OPT_IN_SET_UP_BUTTON_ACCESSIBLE_NAME" desc="Accessible name of the set up button for the notification opt in view.">
View your phone's recent photos, media, and apps on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
Set up viewing your phone's recent photos, media, and apps
</message>
<message name="IDS_ASH_PHONE_HUB_CAMERA_ROLL_AND_APPS_OPT_IN_DISMISS_BUTTON_ACCESSIBLE_NAME" desc="Accessible name of the dismiss button for the notification opt in view.">
View your phone's recent photos, media, and apps on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
Dismiss setting up viewing your phone's recent photos, media, and apps
</message>
<message name="IDS_ASH_PHONE_HUB_APP_STREAM_LAUNCHER_TITLE" desc="Title for the launcher that displays apps from your phone.">
Apps from your phone
@ -1931,22 +1931,22 @@ Style notes:
Not supported by app
</message>
<message name="IDS_ASH_PHONE_HUB_APPS_OPT_IN_DESCRIPTION" desc="Description for the apps opt in view.">
View your phone's apps on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
View your phone's apps
</message>
<message name="IDS_ASH_PHONE_HUB_APPS_OPT_IN_SET_UP_BUTTON_ACCESSIBLE_NAME" desc="Accessible name the set up button for the apps opt in view.">
Set up viewing your phone's apps on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
Set up viewing your phone's apps
</message>
<message name="IDS_ASH_PHONE_HUB_APPS_OPT_IN_DISMISS_BUTTON_ACCESSIBLE_NAME" desc="Accessible name of the dismiss button for the apps opt in view.">
Dismiss setting up viewing your phone's apps on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
Dismiss setting up viewing your phone's apps
</message>
<message name="IDS_ASH_PHONE_HUB_CAMERA_ROLL_OPT_IN_DESCRIPTION" desc="Description for the camera roll opt in view.">
View your phone's recent photos and media on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
View your phone's recent photos and media
</message>
<message name="IDS_ASH_PHONE_HUB_CAMERA_ROLL_OPT_IN_SET_UP_BUTTON_ACCESSIBLE_NAME" desc="Description for the camera roll opt in view.">
Set up viewing your phone's recent photos and media on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
Set up viewing your phone's recent photos and media
</message>
<message name="IDS_ASH_PHONE_HUB_CAMERA_ROLL_OPT_IN_DISMISS_BUTTON_ACCESSIBLE_NAME" desc="Description for the camera roll opt in view.">
Dismiss setting up viewing your phone's recent photos and media on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
Dismiss setting up viewing your phone's recent photos and media
</message>
<message name="IDS_ASH_PHONE_HUB_NOTIFICATION_HOTSPOT_FAILED_TITLE" desc="Title inside a PhoneHub notification when enable hotspot failed to find a connection.">
Hotspot connection failed

2
ash/ash_strings_grd/IDS_ASH_PHONE_HUB_ALL_FEATURES_OPT_IN_DESCRIPTION.png.sha1

@ -1 +1 @@
3faea8751f732bae64cc2e8e1bec810beb09e10d
13eccac6d694ff17719291ce919f7c1476070969

2
ash/ash_strings_grd/IDS_ASH_PHONE_HUB_ALL_FEATURES_OPT_IN_DISMISS_BUTTON_ACCESSIBLE_NAME.png.sha1

@ -1 +1 @@
637c9d5e8faabb2ee10dcbade40a91f7fe8f16b6
0306de14f638ee88a47caf29241c0970b2de2473

2
ash/ash_strings_grd/IDS_ASH_PHONE_HUB_ALL_FEATURES_OPT_IN_SET_UP_BUTTON_ACCESSIBLE_NAME.png.sha1

@ -1 +1 @@
0871aadf66f904166e58f3ce1fe7b732643ee69b
b9e07401ffc81e6420f5eb51d7330748f48f4efa

2
ash/ash_strings_grd/IDS_ASH_PHONE_HUB_APPS_OPT_IN_DESCRIPTION.png.sha1

@ -1 +1 @@
6246a0463b5d98a513c3ca85987e433ca02d6c99
fb8f976df38edf7f60d6613ae568db83f48ab790

2
ash/ash_strings_grd/IDS_ASH_PHONE_HUB_APPS_OPT_IN_DISMISS_BUTTON_ACCESSIBLE_NAME.png.sha1

@ -1 +1 @@
3380469d933c22a2485c3b261ef7bab59bbd729e
5b2061b9f571a7ef6c6d5535e33ec8a9ef9e8df7

2
ash/ash_strings_grd/IDS_ASH_PHONE_HUB_APPS_OPT_IN_SET_UP_BUTTON_ACCESSIBLE_NAME.png.sha1

@ -1 +1 @@
04f08daf35fb8299da0c20dc07a1f419bb9579a0
d4a20fe4efc6342203d20b87aa35be674a0afb93

2
ash/ash_strings_grd/IDS_ASH_PHONE_HUB_CAMERA_ROLL_AND_APPS_OPT_IN_DESCRIPTION.png.sha1

@ -1 +1 @@
abf16f6771695877e2cddc1a6cd1aff5328d7603
41b59c14f1eee6066b0eaaef332a6275a05f5d75

2
ash/ash_strings_grd/IDS_ASH_PHONE_HUB_CAMERA_ROLL_AND_APPS_OPT_IN_DISMISS_BUTTON_ACCESSIBLE_NAME.png.sha1

@ -1 +1 @@
d1b0d24e88798b8ff7374ecb5ed56896aef5f30c
0b4d598fa6c2935854ff0252441414f4ab86a0f4

2
ash/ash_strings_grd/IDS_ASH_PHONE_HUB_CAMERA_ROLL_AND_APPS_OPT_IN_SET_UP_BUTTON_ACCESSIBLE_NAME.png.sha1

@ -1 +1 @@
9b69fd444928e148a092682ef4aa6c75bd819623
409b4c9db60c2a63642392b28647810bd452194f

2
ash/ash_strings_grd/IDS_ASH_PHONE_HUB_CAMERA_ROLL_OPT_IN_DESCRIPTION.png.sha1

@ -1 +1 @@
d2cf56861308a9dec1530f8b157d9bd43c52047c
c24c358908ef92911ee124578219b3d5e0c1249a

2
ash/ash_strings_grd/IDS_ASH_PHONE_HUB_CAMERA_ROLL_OPT_IN_DISMISS_BUTTON_ACCESSIBLE_NAME.png.sha1

@ -1 +1 @@
3c690c84f7134178fa9f28d312b198b7baa96397
ed24023d71865e876e3c4d0df4200a248c4f71d5

2
ash/ash_strings_grd/IDS_ASH_PHONE_HUB_CAMERA_ROLL_OPT_IN_SET_UP_BUTTON_ACCESSIBLE_NAME.png.sha1

@ -1 +1 @@
9aa26cc9ccbf502850cc50d03e22c6840c5ba517
3e1caeecf0f89c23d258cfb66fc653cb644fe202

2
ash/ash_strings_grd/IDS_ASH_PHONE_HUB_NOTIFICATION_AND_APPS_OPT_IN_DESCRIPTION.png.sha1

@ -1 +1 @@
a040b64cd786c8fffcaf955b303575469fbd2163
b2591b8dc104a220f048bfec1ef3df31c3a52667

2
ash/ash_strings_grd/IDS_ASH_PHONE_HUB_NOTIFICATION_AND_APPS_OPT_IN_DISMISS_BUTTON_ACCESSIBLE_NAME.png.sha1

@ -1 +1 @@
5b063f2c43665283cf7f8ad80942f62d85814c45
988242abef2c96dff00c4926e0d2cfc9d247f6d2

2
ash/ash_strings_grd/IDS_ASH_PHONE_HUB_NOTIFICATION_AND_APPS_OPT_IN_SET_UP_BUTTON_ACCESSIBLE_NAME.png.sha1

@ -1 +1 @@
17b3985d763f8b3234791ee0609e681eb9427ceb
a642ea8007a6e2b1345fed26a66f99ef878a02e4

2
ash/ash_strings_grd/IDS_ASH_PHONE_HUB_NOTIFICATION_AND_CAMERA_ROLL_OPT_IN_DESCRIPTION.png.sha1

@ -1 +1 @@
3e5b27117fa1e3e5163a80aec9b0607f64248d21
a451369bec9fca22f4c15b4757c2e6cc75cecc95

2
ash/ash_strings_grd/IDS_ASH_PHONE_HUB_NOTIFICATION_AND_CAMERA_ROLL_OPT_IN_DISMISS_BUTTON_ACCESSIBLE_NAME.png.sha1

@ -1 +1 @@
3fd4cea2b52b4e2f9417ff94a41e760972c782c5
9788fab5b010fbe6977012a8dc257669fb103dc0

2
ash/ash_strings_grd/IDS_ASH_PHONE_HUB_NOTIFICATION_AND_CAMERA_ROLL_OPT_IN_SET_UP_BUTTON_ACCESSIBLE_NAME.png.sha1

@ -1 +1 @@
f6c1764ebf9f4aa1943ebd9def1f96a93f1779a0
11991bc0535af74f110a39c82537ed827f2e44c7

2
ash/ash_strings_grd/IDS_ASH_PHONE_HUB_NOTIFICATION_OPT_IN_DESCRIPTION.png.sha1

@ -1 +1 @@
f941ed1a2209506b30d64728a9fc27d709822569
6800192e59820dbef1d3ffe26f3fbf9f34b3a446

2
ash/ash_strings_grd/IDS_ASH_PHONE_HUB_NOTIFICATION_OPT_IN_DISMISS_BUTTON_ACCESSIBLE_NAME.png.sha1

@ -1 +1 @@
7490aa557c2e43c734ba71e5cf31e929a6843f48
545ecb208a5b8520067dc101ab5045354609cf37

2
ash/ash_strings_grd/IDS_ASH_PHONE_HUB_NOTIFICATION_OPT_IN_SET_UP_BUTTON_ACCESSIBLE_NAME.png.sha1

@ -1 +1 @@
422762006cfeeb3b070db5ab094736d91b49456b
ad9e4b46e5a036abbd5db38a326c85f99f08cbca

22
ash/system/phonehub/sub_feature_opt_in_view.cc

@ -141,12 +141,11 @@ void SubFeatureOptInView::SetStringIds() {
}
void SubFeatureOptInView::UpdateLabels() {
text_label_->SetText(l10n_util::GetStringFUTF16(description_string_id_,
ui::GetChromeOSDeviceName()));
set_up_button_->SetAccessibleName(l10n_util::GetStringFUTF16(
set_up_button_accessible_name_string_id_, ui::GetChromeOSDeviceName()));
dismiss_button_->SetAccessibleName(l10n_util::GetStringFUTF16(
dismiss_button_accessible_name_string_id_, ui::GetChromeOSDeviceName()));
text_label_->SetText(l10n_util::GetStringUTF16(description_string_id_));
set_up_button_->SetAccessibleName(
l10n_util::GetStringUTF16(set_up_button_accessible_name_string_id_));
dismiss_button_->SetAccessibleName(
l10n_util::GetStringUTF16(dismiss_button_accessible_name_string_id_));
}
void SubFeatureOptInView::InitLayout() {
@ -181,8 +180,7 @@ void SubFeatureOptInView::InitLayout() {
.DeriveWithWeight(gfx::Font::Weight::MEDIUM));
text_label_->SetMultiLine(/*multi_line=*/true);
text_label_->SetHorizontalAlignment(gfx::HorizontalAlignment::ALIGN_LEFT);
text_label_->SetText(l10n_util::GetStringFUTF16(description_string_id_,
ui::GetChromeOSDeviceName()));
text_label_->SetText(l10n_util::GetStringUTF16(description_string_id_));
if (chromeos::features::IsJellyrollEnabled()) {
TypographyProvider::Get()->StyleLabel(ash::TypographyToken::kCrosHeadline1,
@ -205,8 +203,8 @@ void SubFeatureOptInView::InitLayout() {
IDS_ASH_PHONE_HUB_SUB_FEATURE_OPT_IN_DISMISS_BUTTON),
PillButton::Type::kFloatingWithoutIcon, /*icon=*/nullptr));
dismiss_button_->SetID(kSubFeatureOptInDismissButton);
dismiss_button_->SetAccessibleName(l10n_util::GetStringFUTF16(
dismiss_button_accessible_name_string_id_, ui::GetChromeOSDeviceName()));
dismiss_button_->SetAccessibleName(
l10n_util::GetStringUTF16(dismiss_button_accessible_name_string_id_));
set_up_button_ = button_container->AddChildView(std::make_unique<PillButton>(
base::BindRepeating(&SubFeatureOptInView::SetUpButtonPressed,
base::Unretained(this)),
@ -214,8 +212,8 @@ void SubFeatureOptInView::InitLayout() {
IDS_ASH_PHONE_HUB_NOTIFICATION_OPT_IN_SET_UP_BUTTON),
PillButton::Type::kDefaultWithoutIcon, /*icon=*/nullptr));
set_up_button_->SetID(kSubFeatureOptInConfirmButton);
set_up_button_->SetAccessibleName(l10n_util::GetStringFUTF16(
set_up_button_accessible_name_string_id_, ui::GetChromeOSDeviceName()));
set_up_button_->SetAccessibleName(
l10n_util::GetStringUTF16(set_up_button_accessible_name_string_id_));
// By default, the description will be set to the tooltip text, but the title
// is already announced in the accessible name.