chromium/src
0
Fork 0
Code Activity

ide_query: don't use fast-deps to build

Browse Source 
fast-deps is fast when deps log exists,
but it would miss exec cache due to difference
of action inputs between fast-deps vs scandeps.

Use no-fast-deps (i.e. scandeps) to expect
high cache hit rate.

Bug: b/320566517, b/336733101, b/283341125
Change-Id: Ie35019622354d190d5a413884578ca2eb8700ac9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5508410
Commit-Queue: Philipp Wollermann <philwo@chromium.org>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Philipp Wollermann <philwo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1295334}
This commit is contained in:
Fumitoshi Ukai
2024-05-02 09:18:32 +00:00
committed by Chromium LUCI CQ
parent 1b8d7e0817
commit 35d16de676
1 changed files with 3 additions and 1 deletions

4
build/util/ide_query

@ -89,7 +89,9 @@ def main():
options.out_dir,
])
args.extend(targets)
p = subprocess.run(args, cwd=repo_root, stdout=2, stderr=2)
env = os.environ.copy()
env['SISO_EXPERIMENTS'] = 'no-fast-deps'
p = subprocess.run(args, cwd=repo_root, stdout=2, stderr=2, env=env)
if p.returncode != 0:
# TODO: report error in IdeAnalysis.Status?
sys.stderr.write('build failed with %d\n' % p.returncode)