0

PDF Viewer updates: Add feature flag

Bug: 1048812
Change-Id: I1afeb8a40e320b05a3dcc56d89584b3e65eac968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209600
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770757}
This commit is contained in:
rbpotter
2020-05-20 20:58:13 +00:00
committed by Commit Bot
parent fb66d2619c
commit 35f29f1aa8
8 changed files with 25 additions and 0 deletions

@ -3826,6 +3826,10 @@ const FeatureEntry kFeatureEntries[] = {
{"pdf-two-up-view", flag_descriptions::kPdfTwoUpViewName,
flag_descriptions::kPdfTwoUpViewDescription, kOsDesktop,
FEATURE_VALUE_TYPE(chrome_pdf::features::kPDFTwoUpView)},
{"pdf-viewer-update", flag_descriptions::kPdfViewerUpdateName,
flag_descriptions::kPdfViewerUpdateDescription, kOsDesktop,
FEATURE_VALUE_TYPE(chrome_pdf::features::kPDFViewerUpdate)},
#endif // BUILDFLAG(ENABLE_PDF)
#if BUILDFLAG(ENABLE_PRINTING)

@ -135,6 +135,9 @@ void AddAdditionalDataForPdf(base::DictionaryValue* dict) {
dict->SetKey("pdfTwoUpViewEnabled",
base::Value(base::FeatureList::IsEnabled(
chrome_pdf::features::kPDFTwoUpView)));
dict->SetKey("pdfViewerUpdateEnabled",
base::Value(base::FeatureList::IsEnabled(
chrome_pdf::features::kPDFViewerUpdate)));
bool enable_printing = true;
#if defined(OS_CHROMEOS)

@ -3522,6 +3522,11 @@
"owners": ["nigi", "thestig"],
"expiry_milestone": 86
},
{
"name": "pdf-viewer-update",
"owners": ["rbpotter", "thestig"],
"expiry_milestone": 89
},
{
"name": "per-method-can-make-payment-quota",
"owners": [ "rouslan" ],

@ -4075,6 +4075,10 @@ const char kPdfTwoUpViewName[] = "PDF Two-up View";
const char kPdfTwoUpViewDescription[] =
"Enable a new option to display two pages side by side in the PDF viewer.";
const char kPdfViewerUpdateName[] = "PDF Viewer Update";
const char kPdfViewerUpdateDescription[] =
"When enabled, the PDF viewer will display an updated UI with new "
"options and features.";
#endif // BUILDFLAG(ENABLE_PLUGINS)
#if BUILDFLAG(ENABLE_WEBUI_TAB_STRIP)

@ -2412,6 +2412,9 @@ extern const char kPdfFormSaveDescription[];
extern const char kPdfTwoUpViewName[];
extern const char kPdfTwoUpViewDescription[];
extern const char kPdfViewerUpdateName[];
extern const char kPdfViewerUpdateDescription[];
#endif // BUILDFLAG(ENABLE_PLUGINS)
#if BUILDFLAG(ENABLE_WEBUI_TAB_STRIP)

@ -24,6 +24,9 @@ const base::Feature kPDFAnnotations = {"PDFAnnotations",
const base::Feature kPDFTwoUpView = {"PDFTwoUpView",
base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kPDFViewerUpdate = {"PDFViewerUpdate",
base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kSaveEditedPDFForm = {"SaveEditedPDFForm",
#if defined(OS_CHROMEOS)
base::FEATURE_ENABLED_BY_DEFAULT

@ -17,6 +17,7 @@ extern const base::Feature kAccessiblePDFForm;
extern const base::Feature kAccessiblePDFHighlight;
extern const base::Feature kPDFAnnotations;
extern const base::Feature kPDFTwoUpView;
extern const base::Feature kPDFViewerUpdate;
extern const base::Feature kSaveEditedPDFForm;
extern const base::Feature kTabAcrossPDFAnnotations;

@ -40957,6 +40957,7 @@ from previous Chrome versions.
<int value="860336036" label="ChromeModernDesign:enabled"/>
<int value="862453793" label="TranslateUI2016Q2:enabled"/>
<int value="864024033" label="IsolatePrerendersMustProbeOrigin:enabled"/>
<int value="866536801" label="PDFViewerUpdate:disabled"/>
<int value="867512869" label="mark-non-secure-as"/>
<int value="868009556" label="AutofillUpstream:enabled"/>
<int value="869531646" label="enable-session-crashed-bubble"/>
@ -41632,6 +41633,7 @@ from previous Chrome versions.
<int value="1630159957" label="SharingSendViaSync:disabled"/>
<int value="1630988998" label="VrBrowsingExperimentalRendering:disabled"/>
<int value="1632112977" label="ash-disable-tablet-autohide-titlebars"/>
<int value="1632176267" label="PDFViewerUpdate:enabled"/>
<int value="1633456034" label="chrome-home-swipe-logic"/>
<int value="1634732103" label="PassiveDocumentWheelEventListeners:enabled"/>
<int value="1634884226"