chromium/src
0
Fork 0
Code Activity

Disable flaky HeadlessRenderBrowserTestCookieSetFromJs_NoCookies.RunAsyncTest

Browse Source 
A series of HeadlessRenderBrowserTests have been failing. A suspected fix to
some of them has landed.

However HeadlessRenderBrowserTestCookieSetFromJs_NoCookies.RunAsyncTest still
fails. This disables it on Linux until the team can provide a fix.

TEST=HeadlessRenderBrowserTestCookieSetFromJs_NoCookies.RunAsyncTest
TBR=eseckler@chromium.org

Bug: 839747
Change-Id: I526358528bd6b1922afc930db213be183426ae07
Reviewed-on: https://chromium-review.googlesource.com/1044303
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556072}
This commit is contained in:
jonross
2018-05-04 16:00:56 +00:00
committed by Commit Bot
parent 69feef3158
commit 37711150a5
1 changed files with 13 additions and 1 deletions

14
headless/test/headless_render_browsertest.cc

@ -7,6 +7,7 @@
#include "base/path_service.h"
#include "base/run_loop.h"
#include "base/threading/thread_restrictions.h"
#include "build/build_config.h"
#include "content/public/test/browser_test.h"
#include "headless/public/devtools/domains/dom_snapshot.h"
#include "headless/public/devtools/domains/page.h"
@ -21,6 +22,10 @@
class HeadlessRenderBrowserTest##clazz : public clazz {}; \
HEADLESS_ASYNC_DEVTOOLED_TEST_F(HeadlessRenderBrowserTest##clazz)
#define DISABLED_HEADLESS_RENDER_BROWSERTEST(clazz) \
class HeadlessRenderBrowserTest##clazz : public clazz {}; \
DISABLED_HEADLESS_ASYNC_DEVTOOLED_TEST_F(HeadlessRenderBrowserTest##clazz)
// TODO(dats): For some reason we are missing all HTTP redirects.
// crbug.com/789298
#define DISABLE_HTTP_REDIRECTS_CHECKS
@ -1157,7 +1162,14 @@ class CookieSetFromJs_NoCookies : public CookieSetFromJs {
"http://www.example.com/epicfail"));
}
};
HEADLESS_RENDER_BROWSERTEST(CookieSetFromJs_NoCookies);
// Flaky on Linux. https://crbug.com/839747
#if defined(OS_LINUX)
#define MAYBE_HEADLESS_RENDER_BROWSERTEST DISABLED_HEADLESS_RENDER_BROWSERTEST
#else
#define MAYBE_HEADLESS_RENDER_BROWSERTEST HEADLESS_RENDER_BROWSERTEST
#endif
MAYBE_HEADLESS_RENDER_BROWSERTEST(CookieSetFromJs_NoCookies);
class CookieUpdatedFromJs : public HeadlessRenderTest {
private: