chromium/src
0
Fork 0
Code Activity

Update remoting ICE config request annotation

Browse Source 
With the launch of RemoteAccessHostAllowRemoteSupportConnections and
RemoteAccessHostAllowEnterpriseRemoteSupportConnections policies, update
the traffic annotations in the ICE config request to reflect these. Also
update the new fields with contacts, user data, and last reviewed date.

Bug: b/290403382
Change-Id: I72c35753e68ceba6db836d90bf9c51468b4e1555
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4674956
Commit-Queue: Chris Mullins <crmullins@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Side YILMAZ <sideyilmaz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1176764}
This commit is contained in:
Chris Mullins
2023-07-28 19:42:59 +00:00
committed by Chromium LUCI CQ
parent 1fe2b2ca83
commit 38263ec6f7
3 changed files with 17 additions and 5 deletions
remoting/protocol
remoting_ice_config_request.cc
tools/traffic_annotation
safe_list.txt
summary
annotations.xml

19
remoting/protocol/remoting_ice_config_request.cc

@ -38,17 +38,30 @@ constexpr net::NetworkTrafficAnnotationTag kTrafficAnnotation =
"When a Chrome Remote Desktop session is being connected and "
"periodically (less frequent than once per hour) while a session "
"is active, if the configuration is expired."
user_data {
type: ACCESS_TOKEN
}
data:
"None (anonymous request)."
"OAuth token for the following use cases:"
" 1) Human user (for consumer It2Me) "
" 2) ChromeOS Enterprise robot (for commercial It2Me) "
" 3) Chromoting robot (for remote access, aka Me2Me) "
destination: GOOGLE_OWNED_SERVICE
internal {
contacts { owners: "//remoting/OWNERS" }
}
last_reviewed: "2023-07-28"
}
policy {
cookies_allowed: NO
setting:
"This request cannot be stopped in settings, but will not be sent "
"if the user does not use Chrome Remote Desktop."
policy_exception_justification:
"Not implemented."
chrome_policy {
RemoteAccessHostFirewallTraversal {
RemoteAccessHostFirewallTraversal: false
}
}
})");
constexpr char kGetIceConfigPath[] = "/v1/networktraversal:geticeconfig";

1
tools/traffic_annotation/safe_list.txt

@ -319,7 +319,6 @@ missing_new_fields,remoting/base/telemetry_log_writer.cc
missing_new_fields,remoting/client/notification/notification_client.cc
missing_new_fields,remoting/host/heartbeat_sender.cc
missing_new_fields,remoting/host/security_key/security_key_socket.cc
missing_new_fields,remoting/protocol/remoting_ice_config_request.cc
missing_new_fields,remoting/protocol/ssl_hmac_channel_authenticator.cc
missing_new_fields,remoting/protocol/stream_message_pipe_adapter.cc
missing_new_fields,remoting/protocol/stream_packet_socket.cc

2
tools/traffic_annotation/summary/annotations.xml

@ -186,7 +186,7 @@ Refer to README.md for content description and update process.
<item id="remoting_directory_delete_host" added_in_milestone="86" content_hash_code="03ed762b" os_list="linux,windows,chromeos,android" file_path="remoting/base/directory_service_client.cc" />
<item id="remoting_directory_get_host_list" added_in_milestone="86" content_hash_code="03933aa0" os_list="linux,windows,chromeos,android" file_path="remoting/base/directory_service_client.cc" />
<item id="remoting_directory_register_host" added_in_milestone="86" content_hash_code="046c936d" os_list="linux,windows,chromeos,android" file_path="remoting/base/directory_service_client.cc" />
<item id="remoting_ice_config_request" added_in_milestone="86" content_hash_code="05a5a715" os_list="linux,windows,chromeos,android" file_path="remoting/protocol/remoting_ice_config_request.cc" />
<item id="remoting_ice_config_request" added_in_milestone="86" content_hash_code="001d0a98" os_list="linux,windows,chromeos,android" file_path="remoting/protocol/remoting_ice_config_request.cc" />
<item id="remoting_log_to_server" added_in_milestone="86" content_hash_code="04dfdf0a" os_list="linux,windows,chromeos,android" file_path="remoting/signaling/remoting_log_to_server.cc" />
<item id="remoting_register_support_host_request" added_in_milestone="86" content_hash_code="04fd7da8" os_list="linux,windows,chromeos" file_path="remoting/host/remoting_register_support_host_request.cc" />
<item id="remoting_telemetry_log_writer" added_in_milestone="86" content_hash_code="04df471b" os_list="linux,windows,chromeos,android" file_path="remoting/base/telemetry_log_writer.cc" />