chromium/src
0
Fork 0
Code Activity

Lacros: Add more info about macro and gn usage.

Browse Source 
Bug: None
Change-Id: Iac42558aef5f1d74c884acc9d95cfde979285b3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513811
Commit-Queue: Yuta Hijikata <ythjkt@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823229}
This commit is contained in:
Yuta Hijikata
2020-11-02 18:48:19 +00:00
committed by Commit Bot
parent 2bd023a8b3
commit 3b18a40f43
1 changed files with 9 additions and 6 deletions

15
docs/lacros.md

@ -70,14 +70,17 @@ Lacros bugs can be filed under component: OS>LaCrOs.
### Current state
OS_CHROMEOS is defined and is_chromeos is set only for ash-chrome at the moment.
We are migrating defined(OS_CHROMEOS) to BUILDFLAG(IS_CHROMEOS_ASH), see
[crbug.com/1052397](https://crbug.com/1052397). After the migration, the macros
and gn variables should be used according to the above desired state.
We are currently migrating defined(OS_CHROMEOS) to BUILDFLAG(IS_CHROMEOS_ASH),
see [crbug.com/1052397](https://crbug.com/1052397). Until the migration is
complete, for parts used by both ash-chrome and lacros-chrome, use
`BUILDFLAG(IS_CHROMEOS_ASH) || BUILDFLAG(IS_CHROMEOS_LACROS)` in C++ files and
`is_chromeos_ash || is_chromeos_lacros` in GN files. After the migration, the
macros and GN variables should be used according to the above desired state.
Googlers:
- [go/lacros-porting](http://go/lacros-porting) has some tips for build files.
- [go/lacros-macros](http://go/lacros-macros) describes the steps for the macros migration.
- [go/lacros-build-config](http://go/lacros-build-config) is the design doc.
- [go/lacros-porting](http://go/lacros-porting) has tips on which binary the code should live in.
- [go/lacros-macros](http://go/lacros-macros) describes the steps for the migration.
- [go/lacros-build-config](http://go/lacros-build-config) is the original design doc.
## Testing