chromium/src
0
Fork 0
Code Activity

[ios blink] Add additional debugging to linker_driver.py

Browse Source 
The error message returned wasn't too helpful in what argument
was causing the issue. Provide additional context to the assert.

Bug: 40254930
Change-Id: Ib524f0c6303932c9ac7a6a3cc1cde6ef65633b7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6278788
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1421460}
This commit is contained in:
Dave Tapuska
2025-02-18 09:57:17 -08:00
committed by Chromium LUCI CQ
parent 7aa1d5d1f1
commit 3c57413abe
1 changed files with 4 additions and 2 deletions

6
build/toolchain/apple/linker_driver.py

@ -245,7 +245,8 @@ class LinkerDriver(object):
for driver_action in self._pre_actions:
(pre_name, pre_action) = driver_action
if sub_arg.startswith(pre_name):
assert pre_name not in self._linker_driver_pre_actions
assert pre_name not in self._linker_driver_pre_actions, \
f"Name '{pre_name}' found in linker driver pre actions"
self._linker_driver_pre_actions[pre_name] = \
lambda: pre_action(sub_arg[len(pre_name):])
# same sub_arg may be used in actions.
@ -255,7 +256,8 @@ class LinkerDriver(object):
for driver_action in self._actions:
(name, action) = driver_action
if sub_arg.startswith(name):
assert name not in self._linker_driver_actions
assert name not in self._linker_driver_actions, \
f"Name '{name}' found in linker driver actions"
self._linker_driver_actions[name] = \
lambda: action(sub_arg[len(name):])
return