Replace python by python3
On Mac OS by default today, `python` is an undefined command. While I expect most devs to have enough basic knowledge about Python to know how to correct this error, being clear always help. Also, it means that `tools/translation/upload_screenshots.py` do not work, since `/usr/bin/env python` fails. Change-Id: I2b8c23cf3720a04462b36b155215ca1a545a3b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3839082 Commit-Queue: Arthur Milchior <arthurmilchior@google.com> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/main@{#1037107}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
9c4896842d
commit
3d1cc8db74
@ -6,7 +6,7 @@ We’d all like to ensure that the user experience in Chrome is optimal, no matt
|
||||
|
||||
1. Take a screenshot of the UI that displays the modified string (e.g. `IDS_NEW_STRING` in `path/to/file.grd`)
|
||||
2. Save it under the screenshot directory for the file you are editing: `path/to/file_grd/IDS_NEW_STRING.png`. If `path/to/file_grd` doesn’t exist, create it. Only .png files are supported.
|
||||
3. Run `python tools/translation/upload_screenshots.py` (without flags) to upload the screenshot to Google Cloud Storage.
|
||||
3. Run `python3 tools/translation/upload_screenshots.py` (without flags) to upload the screenshot to Google Cloud Storage. (You may need to use `python` instead of `python3` depending on your system)
|
||||
4. This will generate `path/to/file_grd/IDS_NEW_STRING.png.sha1`. Add this file to your CL and you are done. Don’t add the actual image to your CL.
|
||||
|
||||
Unfortunately, only contributors with @google.com accounts can upload images to the Cloud Storage bucket (Step 3). If you can’t upload images, please ask a Googler for help, then continue with Step 4.
|
||||
|
Reference in New Issue
Block a user