chromium/src
0
Fork 0
Code Activity

Update commit instructions with new requirements

Browse Source 
All comments must be resolved before a CL can be committed or
a footer needs to be added to bypass the check.

Two committers are required to review a CL unless the author
is also a committer.

Bug: 41327783
Change-Id: Ifdeffb5263802ded715b445321d1dd6ff9d36cdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5332643
Reviewed-by: Garrett Beaty <gbeaty@google.com>
Commit-Queue: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1275640}
This commit is contained in:
Erik Staab
2024-03-20 16:33:57 +00:00
committed by Chromium LUCI CQ
parent 3645fc2114
commit 3d5a4b99a8
2 changed files with 19 additions and 8 deletions

20
docs/commit_checklist.md

@ -266,14 +266,18 @@ this flag also puts the onus on your reviewer to land the CL.
## 19. Land your CL
Once you have obtained a Looks Good To Me (LGTM), which is reflected by a
Code-Review+1 in Gerrit, from at least one owner for each file, then you have
the minimum prerequisite to land your changes. As mentioned above, you are
generally expected to wait for all of your reviewers to approve your changes as
well, even if you already have OWNERS approval. Don't use `chrome/OWNERS` as a
blanket stamp if your CL makes significant changes to subsystems. Click
`Submit to CQ` (Commit-Queue +2) to both try your change in the commit queue
(CQ) and automatically land it if successful.
To meet the minimum requirements to land your changes you must have:
* Obtained a Looks Good To Me (LGTM), which is reflected by a
Code-Review+1 in Gerrit
* from at least one owner for each file, excluding files you are an owner of
* from two committers, or one committer if you are also a committer
* Resolved all code review comments
As mentioned above, you are generally expected to wait for all of your reviewers
to approve your changes as well, even if you already have OWNERS approval. Don't
use `chrome/OWNERS` as a blanket stamp if your CL makes significant changes to
subsystems. Click `Submit to CQ` (Commit-Queue +2) to both try your change in
the commit queue (CQ) and automatically land it if successful.
Alternatively you can run `git cl set-commit`.

7
docs/contributing.md

@ -305,6 +305,13 @@ When the reviewer is happy with the change, they will set the "Code-Review +1"
label. Owners of all affected files must approve before a change can be
committed. See: [code review policies: owners][code-reviews-owners].
All code review comments must be marked resolved before a CL can be committed.
In some cases a reviewer may give "Code-Review +1" with some additional
comments. These should be addressed and responded to, or at least acknowledged
with the ACK button to resolve them. If you cannot resolve all comments an
override is provided through an "Unresolved-Comment-Reason:" stanza in your
commit message.
## Running automated tests
Before being submitted, a change must pass the commit queue (CQ). The commit