chromium/src
0
Fork 0
Code Activity

Remove BUG= and TEST= checks from upload commit presubmit check.

Browse Source 
Fix PRESUBMIT.py to exclude Makefile.

BUG=none
TEST=presubmit check is less noisy

Review URL: http://codereview.chromium.org/5976009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71622 0039d316-1c4b-4281-b951-d872f2087c98
This commit is contained in:
maruel@chromium.org
2011-01-18 03:29:54 +00:00
parent d6ba5a0be4
commit 3e4eb113ee
1 changed files with 9 additions and 8 deletions

17
PRESUBMIT.py

@ -9,10 +9,11 @@ for more details about the presubmit API built into gcl.
"""
_EXCLUDED_PATHS = (
r"breakpad[\\\/].*",
r"net/tools/spdyshark/[\\\/].*",
r"skia[\\\/].*",
r"v8[\\\/].*",
r"^breakpad[\\\/].*",
r"^net/tools/spdyshark/[\\\/].*",
r"^skia[\\\/].*",
r"^v8[\\\/].*",
r".*MakeFile$",
)
_TEXT_FILES = (
@ -106,10 +107,6 @@ def _CommonChecks(input_api, output_api):
input_api, output_api, source_file_filter=sources))
results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace(
input_api, output_api, source_file_filter=sources))
results.extend(input_api.canned_checks.CheckChangeHasBugField(
input_api, output_api))
results.extend(input_api.canned_checks.CheckChangeHasTestField(
input_api, output_api))
results.extend(input_api.canned_checks.CheckChangeSvnEolStyle(
input_api, output_api, source_file_filter=text_files))
results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes(
@ -171,6 +168,10 @@ def CheckChangeOnCommit(input_api, output_api):
'http://build.chromium.org/p/chromium/json/builders?filter=1',
6,
IGNORED_BUILDERS))
results.extend(input_api.canned_checks.CheckChangeHasBugField(
input_api, output_api))
results.extend(input_api.canned_checks.CheckChangeHasTestField(
input_api, output_api))
return results