0

"up-to-date" should only use hyphens when used as compound modifier of a noun

See bug, apparently it's "an up-to-date thing" but "thing is up to date".
The bug is only about grd files, but I went through `git grep -l up-to-date`
while I was at it.

BUG=344535
TBR=IPC owner
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2059143002
Cr-Commit-Position: refs/heads/master@{#399698}
This commit is contained in:
thakis
2016-06-14 07:24:01 -07:00
committed by Commit bot
parent 36a611b6e4
commit 3e861deabe
97 changed files with 113 additions and 113 deletions
.gn
ash/system/chromeos/power
base
build
android
AndroidManifest.xml
incremental_install
java
org
chromium
incrementalinstall
install-build-deps.sh
linux
cc
chrome
components
content
docs
extensions/browser/api
gpu/command_buffer/service
native_client_sdk/src
pdf
ppapi/utility/graphics
remoting
sync/internal_api
third_party
tools
ui

2
.gn

@ -215,7 +215,7 @@ check_targets = [
# up a directory. The author notices that the script isn't re-run when the
# directory is updated, so adds a glob so all the files are listed as
# inputs. This seems to work great... until a file is deleted. When a
# file is deleted, all the inputs the glob lists will still be up-to-date
# file is deleted, all the inputs the glob lists will still be up to date
# and no command-lines will have been changed. The action will not be
# re-run and the build will be broken. It is possible to get this correct
# using glob, and it's possible to mess it up without glob, but globs make

@ -172,7 +172,7 @@ views::View* TrayPower::CreateTrayView(LoginStatus status) {
}
views::View* TrayPower::CreateDefaultView(LoginStatus status) {
// Make sure icon status is up-to-date. (Also triggers stub activation).
// Make sure icon status is up to date. (Also triggers stub activation).
PowerStatus::Get()->RequestStatusUpdate();
return NULL;
}

@ -61,7 +61,7 @@ namespace {
// Default version of Android to fall back to when actual version numbers
// cannot be acquired. Use the latest Android release with a higher bug fix
// version to avoid unnecessarily comparison errors with the latest release.
// This should be manually kept up-to-date on each Android release.
// This should be manually kept up to date on each Android release.
const int kDefaultAndroidMajorVersion = 6;
const int kDefaultAndroidMinorVersion = 0;
const int kDefaultAndroidBugfixVersion = 99;

@ -10,7 +10,7 @@
1. aapt when generating R.java in java.gypi:
Nothing in the manifest is used, but it is still required by aapt.
2. lint: [min|target]SdkVersion are required by lint and should
be kept up-to-date.
be kept up to date.
-->
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="dummy.package">

@ -181,7 +181,7 @@ final class ClassLoaderPatcher {
}
}
if (numNotChanged > 0) {
Log.i(TAG, numNotChanged + " libs already up-to-date.");
Log.i(TAG, numNotChanged + " libs already up to date.");
}
}

@ -424,7 +424,7 @@ echo
new_list_cmd="sudo apt-get install --reinstall $(echo $packages)"
if new_list="$(yes n | LANGUAGE=en LANG=C $new_list_cmd)"; then
# We probably never hit this following line.
echo "No missing packages, and the packages are up-to-date."
echo "No missing packages, and the packages are up to date."
elif [ $? -eq 1 ]; then
# We expect apt-get to have exit status of 1.
# This indicates that we cancelled the install with "yes n|".
@ -432,7 +432,7 @@ elif [ $? -eq 1 ]; then
sed -e '1,/The following NEW packages will be installed:/d;s/^ //;t;d')
new_list=$(echo "$new_list" | sed 's/ *$//')
if [ -z "$new_list" ] ; then
echo "No missing packages, and the packages are up-to-date."
echo "No missing packages, and the packages are up to date."
else
echo "Installing missing packages: $new_list."
sudo apt-get install ${do_quietly-} ${new_list}

@ -48,7 +48,7 @@ def main(args):
if os.path.exists(stamp):
with open(stamp) as s:
if s.read() == '\n'.join(URLS):
print "Chrome OS fonts already up-to-date in %s." % dest_dir
print "Chrome OS fonts already up to date in %s." % dest_dir
return 0
if os.path.isdir(dest_dir):

@ -189,7 +189,7 @@ def InstallSysroot(target_arch):
if os.path.exists(stamp):
with open(stamp) as s:
if s.read() == url:
print 'Debian Wheezy %s root image already up-to-date: %s' % \
print 'Debian Wheezy %s root image already up to date: %s' % \
(target_arch, sysroot)
return

@ -528,7 +528,7 @@ void ElementAnimations::PushNewAnimationsToImplThread(
element_animations_impl->ScrollOffsetForAnimation();
} else {
// The owning layer isn't yet in the active tree, so the main thread
// scroll offset will be up-to-date.
// scroll offset will be up to date.
current_scroll_offset = ScrollOffsetForAnimation();
}
animations_[i]->curve()->ToScrollOffsetAnimationCurve()->SetInitialValue(

@ -1298,7 +1298,7 @@ void BuildPropertyTreesTopLevelInternal(
BuildPropertyTreesInternal(root_layer, data_for_recursion, &data_from_child);
property_trees->needs_rebuild = false;
// The transform tree is kept up-to-date as it is built, but the
// The transform tree is kept up to date as it is built, but the
// combined_clips stored in the clip tree and the screen_space_opacity and
// is_drawn in the effect tree aren't computed during tree building.
property_trees->transform_tree.set_needs_update(false);

@ -855,7 +855,7 @@ Press any key to continue exploring.
</message>
<message name="IDS_FILE_BROWSER_DRIVE_WELCOME_TEXT_LONG" desc="In the Welcome to Google Drive banner, text of the welcome message, long version.">
<ph name="MARKUP_1">&lt;p&gt;&lt;strong&gt;<ex>&lt;strong&gt;</ex></ph>Access files from everywhere, even offline.<ph name="MARKUP_2">&lt;/strong&gt;<ex>&lt;/strong&gt;</ex></ph>
Files in Google Drive are up-to-date and available from any device.<ph name="MARKUP_3">&lt;/p&gt;<ex>&lt;/p&gt;</ex></ph>
Files in Google Drive are up to date and available from any device.<ph name="MARKUP_3">&lt;/p&gt;<ex>&lt;/p&gt;</ex></ph>
<ph name="MARKUP_4">&lt;p&gt;&lt;strong&gt;<ex>&lt;strong&gt;</ex></ph>Keep your files safe.<ph name="MARKUP_5">&lt;/strong&gt;<ex>&lt;/strong&gt;</ex></ph>
No matter what happens to your device, your files are safely stored in Google Drive.<ph name="MARKUP_6">&lt;/p&gt;<ex>&lt;/p&gt;</ex></ph>
<ph name="MARKUP_7">&lt;p&gt;&lt;strong&gt;<ex>&lt;strong&gt;</ex></ph>Share, create and collaborate<ph name="MARKUP_8">&lt;/strong&gt;<ex>&lt;/strong&gt;</ex></ph>

@ -573,12 +573,12 @@ Chromium is unable to recover your settings.
<!-- About Chrome page -->
<if expr="not chromeos">
<message name="IDS_UPGRADE_SUCCESSFUL_RELAUNCH" desc="Status label: Successfully updated Chromium">
Nearly up-to-date! Relaunch Chromium to finish updating.
Nearly up to date! Relaunch Chromium to finish updating.
</message>
</if>
<if expr="chromeos">
<message name="IDS_UPGRADE_SUCCESSFUL_RELAUNCH" desc="Status label: Successfully updated Chromium OS">
Nearly up-to-date! Restart your device to finish updating.
Nearly up to date! Restart your device to finish updating.
</message>
</if>
<if expr="chromeos">

@ -574,12 +574,12 @@ Google Chrome is unable to recover your settings.
<!-- About Chrome page -->
<if expr="not chromeos">
<message name="IDS_UPGRADE_SUCCESSFUL_RELAUNCH" desc="Status label: Successfully updated Google Chrome">
Nearly up-to-date! Relaunch Google Chrome to finish updating.
Nearly up to date! Relaunch Google Chrome to finish updating.
</message>
</if>
<if expr="chromeos">
<message name="IDS_UPGRADE_SUCCESSFUL_RELAUNCH" desc="Status label: Successfully updated Chrome OS">
Nearly up-to-date! Restart your device to finish updating.
Nearly up to date! Restart your device to finish updating.
</message>
</if>
<if expr="chromeos">

@ -13,7 +13,7 @@
Updating Chromium
</message>
<message name="IDS_SETTINGS_UPGRADE_SUCCESSFUL_RELAUNCH" desc="Status label: Successfully updated Chromium">
Nearly up-to-date! Relaunch Chromium to finish updating.
Nearly up to date! Relaunch Chromium to finish updating.
</message>
<message name="IDS_SETTINGS_UPGRADE_UP_TO_DATE" desc="Status label: Already up to date (Chromium)">
Chromium is up to date.

@ -13,7 +13,7 @@
Updating Google Chrome
</message>
<message name="IDS_SETTINGS_UPGRADE_SUCCESSFUL_RELAUNCH" desc="Status label: Successfully updated Google Chrome">
Nearly up-to-date! Relaunch Google Chrome to finish updating.
Nearly up to date! Relaunch Google Chrome to finish updating.
</message>
<message name="IDS_SETTINGS_UPGRADE_UP_TO_DATE" desc="Status label: Already up to date (Google Chrome)">
Google Chrome is up to date.

@ -28,7 +28,7 @@
Updating your device
</message>
<message name="IDS_SETTINGS_UPGRADE_SUCCESSFUL_RELAUNCH" desc="Status label: Successfully updated ChromiumOS/ChromeOS">
Nearly up-to-date! Restart your device to finish updating.
Nearly up to date! Restart your device to finish updating.
</message>
<message name="IDS_SETTINGS_UPGRADE_UPDATING_CHANNEL_SWITCH" desc="Status label: Updating ChromiumOS/ChromeOS to a specified channel">
Updating your device to <ph name="CHANNEL_NAME">$1<ex>stable</ex></ph> channel

@ -597,7 +597,7 @@ void WizardController::OnNetworkConnected() {
// Possible cases:
// 1. EULA was accepted, forced shutdown/reboot during update.
// 2. EULA was accepted, planned reboot after update.
// Make sure that device is up-to-date.
// Make sure that device is up to date.
InitiateOOBEUpdate();
}
} else {

@ -59,7 +59,7 @@ class EnterpriseInstallAttributes {
void Init(const base::FilePath& cache_file);
// Makes sure the local caches for enterprise-related install attributes are
// up-to-date with what cryptohome has. This method checks the readiness of
// up to date with what cryptohome has. This method checks the readiness of
// attributes and read them if ready. Actual read will be performed in
// ReadAttributesIfReady().
void ReadImmutableAttributes(const base::Closure& callback);

@ -201,12 +201,12 @@ bool ChromeExtensionsBrowserClient::DidVersionUpdate(
content::BrowserContext* context) {
Profile* profile = static_cast<Profile*>(context);
// Unit tests may not provide prefs; assume everything is up-to-date.
// Unit tests may not provide prefs; assume everything is up to date.
ExtensionPrefs* extension_prefs = ExtensionPrefs::Get(profile);
if (!extension_prefs)
return false;
// If we're inside a browser test, then assume prefs are all up-to-date.
// If we're inside a browser test, then assume prefs are all up to date.
if (base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kTestType))
return false;

@ -213,7 +213,7 @@ class CloudPolicyInvalidator : public syncer::InvalidationHandler,
// The version of the latest invalidation received. This is compared to
// the invalidation version of policy stored to determine when the
// invalidated policy is up-to-date.
// invalidated policy is up to date.
int64_t invalidation_version_;
// The number of invalidations with unknown version received. Since such

@ -319,7 +319,7 @@ cvox.ChromeVoxEditableTextArea = function(node, tts) {
this.multiline = true;
/**
* True if the shadow is up-to-date with the current value of this text area.
* True if the shadow is up to date with the current value of this text area.
* @type {boolean}
* @private
*/

@ -366,7 +366,7 @@
{
"version": "0",
"status": "requires_authorization",
"comment": "Google Update plugin is versioned but kept automatically up-to-date"
"comment": "Google Update plugin is versioned but kept automatically up to date"
}
],
"name": "Google Update",

@ -10,7 +10,7 @@
#include "content/public/browser/web_contents_observer.h"
#include "content/public/browser/web_contents_user_data.h"
// This class keeps the extension API's windowID up-to-date with the current
// This class keeps the extension API's windowID up to date with the current
// window of the tab.
class SessionTabHelper : public content::WebContentsObserver,
public content::WebContentsUserData<SessionTabHelper> {

@ -638,7 +638,7 @@ IN_PROC_BROWSER_TEST_F(SecurityStateModelLoadingTest, NavigationStateChanges) {
browser()->tab_strip_model()->GetActiveWebContents());
}
// Tests that the SecurityStateModel for a WebContents is up-to-date
// Tests that the SecurityStateModel for a WebContents is up to date
// when the WebContents is inserted into a Browser's TabStripModel.
IN_PROC_BROWSER_TEST_F(ChromeSecurityStateModelClientTest, AddedTab) {
ASSERT_TRUE(https_server_.Start());

@ -142,7 +142,7 @@ class BookmarkMenuBridge : public bookmarks::BookmarkModelObserver,
private:
friend class BookmarkMenuBridgeTest;
// True iff the menu is up-to-date with the actual BookmarkModel.
// True iff the menu is up to date with the actual BookmarkModel.
bool menuIsValid_;
Profile* profile_; // weak

@ -144,7 +144,7 @@ void ExtensionActionViewController::HidePopup() {
// We need to do these actions synchronously (instead of closing and then
// performing the rest of the cleanup in OnExtensionHostDestroyed()) because
// the extension host may close asynchronously, and we need to keep the view
// delegate up-to-date.
// delegate up to date.
if (popup_host_)
OnPopupClosed();
}

@ -212,7 +212,7 @@ class PDFUnsupportedFeatureInterstitial
} else if (command == "2") {
content::RecordAction(
UserMetricsAction("PDF_ReaderInterstitialIgnore"));
// Pretend that the plugin is up-to-date so that we don't block it.
// Pretend that the plugin is up to date so that we don't block it.
reader_webplugininfo_.version = base::ASCIIToUTF16("11.0.0.0");
OpenUsingReader(web_contents_, reader_webplugininfo_, NULL);
} else {

@ -750,7 +750,7 @@ void ToolbarActionsModel::OnActionToolbarPrefChange() {
std::rotate(current_pos, current_pos + 1, desired_pos + 1);
else
std::rotate(desired_pos, current_pos, current_pos + 1);
// Notify the observers to keep them up-to-date, unless we're highlighting
// Notify the observers to keep them up to date, unless we're highlighting
// (in which case we're deliberately only showing a subset of actions).
if (!is_highlighting())
FOR_EACH_OBSERVER(

@ -200,7 +200,7 @@ void VersionUpdaterCros::UpdateStatusChanged(
// If the updater is currently idle, just show the last operation (unless it
// was previously checking for an update -- in that case, the system is
// up-to-date now). See http://crbug.com/120063 for details.
// up to date now). See http://crbug.com/120063 for details.
UpdateEngineClient::UpdateStatusOperation operation_to_show = status.status;
if (status.status == UpdateEngineClient::UPDATE_STATUS_IDLE &&
last_operation_ !=

@ -4,7 +4,7 @@
// Multiply-included file, hence no include guard.
// Inclusion of all message files present in chrome. Keep this file
// up-to-date when adding a new value to the IPCMessageStart enum in
// up to date when adding a new value to the IPCMessageStart enum in
// ipc/ipc_message_start.h to ensure the corresponding message file is
// included here. Message classes used exclusively outside of chrome
// should not be listed here and instead get an exemption in

@ -132,7 +132,7 @@ class CachingFileSystem(FileSystem):
remaining_paths = set(paths) - set(up_to_date_data.iterkeys())
if len(remaining_paths) == 0:
# Everything was cached and up-to-date.
# Everything was cached and up to date.
return Future(value=up_to_date_data)
def raise_cache_miss(paths):

@ -126,7 +126,7 @@ class GithubFileSystem(FileSystem):
self._username, self._password = _LoadCredentials(object_store_creator)
self._blobstore = blobstore.AppEngineBlobstore()
self._fetcher = Fetcher(self._repo_url)
# Stores whether the github is up-to-date. This will either be True or
# Stores whether the github is up to date. This will either be True or
# empty, the emptiness most likely due to this being a cron run.
self._up_to_date_cache = object_store_creator.Create(
GithubFileSystem, category='up-to-date')

@ -48,7 +48,7 @@
<a href="overview">Overview</a>
</li>
<li>
Keep up-to-date by reading the
Keep up to date by reading the
<a href="http://blog.chromium.org/">Chromium blog</a>
</li>
<li>

@ -355,7 +355,7 @@ def _MaybeUpdateLatestRelease(version):
latest_release_fname = 'LATEST_RELEASE'
latest_release_url = '%s/%s' % (GS_CHROMEDRIVER_BUCKET, latest_release_fname)
# Check if LATEST_RELEASE is up-to-date.
# Check if LATEST_RELEASE is up to date.
latest_released_version = _GetWebPageContent(
'%s/%s' % (GS_CHROMEDRIVER_RELEASE_URL, latest_release_fname))
if version == latest_released_version:

@ -331,7 +331,7 @@ void InitializeStorageDirectory(const base::FilePath& dir) {
// Checks version file and clear old storage.
base::FilePath version_filepath = dir.Append("version");
if (IsCurrentVersion(version_filepath)) {
// The version is up-to-date, so there is nothing to do.
// The version is up to date, so there is nothing to do.
return;
}
// Delete old directory recursively and create a new directory.

@ -393,7 +393,7 @@ void DirectoryLoader::ReadDirectoryAfterCheckLocalState(
DirectoryFetchInfo directory_fetch_info(
local_id, entry->resource_id(), remote_changestamp);
// If the directory's changestamp is up-to-date or the global changestamp of
// If the directory's changestamp is up to date or the global changestamp of
// the metadata DB is new enough (which means the normal changelist loading
// should finish very soon), just schedule to run the callback, as there is no
// need to fetch the directory.

@ -28,7 +28,7 @@ namespace {
// Computes the path of each item in |file_list| returned from the server
// and stores to |result|, by using |resource_metadata|. If the metadata is not
// up-to-date and did not contain an item, adds the item to "drive/other" for
// up to date and did not contain an item, adds the item to "drive/other" for
// temporally assigning a path.
FileError ResolveSearchResultOnBlockingPool(
internal::ResourceMetadata* resource_metadata,

@ -80,7 +80,7 @@ class SyncClient {
void StartProcessingBacklog();
// Starts checking the existing pinned files to see if these are
// up-to-date. If stale files are detected, the local IDs of these files
// up to date. If stale files are detected, the local IDs of these files
// are added and the sync loop is started.
void StartCheckingExistingPinnedFiles();

@ -725,7 +725,7 @@ TEST_F(FileSystemTest, LoadFileSystemFromUpToDateCache) {
EXPECT_TRUE(ReadDirectorySync(util::GetDriveMyDriveRootPath()));
// SetUpTestFileSystem and FakeDriveService have the same
// changestamp (i.e. the local metadata is up-to-date), so no request for
// changestamp (i.e. the local metadata is up to date), so no request for
// new resource list (i.e., call to GetResourceList) should happen.
EXPECT_EQ(0, fake_drive_service_->file_list_load_count());

@ -174,9 +174,9 @@ class HistoryDatabase : public DownloadDatabase,
// Migration -----------------------------------------------------------------
// Makes sure the version is up-to-date, updating if necessary. If the
// Makes sure the version is up to date, updating if necessary. If the
// database is too old to migrate, the user will be notified. Returns
// sql::INIT_OK iff the DB is up-to-date and ready for use.
// sql::INIT_OK iff the DB is up to date and ready for use.
//
// This assumes it is called from the init function inside a transaction. It
// may commit the transaction and start a new one if migration requires it.

@ -32,7 +32,7 @@ class Rect;
// TODO(beaudoin): Keep on expanding this class so that OmniboxEditModel no
// longer needs to hold any reference to AutocompleteController. Also make
// this the point of contact between InstantController and OmniboxEditModel.
// As the refactor progresses, keep the class comment up-to-date to
// As the refactor progresses, keep the class comment up to date to
// precisely explain what this class is doing.
class OmniboxController : public AutocompleteControllerDelegate {
public:

@ -590,7 +590,7 @@ void PasswordFormManager::OnGetPasswordStoreResults(
DCHECK_EQ(state_, MATCHING_PHASE);
if (need_to_refetch_) {
// The received results are no longer up-to-date, need to re-request.
// The received results are no longer up to date, need to re-request.
state_ = PRE_MATCHING_PHASE;
FetchDataFromPasswordStore();
need_to_refetch_ = false;

@ -297,7 +297,7 @@ void PasswordStore::LogStatsForBulkDeletionDuringRollback(int num_deletions) {
}
PasswordStoreChangeList PasswordStore::AddLoginSync(const PasswordForm& form) {
// There is no good way to check if the password is actually up-to-date, or
// There is no good way to check if the password is actually up to date, or
// at least to check if it was actually changed. Assume it is.
if (AffiliatedMatchHelper::IsValidAndroidCredential(form))
ScheduleFindAndUpdateAffiliatedWebLogins(form);

@ -23,7 +23,7 @@ namespace policy {
class PolicyHeaderIOHelper;
// Per-profile service used to generate PolicyHeaderIOHelper objects, and
// keep them up-to-date as policy changes.
// keep them up to date as policy changes.
// TODO(atwilson): Move to components/policy once CloudPolicyStore is moved.
class POLICY_EXPORT PolicyHeaderService : public CloudPolicyStore::Observer {
public:

@ -76,7 +76,7 @@ typedef base::Callback<std::unique_ptr<EncodedLogo>(
ParseLogoResponse;
// Encodes the fingerprint of the cached logo in the logo URL. This enables the
// server to verify whether the cached logo is up-to-date.
// server to verify whether the cached logo is up to date.
typedef base::Callback<GURL(const GURL& logo_url,
const std::string& fingerprint,
bool wants_cta,

@ -205,7 +205,7 @@ enum CrossDevicePromoInitialized {
// histogram, which records the state of the AccountReconcilor when GAIA returns
// a specific response.
enum AccountReconcilorState {
// The AccountReconcilor has finished running ans is up-to-date.
// The AccountReconcilor has finished running ans is up to date.
ACCOUNT_RECONCILOR_OK,
// The AccountReconcilor is running and gathering information.
ACCOUNT_RECONCILOR_RUNNING,

@ -134,7 +134,7 @@ void ActionUpdateCheck::OnUpdateCheckSucceeded(
if (!IsVersionNewer(crx->component.version, it->manifest.version)) {
// The CRX is up to date.
ChangeItemState(crx, CrxUpdateItem::State::kUpToDate);
VLOG(1) << "Component already up-to-date: " << crx->id;
VLOG(1) << "Component already up to date: " << crx->id;
continue;
}

@ -362,7 +362,7 @@ void VisitedLinkMaster::AddURL(const GURL& url) {
if (!table_builder_.get() &&
!table_is_loading_from_file_ &&
index != null_hash_) {
// Not rebuilding, so we want to keep the file on disk up-to-date.
// Not rebuilding, so we want to keep the file on disk up to date.
if (persist_to_disk_) {
WriteUsedItemCountToFile();
WriteHashRangeToFile(index, index);
@ -380,7 +380,7 @@ void VisitedLinkMaster::AddURLs(const std::vector<GURL>& urls) {
ResizeTableIfNecessary();
}
// Keeps the file on disk up-to-date.
// Keeps the file on disk up to date.
if (!table_builder_.get() &&
!table_is_loading_from_file_ &&
persist_to_disk_)
@ -816,7 +816,7 @@ bool VisitedLinkMaster::ReadFileHeader(FILE* file,
if (signature != kFileSignature)
return false;
// Verify the version is up-to-date. As with other read errors, a version
// Verify the version is up to date. As with other read errors, a version
// mistmatch will trigger a rebuild of the database from history, which will
// have the effect of migrating the database.
int32_t version;

@ -4,7 +4,7 @@
// Multiply-included file, hence no include guard.
// Inclusion of all message files present in content. Keep this file
// up-to-date when adding a new value to the IPCMessageStart enum in
// up to date when adding a new value to the IPCMessageStart enum in
// ipc/ipc_message_start.h to ensure the corresponding message file is
// included here.
#include "content/common/content_message_generator.h"

@ -172,7 +172,7 @@ void PluginList::SetPlugins(const std::vector<WebPluginInfo>& plugins) {
base::AutoLock lock(lock_);
// If we haven't been invalidated in the mean time, mark the plugin list as
// up-to-date.
// up to date.
if (loading_state_ != LOADING_STATE_NEEDS_REFRESH)
loading_state_ = LOADING_STATE_UP_TO_DATE;

@ -75,7 +75,7 @@ class CONTENT_EXPORT PluginList {
void GetPlugins(std::vector<WebPluginInfo>* plugins);
// Copies the list of plugins into |plugins| without loading them.
// Returns true if the list of plugins is up-to-date.
// Returns true if the list of plugins is up to date.
bool GetPluginsNoRefresh(std::vector<WebPluginInfo>* plugins);
// Returns a list in |info| containing plugins that are found for
@ -156,7 +156,7 @@ class CONTENT_EXPORT PluginList {
// States whether we will load the plugin list the next time we try to access
// it, whether we are currently in the process of loading it, or whether we
// consider it up-to-date.
// consider it up to date.
LoadingState loading_state_;
// Extra plugin paths that we want to search when loading.

@ -137,7 +137,7 @@ class MediaStreamAudioDeliverer {
// |consumers_| on the audio thread.
std::vector<Consumer*> pending_consumers_;
// Consumers that are up-to-date on the current audio format and are receiving
// Consumers that are up to date on the current audio format and are receiving
// audio data are placed in this list.
std::vector<Consumer*> consumers_;

@ -684,7 +684,7 @@ void PepperPluginInstanceImpl::Delete() {
// Force-unbind any Graphics. In the case of Graphics2D, if the plugin
// leaks the graphics 2D, it may actually get cleaned up after our
// destruction, so we need its pointers to be up-to-date.
// destruction, so we need its pointers to be up to date.
BindGraphics(pp_instance(), 0);
container_ = NULL;
}

@ -141,7 +141,7 @@ class BlinkTestController : public base::NonThreadSafe,
void OnTestFinishedInSecondaryRenderer();
// Makes sure that the potentially new renderer associated with |frame| is 1)
// initialized for the test, 2) kept-up-to-date wrt test flags and 3)
// initialized for the test, 2) kept up to date wrt test flags and 3)
// monitored for crashes.
void HandleNewRenderFrameHost(RenderFrameHost* frame);

@ -93,7 +93,7 @@ ninja -C out\Debug chrome
```
The `update.py` script only needs to be run once per checkout. Clang will be
kept up-to-date by `gclient runhooks`.
kept up to date by `gclient runhooks`.
Current brokenness:

@ -22,7 +22,7 @@ and library dependencies directly from Ubuntu:
### Installing the sysroot
A prebuilt sysroot image is kept up-to-date on Cloud Storage. It will
A prebuilt sysroot image is kept up to date on Cloud Storage. It will
automatically be installed by gclient runhooks installed if you have
`target_arch=arm` in your `GYP_DEFINES`.

@ -408,7 +408,7 @@ or within gdb:
If some messages show as unknown, check if the list of IPC message headers in
[chrome/common/logging_chrome.cc](/chrome/common/logging_chrome.cc) is
up-to-date. In case this file reference goes out of date, try looking for usage
up to date. In case this file reference goes out of date, try looking for usage
of macros like `IPC_MESSAGE_LOG_ENABLED` or `IPC_MESSAGE_MACROS_LOG_ENABLED`.
## Using valgrind

@ -94,7 +94,7 @@ logical directory (and make sure `CCACHE_BASEDIR` also refers to a physical
parent).
If you tune ccache correctly, a second working directory that uses a branch
tracking trunk and is up-to-date with trunk and was gclient sync'ed at about the
tracking trunk and is up to date with trunk and was gclient sync'ed at about the
same time should build chrome in about 1/3 the time, and the cache misses as
reported by `ccache -s` should barely increase.

@ -4,7 +4,7 @@ TODO: this page looks very outdated. glossary.md does not exist,
git.chromium.org does not exist. Delete it?
This page is meant to help keep track of TPM use across the system. It may not
be up-to-date at any given point, but it's a wiki so you know what to do.
be up to date at any given point, but it's a wiki so you know what to do.
## Details

@ -74,7 +74,7 @@ GN will produce a file `all.sln` in your build directory. It will internally
use Ninja to compile while still allowing most IDE functions to work (there is
no native Visual Studio compilation mode). If you manually run "gen" again you
will need to resupply this argument, but normally GN will keep the build and
IDE files up-to-date automatically when you build.
IDE files up to date automatically when you build.
The generated solution will contain several thousand projects and will be very
slow to load. Use the `--filters` argument to restrict generating project files

@ -174,7 +174,7 @@ RuntimeAPI::RuntimeAPI(content::BrowserContext* context)
delegate_ = ExtensionsBrowserClient::Get()->CreateRuntimeAPIDelegate(
browser_context_);
// Check if registered events are up-to-date. We can only do this once
// Check if registered events are up to date. We can only do this once
// per browser context, since it updates internal state when called.
dispatch_chrome_updated_event_ =
ExtensionsBrowserClient::Get()->DidVersionUpdate(browser_context_);

@ -1835,7 +1835,7 @@ bool ExtensionWebRequestEventRouter::ProcessDeclarativeRules(
: RulesRegistryService::kDefaultRulesRegistryID;
RulesRegistryKey rules_key(browser_context, rules_registry_id);
// If this check fails, check that the active stages are up-to-date in
// If this check fails, check that the active stages are up to date in
// extensions/browser/api/declarative_webrequest/request_stage.h .
DCHECK(request_stage & kActiveStages);

@ -2208,7 +2208,7 @@ class GLES2DecoderImpl : public GLES2Decoder, public ErrorStateClient {
// Most recent generation of the TextureManager. If this no longer matches
// the current generation when our context becomes current, then we'll rebind
// all the textures to stay up-to-date with Texture::service_id() changes.
// all the textures to stay up to date with Texture::service_id() changes.
uint32_t texture_manager_service_id_generation_;
bool force_shader_name_hashing_for_test;

@ -15,7 +15,7 @@ def List(remote_manifest, local_manifest, display_revisions):
_PrintBundle(local_bundle, bundle, needs_update, display_revisions)
if not any_bundles_need_update:
print '\nAll installed bundles are up-to-date.'
print '\nAll installed bundles are up to date.'
local_only_bundles = set([b.name for b in local_manifest.GetBundles()])
local_only_bundles -= set([b.name for b in remote_manifest.GetBundles()])

@ -292,7 +292,7 @@ def UpdateBundleIfNeeded(delegate, remote_manifest, local_manifest,
_UpdateBundle(delegate, bundle, local_manifest)
else:
print '%s is already up-to-date.' % (bundle.name,)
print '%s is already up to date.' % (bundle.name,)
else:
logging.error('Bundle %s does not exist.' % (bundle_name,))

@ -119,7 +119,7 @@ class TestCommands(SdkToolsTestCase):
self.assertTrue(re.search('I.*?sdk_tools.*?stable', output, re.MULTILINE))
# This line is important (it's used by the updater to determine if the
# sdk_tools bundle needs to be updated), so let's be explicit.
self.assertTrue('All installed bundles are up-to-date.')
self.assertTrue('All installed bundles are up to date.')
def testListMultiple(self):
"""The list command should display multiple bundles."""
@ -207,13 +207,13 @@ class TestCommands(SdkToolsTestCase):
os.path.join(self.basedir, 'nacl_sdk', 'pepper_23', 'dummy.txt')))
def testUpdateNoNewVersion(self):
"""The update command should do nothing if the bundle is already up-to-date.
"""The update command should do nothing if the bundle is already up to date.
"""
self._AddDummyBundle(self.manifest, 'pepper_23')
self._WriteManifest()
self._Run(['update', 'pepper_23'])
output = self._Run(['update', 'pepper_23'])
self.assertTrue('is already up-to-date.' in output)
self.assertTrue('is already up to date.' in output)
def testUpdateWithNewVersion(self):
"""The update command should update to a new version if it exists."""

@ -48,7 +48,7 @@ PNaCl
browser (version ``Y``).
* PNaCl's support for use of libstdc++ 4.6 as the C++ standard library is
deprecated and will be removed in the next release. PNaCl has used libc++
(which is much more up-to-date, currently based on LLVM 3.6) as the default
(which is much more up to date, currently based on LLVM 3.6) as the default
since Pepper 33.
* PNaCl's experimental `Subzero translator`_ is available for x86-32 NaCl in
Chrome version 43, behind a flag. To give it a try, run Chrome with the

@ -90,7 +90,7 @@ class PaintAggregator {
// InvalidateRect. We need to know this distinction for some operations.
//
// - The paint bounds union is computed on the fly so we don't have to keep
// a rectangle up-to-date as we do different operations.
// a rectangle up to date as we do different operations.
class InternalPaintUpdate {
public:
InternalPaintUpdate();

@ -125,7 +125,7 @@ class PaintAggregator {
// InvalidateRect. We need to know this distinction for some operations.
//
// - The paint bounds union is computed on the fly so we don't have to keep
// a rectangle up-to-date as we do different operations.
// a rectangle up to date as we do different operations.
class InternalPaintUpdate {
public:
InternalPaintUpdate();

@ -81,7 +81,7 @@ static bool IsRewrittenKey(uint32_t code) {
// unchanged, allowing Alt+RightClick also to be injected, as long as the
// target application doesn't distinguish between left and right Alt keys.
//
// This file must be kept up-to-date with changes to
// This file must be kept up to date with changes to
// chrome/browser/chromeos/events/event_rewriter.cc

@ -153,7 +153,7 @@ std::string JsonHostConfig::GetSerializedData() const {
return;
}
// Ensure the authorization token is up-to-date before using it.
// Ensure the authorization token is up to date before using it.
[self updateAuthorizationStatus];
[self updateUI];
@ -176,7 +176,7 @@ std::string JsonHostConfig::GetSerializedData() const {
}
- (void)onDisable:(id)sender {
// Ensure the authorization token is up-to-date before using it.
// Ensure the authorization token is up to date before using it.
[self updateAuthorizationStatus];
[self updateUI];
if (!is_pane_unlocked_)

@ -824,7 +824,7 @@ void SyncManagerImpl::OnSyncCycleEvent(const SyncCycleEvent& event) {
DCHECK(thread_checker_.CalledOnValidThread());
// Only send an event if this is due to a cycle ending and this cycle
// concludes a canonical "sync" process; that is, based on what is known
// locally we are "all happy" and up-to-date. There may be new changes on
// locally we are "all happy" and up to date. There may be new changes on
// the server, but we'll get them on a subsequent sync.
//
// Notifications are sent at the end of every sync cycle, regardless of

@ -227,7 +227,7 @@ test(function(t) {
// ancestor in the accessibility tree but not in the layout tree.
//
// Access both of these accessibility objects first to make sure that
// the owned children are up-to-date before running assertions,
// the owned children are up to date before running assertions,
// since aria-owns is processed lazily.
var axContainer6a = accessibilityController.accessibleElementById("container6a");
axContainer6a.childrenCount;

@ -422,7 +422,7 @@ static const TextIteratorBehaviorFlags iteratorFlagsForFindPlainText = TextItera
template <typename Strategy>
static EphemeralRangeTemplate<Strategy> findPlainTextAlgorithm(const EphemeralRangeTemplate<Strategy>& inputRange, const String& target, FindOptions options)
{
// CharacterIterator requires layoutObjects to be up-to-date.
// CharacterIterator requires layoutObjects to be up to date.
if (!inputRange.startPosition().inShadowIncludingDocument())
return EphemeralRangeTemplate<Strategy>();
DCHECK_EQ(inputRange.startPosition().document(), inputRange.endPosition().document());

@ -372,7 +372,7 @@ void TextTrack::cueDidChange(TextTrackCue* cue)
// track has a list of cues.
DCHECK(m_cues && cue->track() == this);
// Make sure the TextTrackCueList order is up-to-date.
// Make sure the TextTrackCueList order is up to date.
// FIXME: Only need to do this if the change was to any of the timestamps.
m_cues->updateCueIndex(cue);

@ -45,7 +45,7 @@ class CounterNode;
// common case where there is no CounterNode, LayoutObject also keeps track of
// whether it has at least one CounterNode in the hasCounterNodeMap bit.
//
// Keeping the map up-to-date is the reason why LayoutObjects need to call into
// Keeping the map up to date is the reason why LayoutObjects need to call into
// LayoutCounter during their lifetime (see the static functions below).
class LayoutCounter final : public LayoutText {
public:

@ -1197,7 +1197,7 @@ bool LayoutFlexibleBox::computeNextFlexLine(OrderedFlexItemList& orderedChildren
// If this condition is true, then computeMainAxisExtentForChild will call child.intrinsicContentLogicalHeight()
// and child.scrollbarLogicalHeight(), so if the child has intrinsic min/max/preferred size,
// run layout on it now to make sure its logical height and scroll bars are up-to-date.
// run layout on it now to make sure its logical height and scroll bars are up to date.
if (childHasIntrinsicMainAxisSize(*child) && child->needsLayout()) {
child->clearOverrideSize();
child->layoutIfNeeded();

@ -379,7 +379,7 @@ LayoutMultiColumnSet* LayoutMultiColumnFlowThread::columnSetAtBlockOffset(Layout
{
if (LayoutMultiColumnSet* columnSet = m_lastSetWorkedOn) {
// Layout in progress. We are calculating the set heights as we speak, so the column set range
// information is not up-to-date.
// information is not up to date.
while (columnSet->logicalTopInFlowThread() > offset) {
// Sometimes we have to use a previous set. This happens when we're working with a block
// that contains a spanner (so that there's a column set both before and after the

@ -176,7 +176,7 @@ bool LayoutPart::nodeAtPoint(HitTestResult& result, const HitTestLocation& locat
HitTestRequest newHitTestRequest(result.hitTestRequest().type() | HitTestRequest::ChildFrameHitTest);
HitTestResult childFrameResult(newHitTestRequest, newHitTestLocation);
// The frame's layout and style must be up-to-date if we reach here.
// The frame's layout and style must be up to date if we reach here.
bool isInsideChildFrame = childRootItem.hitTestNoLifecycleUpdate(childFrameResult);
if (result.hitTestRequest().listBased()) {

@ -128,7 +128,7 @@ void LayoutScrollbarPart::computeScrollbarWidth()
{
if (!m_scrollbar->owningLayoutObject())
return;
// FIXME: We are querying layout information but nothing guarantees that it's up-to-date, especially since we are called at style change.
// FIXME: We are querying layout information but nothing guarantees that it's up to date, especially since we are called at style change.
// FIXME: Querying the style's border information doesn't work on table cells with collapsing borders.
int visibleSize = m_scrollbar->owningLayoutObject()->size().width() - m_scrollbar->owningLayoutObject()->style()->borderLeftWidth() - m_scrollbar->owningLayoutObject()->style()->borderRightWidth();
int w = calcScrollbarThicknessUsing(MainOrPreferredSize, style()->width(), visibleSize);
@ -145,7 +145,7 @@ void LayoutScrollbarPart::computeScrollbarHeight()
{
if (!m_scrollbar->owningLayoutObject())
return;
// FIXME: We are querying layout information but nothing guarantees that it's up-to-date, especially since we are called at style change.
// FIXME: We are querying layout information but nothing guarantees that it's up to date, especially since we are called at style change.
// FIXME: Querying the style's border information doesn't work on table cells with collapsing borders.
int visibleSize = m_scrollbar->owningLayoutObject()->size().height() - m_scrollbar->owningLayoutObject()->style()->borderTopWidth() - m_scrollbar->owningLayoutObject()->style()->borderBottomWidth();
int h = calcScrollbarThicknessUsing(MainOrPreferredSize, style()->height(), visibleSize);

@ -659,7 +659,7 @@ void LayoutTreeAsText::writeLayers(TextStream& ts, const PaintLayer* rootLayer,
ClipRect damageRect, clipRectToApply;
layer->clipper().calculateRects(ClipRectsContext(rootLayer, UncachedClipRects), paintRect, layerBounds, damageRect, clipRectToApply);
// Ensure our lists are up-to-date.
// Ensure our lists are up to date.
layer->stackingNode()->updateLayerListsIfNeeded();
LayoutPoint offsetFromRoot;

@ -319,7 +319,7 @@ void LayoutVTTCue::layout()
// Determine the area covered by the media controls, if any. If the controls
// are present, they are the next sibling of the text track container, which
// is our parent. (LayoutMedia ensures that the media controls are laid out
// before text tracks, so that the layout is up-to-date here.)
// before text tracks, so that the layout is up to date here.)
ASSERT(parent()->node()->isTextTrackContainer());
IntRect controlsRect;
if (LayoutObject* parentSibling = parent()->nextSibling()) {

@ -1775,7 +1775,7 @@ PaintLayer* PaintLayer::hitTestLayer(PaintLayer* rootLayer, PaintLayer* containe
if (hitTestClippedOutByClipPath(rootLayer, hitTestLocation))
return nullptr;
// Ensure our lists and 3d status are up-to-date.
// Ensure our lists and 3d status are up to date.
m_stackingNode->updateLayerListsIfNeeded();
update3DTransformedDescendantStatus();

@ -280,7 +280,7 @@ PaintLayerPainter::PaintResult PaintLayerPainter::paintLayerContents(GraphicsCon
if (m_paintLayer.layoutObject()->view()->frame() && m_paintLayer.layoutObject()->view()->frame()->shouldThrottleRendering())
return result;
// Ensure our lists are up-to-date.
// Ensure our lists are up to date.
m_paintLayer.stackingNode()->updateLayerListsIfNeeded();
LayoutSize subpixelAccumulation = m_paintLayer.compositingState() == PaintsIntoOwnBacking ? m_paintLayer.subpixelAccumulation() : paintingInfoArg.subPixelAccumulation;

@ -105,7 +105,7 @@ public:
{
// In the context of this test, the following loop will give the correct result, but only because the test
// forces all frames to be decoded in loadImage() above. There is no general guarantee that frameDecodedSize()
// is up-to-date. Because of how multi frame images (like GIF) work, requesting one frame to be decoded may
// is up to date. Because of how multi frame images (like GIF) work, requesting one frame to be decoded may
// require other previous frames to be decoded as well. In those cases frameDecodedSize() wouldn't return the
// correct thing for the previous frame because the decoded size wouldn't have propagated upwards to the
// BitmapImage frame cache.

@ -260,12 +260,12 @@ def parse_args(args):
dest="build",
action="store_true",
default=True,
help=("Check to ensure the build is up-to-date (default).")),
help=("Check to ensure the build is up to date (default).")),
optparse.make_option(
"--no-build",
dest="build",
action="store_false",
help="Don't check to see if the build is up-to-date."),
help="Don't check to see if the build is up to date."),
optparse.make_option(
"--child-processes",
help="Number of drivers to run in parallel."),

@ -92,9 +92,9 @@ class PerfTestsRunner(object):
optparse.make_option("--build-number",
help=("The build number of the builder running this script.")),
optparse.make_option("--build", dest="build", action="store_true", default=True,
help="Check to ensure the DumpRenderTree build is up-to-date (default)."),
help="Check to ensure the DumpRenderTree build is up to date (default)."),
optparse.make_option("--no-build", dest="build", action="store_false",
help="Don't check to see if the DumpRenderTree build is up-to-date."),
help="Don't check to see if the DumpRenderTree build is up to date."),
optparse.make_option("--build-directory",
help="Path to the directory under which build files are kept (should not include configuration)"),
optparse.make_option("--time-out-ms", default=600 * 1000,

@ -77,7 +77,7 @@ def main():
head = RevParse(BORINGSSL_SRC_PATH, 'HEAD')
if head == commit:
print 'BoringSSL already up-to-date.'
print 'BoringSSL already up to date.'
return 0
print 'Rolling BoringSSL from %s to %s...' % (head, commit)

@ -841,7 +841,7 @@ def main():
if re.search(r'\b(clang|asan|lsan|msan|tsan)=1',
os.environ.get('GYP_DEFINES', '')):
is_clang_required = True
# clang previously downloaded, keep it up-to-date.
# clang previously downloaded, keep it up to date.
# If you don't want this, delete third_party/llvm-build on your machine.
if os.path.isdir(LLVM_BUILD_DIR):
is_clang_required = True

@ -4686,7 +4686,7 @@
The problem happens if a file is ever removed because the inputs are
not listed on the command line to the script. Because the script
hasn't changed and all inputs are up-to-date, the script will not
hasn't changed and all inputs are up to date, the script will not
re-run and you will get a stale build. Instead, either list all
inputs on the command line to the script, or if there are many, create
a separate list file that the script reads. As long as this file is
@ -4704,7 +4704,7 @@
you do not typically need to list them in the inputs section.
Inputs for binary targets will be treated as order-only dependencies,
meaning that they will be forced up-to-date before compiling or
meaning that they will be forced up to date before compiling or
any files in the target, but changes in the inputs will not
necessarily force the target to compile. This is because it is
expected that the compiler will report the precise list of input

@ -166,7 +166,7 @@ void NinjaActionTargetWriter::WriteSourceRules(
path_output_.WriteFile(out_, sources[i]);
if (!input_dep.value().empty()) {
// Using "|" for the dependencies forces all implicit dependencies to be
// fully up-to-date before running the action, and will re-run this
// fully up to date before running the action, and will re-run this
// action if any input dependencies change. This is important because
// this action may consume the outputs of previous steps.
out_ << " | ";

@ -271,7 +271,7 @@ void NinjaBinaryTargetWriter::Run() {
WriteCompilerVars(used_types);
// The input dependencies will be an order-only dependency. This will cause
// Ninja to make sure the inputs are up-to-date before compiling this source,
// Ninja to make sure the inputs are up to date before compiling this source,
// but changes in the inputs deps won't cause the file to be recompiled.
//
// This is important to prevent changes in unrelated actions that are

@ -986,7 +986,7 @@ const char kInputs_Help[] =
"\n"
" The problem happens if a file is ever removed because the inputs are\n"
" not listed on the command line to the script. Because the script\n"
" hasn't changed and all inputs are up-to-date, the script will not\n"
" hasn't changed and all inputs are up to date, the script will not\n"
" re-run and you will get a stale build. Instead, either list all\n"
" inputs on the command line to the script, or if there are many, create\n"
" a separate list file that the script reads. As long as this file is\n"
@ -1001,7 +1001,7 @@ const char kInputs_Help[] =
" you do not typically need to list them in the inputs section.\n"
"\n"
" Inputs for binary targets will be treated as order-only dependencies,\n"
" meaning that they will be forced up-to-date before compiling or\n"
" meaning that they will be forced up to date before compiling or\n"
" any files in the target, but changes in the inputs will not\n"
" necessarily force the target to compile. This is because it is\n"
" expected that the compiler will report the precise list of input\n"

@ -286,7 +286,7 @@ class ValgrindTool(BaseTool):
This function will run dsymutil if the .dSYM bundle is missing or if
it looks like a fake_dsym. A non-fake dsym that already exists is assumed
to be up-to-date.
to be up to date.
"""
test_command = self._args[0]
dsym_bundle = self._args[0] + '.dSYM'

@ -498,7 +498,7 @@ class GFX_EXPORT RenderText {
RenderText();
// NOTE: The value of these accessors may be stale. Please make sure
// that these fields are up-to-date before accessing them.
// that these fields are up to date before accessing them.
const base::string16& layout_text() const { return layout_text_; }
const base::string16& display_text() const { return display_text_; }
bool text_elided() const { return text_elided_; }

@ -336,7 +336,7 @@
#define GL_RG8_EXT 0x822B
#endif /* GL_EXT_texture_rg */
// This is from NV_path_rendering, but the Mesa GL header is not up-to-date with
// This is from NV_path_rendering, but the Mesa GL header is not up to date with
// the most recent
// version of the extension. This definition could be removed once glext.h
// r27498 or later is

@ -681,7 +681,7 @@ cr.define('cr.ui', function() {
// In most cases, our active touch will be in the 'touches' collection,
// but we can't assert that because occasionally two touchend events can
// occur at almost the same time with both having empty 'touches' lists.
// I.e., 'touches' seems like it can be a bit more up-to-date than the
// I.e., 'touches' seems like it can be a bit more up to date than the
// current event.
return;
}