Remove histograms Compositing.Renderer.CALayer.ChangedIOSurfaces*
Compositing.Renderer.CALayer.ChangedIOSurfacesPerFrame Compositing.Renderer.CALayer.ChangedIOSurfacesPercentagePerFrame Compositing.Renderer.CALayer.ChangedIOSurfacesSizePerFrame They are longer needed. OBSOLETE_HISTOGRAM[Compositing.Renderer.CALayer.ChangedIOSurfacesPerFrame]=no longer needed OBSOLETE_HISTOGRAM[Compositing.Renderer.CALayer.ChangedIOSurfacesPercentagePerFrame]=no longer needed OBSOLETE_HISTOGRAM[Compositing.Renderer.CALayer.ChangedIOSurfacesSizePerFrame]=no longer needed Bug: 1507868 Change-Id: Ic1d901eec1b7c9929f965b26355a7d6d9fe46f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5147728 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Weilun Shi <sweilun@chromium.org> Auto-Submit: Maggie Chen <magchen@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#1244322}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
c01c85c04e
commit
3fc615a2bd
tools/metrics/histograms/metadata/compositing
ui/accelerated_widget_mac
@ -601,37 +601,6 @@ chromium-metrics-reviews@google.com.
|
||||
</summary>
|
||||
</histogram>
|
||||
|
||||
<histogram
|
||||
name="Compositing.Renderer.CALayer.ChangedIOSurfacesPercentagePerFrame"
|
||||
units="%" expires_after="2024-01-14">
|
||||
<owner>magchen@chromium.org</owner>
|
||||
<owner>ccameron@chromium.org</owner>
|
||||
<summary>
|
||||
The percentage of changed IOSurface number in all IOSurface per frame.
|
||||
Recorded during the CALayer Tree commit to CoreAnimation on Mac.
|
||||
</summary>
|
||||
</histogram>
|
||||
|
||||
<histogram name="Compositing.Renderer.CALayer.ChangedIOSurfacesPerFrame"
|
||||
units="surfaces" expires_after="2024-05-19">
|
||||
<owner>magchen@chromium.org</owner>
|
||||
<owner>ccameron@chromium.org</owner>
|
||||
<summary>
|
||||
The number of IOSurfaces changed per frame. Recorded during the CALayer Tree
|
||||
commit to CoreAnimation on Mac.
|
||||
</summary>
|
||||
</histogram>
|
||||
|
||||
<histogram name="Compositing.Renderer.CALayer.ChangedIOSurfacesSizePerFrame"
|
||||
units="bytes" expires_after="2024-01-14">
|
||||
<owner>magchen@chromium.org</owner>
|
||||
<owner>ccameron@chromium.org</owner>
|
||||
<summary>
|
||||
Total IOSurfaces area size updated per frame. Recorded during the CALayer
|
||||
Tree commit to CoreAnimation on Mac.
|
||||
</summary>
|
||||
</histogram>
|
||||
|
||||
<histogram name="Compositing.Renderer.CALayerResult" enum="CALayerResult"
|
||||
expires_after="2024-06-30">
|
||||
<owner>ccameron@chromium.org</owner>
|
||||
|
@ -316,11 +316,6 @@ class ACCELERATED_WIDGET_MAC_EXPORT CARendererLayerTree {
|
||||
const bool allow_solid_color_layers_ = true;
|
||||
id<MTLDevice> __strong metal_device_ = nil;
|
||||
|
||||
// Used for uma.
|
||||
int changed_io_surfaces_during_commit_ = 0;
|
||||
int unchanged_io_surfaces_during_commit_ = 0;
|
||||
int total_updated_io_surface_size_during_commit_ = 0;
|
||||
|
||||
// Enable CALayerTree optimization that will try to reuse the CALayer with a
|
||||
// matched CALayer from the old CALayerTree in the previous frame.
|
||||
const bool ca_layer_tree_optimization_;
|
||||
|
@ -59,36 +59,6 @@ class ComparatorSkColor4f {
|
||||
}
|
||||
};
|
||||
|
||||
void RecordIOSurfaceHistograms(
|
||||
int changed_io_surfaces_during_commit,
|
||||
int unchanged_io_surfaces_during_commit,
|
||||
int total_updated_io_surface_size_during_commit) {
|
||||
// UMA for updated IOSurfaces.
|
||||
int total_io_surfaces =
|
||||
changed_io_surfaces_during_commit + unchanged_io_surfaces_during_commit;
|
||||
if (total_io_surfaces > 0) {
|
||||
// Total changed IOSurface size per frame. Use 100M as a max for this
|
||||
// histogram. IOSurface size = w x h x bpp x planes. A 32 bpp HD surface
|
||||
// takes ~8M bytes.
|
||||
base::UmaHistogramCustomCounts(
|
||||
"Compositing.Renderer.CALayer.ChangedIOSurfacesSizePerFrame",
|
||||
total_updated_io_surface_size_during_commit, /*min=*/1,
|
||||
/*exclusive_max=*/100000000, /*buckets=*/50);
|
||||
|
||||
// The number of changed IOSurfaces per frame.
|
||||
base::UmaHistogramCustomCounts(
|
||||
"Compositing.Renderer.CALayer.ChangedIOSurfacesPerFrame",
|
||||
changed_io_surfaces_during_commit, /*min=*/1, /*exclusive_max=*/300,
|
||||
/*buckets=*/50);
|
||||
|
||||
int changed_io_surface_percentage =
|
||||
changed_io_surfaces_during_commit * 100 / total_io_surfaces;
|
||||
base::UmaHistogramPercentage(
|
||||
"Compositing.Renderer.CALayer.ChangedIOSurfacesPercentagePerFrame",
|
||||
changed_io_surface_percentage);
|
||||
}
|
||||
}
|
||||
|
||||
// This will enqueue |io_surface| to be drawn by |av_layer|. This will
|
||||
// retain |cv_pixel_buffer| until it is no longer being displayed.
|
||||
bool AVSampleBufferDisplayLayerEnqueueCVPixelBuffer(
|
||||
@ -376,11 +346,6 @@ void CARendererLayerTree::CommitScheduledCALayers(
|
||||
// tree, they will be removed from the CALayer tree in this deallocation.
|
||||
old_tree.reset();
|
||||
has_committed_ = true;
|
||||
|
||||
// UMA
|
||||
RecordIOSurfaceHistograms(changed_io_surfaces_during_commit_,
|
||||
unchanged_io_surfaces_during_commit_,
|
||||
total_updated_io_surface_size_during_commit_);
|
||||
}
|
||||
|
||||
void CARendererLayerTree::MatchLayersToOldTreeDefault(
|
||||
@ -1239,20 +1204,12 @@ void CARendererLayerTree::ContentLayer::CommitToCA(
|
||||
if (update_contents) {
|
||||
if (io_surface_) {
|
||||
ca_layer_.contents = (__bridge id)io_surface_.get();
|
||||
// Used for UMA
|
||||
tree()->changed_io_surfaces_during_commit_++;
|
||||
tree()->total_updated_io_surface_size_during_commit_ +=
|
||||
IOSurfaceGetAllocSize(io_surface_.get());
|
||||
} else if (solid_color_contents_) {
|
||||
ca_layer_.contents = solid_color_contents_->GetContents();
|
||||
} else {
|
||||
ca_layer_.contents = nil;
|
||||
}
|
||||
ca_layer_.contentsScale = tree()->scale_factor_;
|
||||
} else {
|
||||
// Used for UMA
|
||||
if (io_surface_)
|
||||
tree()->unchanged_io_surfaces_during_commit_++;
|
||||
}
|
||||
break;
|
||||
}
|
||||
|
Reference in New Issue
Block a user