Add a space after a colon in Gerrit-style git footer examples.
Follow up to https://crrev.com/747851 to provide good examples to readers in the documentation. Change-Id: I14e1aa32abce51c9ae1f7499737ff612e440733c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212962 Reviewed-by: Henrique Ferreiro <hferreiro@igalia.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#771201}
This commit is contained in:
docs
@ -65,8 +65,8 @@ To upload a change, use repo, something like this:
|
||||
```
|
||||
repo start <branch_name> .
|
||||
git commit -a
|
||||
Bug:chromium:12345
|
||||
Test:Write what you tested here
|
||||
Bug: chromium:12345
|
||||
Test: Write what you tested here
|
||||
repo upload .
|
||||
```
|
||||
|
||||
|
@ -101,8 +101,8 @@ To upload the change, use repo upload, something like this:
|
||||
|
||||
```
|
||||
git commit -a
|
||||
Bug:chromium:12345
|
||||
Test:Write what you tested here
|
||||
Bug: chromium:12345
|
||||
Test: Write what you tested here
|
||||
repo upload .
|
||||
```
|
||||
|
||||
|
@ -186,8 +186,8 @@ Otherwise the reviewer won't know to review the patch.
|
||||
* Add the reviewer's email address in the code review tool's reviewer field
|
||||
like normal.
|
||||
|
||||
* Add a line "Tbr:<reviewer's email>" to the bottom of the change list
|
||||
description. e.g. `Tbr:reviewer1@chromium.org,reviewer2@chromium.org`
|
||||
* Add a line "Tbr: <reviewer's email>" to the bottom of the change list
|
||||
description. e.g. `Tbr: reviewer1@chromium.org,reviewer2@chromium.org`
|
||||
|
||||
* Type a message so that the owners in the TBR list can understand who is
|
||||
responsible for reviewing what, as part of their post-commit review
|
||||
|
@ -57,10 +57,10 @@ whereas an entry disabling a benchmark on an entire platform might look like:
|
||||
## Submit changes
|
||||
|
||||
Once you've committed your changes locally, your CL can be submitted with:
|
||||
|
||||
- `No-Try:True`
|
||||
- `Tbr:`someone from [`tools/perf/OWNERS`](https://cs.chromium.org/chromium/src/tools/perf/OWNERS?q=tools/perf/owners&sq=package:chromium&dr)
|
||||
- `CC:`benchmark owner found in [this spreadsheet](https://docs.google.com/spreadsheets/u/1/d/1xaAo0_SU3iDfGdqDJZX_jRV0QtkufwHUKH3kQKF3YQs/edit#gid=0)
|
||||
|
||||
- `No-Try: True`
|
||||
- `Tbr: `someone from [`tools/perf/OWNERS`](https://cs.chromium.org/chromium/src/tools/perf/OWNERS?q=tools/perf/owners&sq=package:chromium&dr)
|
||||
- `CC: `benchmark owner found in [this spreadsheet](https://docs.google.com/spreadsheets/u/1/d/1xaAo0_SU3iDfGdqDJZX_jRV0QtkufwHUKH3kQKF3YQs/edit#gid=0)
|
||||
- `Bug: `tracking bug
|
||||
|
||||
*Please make sure to CC the benchmark owner so that they're aware that they've lost coverage.*
|
||||
|
Reference in New Issue
Block a user