chromium/src
0
Fork 0
Code Activity

media: Windows AV1 decoder leaks after calling CreateAV1Decoder()

Browse Source 
media\gpu\windows\dxva_video_decode_accelerator_win.cc!CreateAV1Decoder
uses MFTEnumEx() to get the Media Foundation AV1 video decoder for
decoding of AV1 video format. However, it leaks the |decoder_| because
it should free the array of |acts| after activating the AV1 decoder.

Bug: 1212789
Change-Id: I41d4a17a17963aa17d3abc8e9c0ed16cc59da1ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2914419
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Frank Li <frankli@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#886123}
This commit is contained in:
Frank Li
2021-05-25 00:23:06 +00:00
committed by Chromium LUCI CQ
parent ca7aef9492
commit 4144145bf5
1 changed files with 4 additions and 1 deletions

5
media/gpu/windows/dxva_video_decode_accelerator_win.cc

@ -159,7 +159,10 @@ HRESULT CreateAV1Decoder(const IID& iid, void** object) {
if (acts_num < 1)
return E_FAIL;
return acts[0]->ActivateObject(iid, object);
hr = acts[0]->ActivateObject(iid, object);
for (UINT32 i = 0; i < acts_num; ++i)
acts[i]->Release();
return hr;
}
uint64_t g_last_process_output_time;