chromium/src
0
Fork 0
Code Activity

[Sync] Enable SyncReuploadBookmarkFullTitles by default

Browse Source 
This CL also removes SyncReuploadBookmarkFullTitles from
fieldtrial_testing_config.json.

Some tests are fixed to pass at any state of the feature toggle
SyncReuploadBookmarkFullTitles.

Bug: 1061411
Change-Id: I021fd4eb170fbf132b51ffa7074f51c3d18a7a61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426703
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/master@{#811610}
This commit is contained in:
Rushan Suleymanov
2020-09-29 08:16:04 +00:00
committed by Commit Bot
parent 3f62e6f69b
commit 41da4b982a
3 changed files with 2 additions and 23 deletions

3
components/sync_bookmarks/bookmark_model_type_processor_unittest.cc

@ -263,10 +263,9 @@ class BookmarkModelTypeProcessorTest : public testing::Test {
}
sync_pb::BookmarkModelMetadata BuildBookmarkModelMetadataWithoutFullTitles() {
base::test::ScopedFeatureList features;
features.InitAndDisableFeature(switches::kSyncReuploadBookmarkFullTitles);
sync_pb::BookmarkModelMetadata model_metadata =
processor()->GetTrackerForTest()->BuildBookmarkModelMetadata();
model_metadata.clear_bookmarks_full_title_reuploaded();
return model_metadata;
}

2
components/sync_bookmarks/switches.cc

@ -10,7 +10,7 @@ const base::Feature kSyncDoNotCommitBookmarksWithoutFavicon = {
"SyncDoNotCommitBookmarksWithoutFavicon", base::FEATURE_ENABLED_BY_DEFAULT};
const base::Feature kSyncReuploadBookmarkFullTitles{
"SyncReuploadBookmarkFullTitles", base::FEATURE_DISABLED_BY_DEFAULT};
"SyncReuploadBookmarkFullTitles", base::FEATURE_ENABLED_BY_DEFAULT};
const base::Feature kSyncDeduplicateAllBookmarksWithSameGUID{
"SyncDeduplicateAllBookmarksWithSameGUID",

20
testing/variations/fieldtrial_testing_config.json

@ -6611,26 +6611,6 @@
]
}
],
"SyncReuploadBookmarkFullTitles": [
{
"platforms": [
"android",
"chromeos",
"ios",
"linux",
"mac",
"windows"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"SyncReuploadBookmarkFullTitles"
]
}
]
}
],
"SyncTriggerFullKeystoreMigration": [
{
"platforms": [