chromium/src
0
Fork 0
Code Activity

Remove super call in Tab*View onClick

Browse Source 
Bug: None
Change-Id: I41e195d83bdcc70f9778a9b57d511446ea067f0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5532603
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@google.com>
Cr-Commit-Position: refs/heads/main@{#1299630}
This commit is contained in:
Brandon Wylie
2024-05-11 00:41:33 +00:00
committed by Chromium LUCI CQ
parent 547dd45fbf
commit 4261421f19
4 changed files with 4 additions and 8 deletions
chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management
TabGridView.javaTabGridViewBinder.javaTabListView.javaTabListViewBinder.java

4
chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridView.java

@ -235,9 +235,7 @@ public class TabGridView extends SelectableItemViewBase<Integer> {
// SelectableItemViewBase implementation.
@Override
protected void onClick() {
super.onClick(this);
}
protected void onClick() {}
@Override
protected void updateView(boolean animate) {}

2
chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridViewBinder.java

@ -271,7 +271,7 @@ class TabGridViewBinder {
view.setOnClickListener(
v -> {
model.get(TabProperties.SELECTABLE_TAB_CLICKED_LISTENER).run(tabId);
((TabGridView) view).onClick();
((TabGridView) view).onClick(view);
});
view.setOnLongClickListener(
v -> {

4
chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabListView.java

@ -89,9 +89,7 @@ public class TabListView extends SelectableItemViewBase<Integer> {
// SelectableItemViewBase implementation.
@Override
protected void onClick() {
super.onClick(this);
}
protected void onClick() {}
@Override
protected void updateView(boolean animate) {}

2
chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabListViewBinder.java

@ -266,7 +266,7 @@ class TabListViewBinder {
View.OnClickListener onClickListener =
v -> {
model.get(TabProperties.SELECTABLE_TAB_CLICKED_LISTENER).run(tabId);
tabListView.onClick();
tabListView.onClick(tabListView);
};
View.OnLongClickListener onLongClickListener =
v -> {