chromium/src
0
Fork 0
Code Activity

sandbox_linux_unittests: Relax death test output expectation under UBSan

Browse Source 
Some SandboxBPF.* tests continuously shows test failures, which is
caused because UBSan shows alerts, and breaks the condition.
This CL exclude UBSan until an underlying issue has been fixed.

Bug: 375489584
Change-Id: Ia5a5934c718bbc6d37dc97190c3426bb22b6ee38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5960925
Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1373748}
This commit is contained in:
Yoshisato Yanagisawa
2024-10-25 06:15:31 +00:00
committed by Chromium LUCI CQ
parent 8905c987eb
commit 43b37ba87e
1 changed files with 2 additions and 1 deletions

3
sandbox/linux/tests/unit_tests.cc

@ -241,7 +241,8 @@ void UnitTests::DeathSuccess(int status, const std::string& msg, const void*) {
ASSERT_TRUE(subprocess_terminated_normally) << details;
int subprocess_exit_status = WEXITSTATUS(status);
ASSERT_EQ(kExpectedValue, subprocess_exit_status) << details;
#if !defined(LEAK_SANITIZER)
// TODO(crbug.com/375489584): re-enable the test for UBSan.
#if !defined(LEAK_SANITIZER) && !defined(UNDEFINED_SANITIZER)
// LSan may print warnings to stdout, breaking this expectation.
bool subprocess_exited_but_printed_messages = !msg.empty();
EXPECT_FALSE(subprocess_exited_but_printed_messages) << details;