chromium/src
0
Fork 0
Code Activity

WebSocket: Remove expired histograms

Browse Source 
Remove histograms Net.WebSocket.DataUse.Upstream and
Net.WebSocket.DataUse.Downstream from the code as they have expired.

Also mark histograms Net.WebSocket.ErrorCodes and
Net.WebSocket.HandshakeResult2 as never expiring as they continue to be
useful.

Change-Id: I87c7b9ffee94553b9d82d081f2ac814426302ac4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098196
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750027}
This commit is contained in:
Adam Rice
2020-03-13 03:19:54 +00:00
committed by Commit Bot
parent 77cb7c1e2a
commit 43d7c0efbe
2 changed files with 12 additions and 7 deletions
net/websockets
websocket_basic_stream.cc
tools/metrics/histograms
histograms.xml

5
net/websockets/websocket_basic_stream.cc

@ -13,7 +13,6 @@
#include "base/bind.h"
#include "base/command_line.h"
#include "base/logging.h"
#include "base/metrics/histogram_macros.h"
#include "base/numerics/safe_conversions.h"
#include "base/strings/string_number_conversions.h"
#include "build/build_config.h"
@ -280,7 +279,6 @@ int WebSocketBasicStream::WriteEverything(
base::Unretained(this), buffer),
kTrafficAnnotation);
if (result > 0) {
UMA_HISTOGRAM_COUNTS_100000("Net.WebSocket.DataUse.Upstream", result);
buffer->DidConsume(result);
} else {
return result;
@ -299,7 +297,6 @@ void WebSocketBasicStream::OnWriteComplete(
}
DCHECK_NE(0, result);
UMA_HISTOGRAM_COUNTS_100000("Net.WebSocket.DataUse.Upstream", result);
buffer->DidConsume(result);
result = WriteEverything(buffer);
@ -317,8 +314,6 @@ int WebSocketBasicStream::HandleReadResult(
if (result == 0)
return ERR_CONNECTION_CLOSED;
UMA_HISTOGRAM_COUNTS_100000("Net.WebSocket.DataUse.Downstream", result);
std::vector<std::unique_ptr<WebSocketFrameChunk>> frame_chunks;
if (!parser_.Decode(read_buffer_->data(), result, &frame_chunks))
return WebSocketErrorToNetError(parser_.websocket_error());

14
tools/metrics/histograms/histograms.xml

@ -95488,6 +95488,9 @@ uploading your change for review.
<histogram name="Net.WebSocket.DataUse.Downstream" units="bytes"
expires_after="M77">
<obsolete>
Removed in March 2020.
</obsolete>
<owner>rajendrant@chromium.org</owner>
<owner>bengr@chromium.org</owner>
<summary>
@ -95498,6 +95501,9 @@ uploading your change for review.
<histogram name="Net.WebSocket.DataUse.Upstream" units="bytes"
expires_after="M77">
<obsolete>
Removed in March 2020.
</obsolete>
<owner>rajendrant@chromium.org</owner>
<owner>bengr@chromium.org</owner>
<summary>
@ -95533,7 +95539,9 @@ uploading your change for review.
</histogram>
<histogram name="Net.WebSocket.ErrorCodes" enum="NetErrorCodes"
expires_after="M85">
expires_after="never">
<!-- expires-never: needed for long-term tracking of ecosystem -->
<owner>yhirano@chromium.org</owner>
<owner>ricea@chromium.org</owner>
<summary>
@ -95555,7 +95563,9 @@ uploading your change for review.
</histogram>
<histogram name="Net.WebSocket.HandshakeResult2"
enum="WebSocketHandshakeResult2" expires_after="M85">
enum="WebSocketHandshakeResult2" expires_after="never">
<!-- expires-never: needed for long-term tracking of ecosystem -->
<owner>yhirano@chromium.org</owner>
<owner>ricea@chromium.org</owner>
<owner>src/net/OWNERS</owner>