chromium/src
0
Fork 0
Code Activity

Remove unnecessary IF NOT EXISTS clause from DB migration

Browse Source 
Same reasoning as in crrev.com/c/3891592: If the table already exists,
then the subsequent operations using it are going to fail anyway.

Change-Id: I78594a0e09fea7235488d1304dee9dfe26038176
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4013563
Reviewed-by: Nan Lin <linnan@chromium.org>
Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org>
Quick-Run: Andrew Paseltiner <apaseltiner@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1068686}
This commit is contained in:
Andrew Paseltiner
2022-11-08 18:58:40 +00:00
committed by Chromium LUCI CQ
parent 67c6e45755
commit 442bdbf9ed
1 changed files with 2 additions and 2 deletions

4
content/browser/attribution_reporting/attribution_storage_sql_migrations.cc

@ -233,8 +233,8 @@ bool MigrateToVersion37(sql::Database* db, sql::MetaTable* meta_table) {
return false;
static constexpr char kNewDedupKeyTableSql[] =
"CREATE TABLE IF NOT EXISTS new_dedup_keys"
"(source_id INTEGER NOT NULL,"
"CREATE TABLE new_dedup_keys("
"source_id INTEGER NOT NULL,"
"report_type INTEGER NOT NULL,"
"dedup_key INTEGER NOT NULL,"
"PRIMARY KEY(source_id,report_type,dedup_key))WITHOUT ROWID";