Fix checkperms.py error in PRESUBMIT

If the permissions are wrong for a file (for example:
tools/grit/minify_with_uglify_unittest.py is 644 instead of 755) and you
run `git cl presubmit` it will no longer fail. This failure is a python3
issue with subprocess returning binary arrays instead of strings.

Bug: 1221378
Change-Id: I30a9d4f8ae649415f236863dfe2199961083e76d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2972103
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#893689}

This commit is contained in:

Ari Chivukula

2021-06-18 04:23:04 +00:00

committed by

Chromium LUCI CQ

parent dde681f047

commit 45f58dd539

1 changed files with 1 additions and 1 deletions

									
										2

PRESUBMIT.py
									
				@ -1853,7 +1853,7 @@ def CheckFilePermissions(input_api, output_api):

				    except input_api.subprocess.CalledProcessError as error:

				      return [output_api.PresubmitError(

				          'checkperms.py failed:',

				          long_text=error.output)]

				          long_text=error.output.decode('utf-8', 'ignore'))]

				def CheckNoAuraWindowPropertyHInHeaders(input_api, output_api):

Fix checkperms.py error in PRESUBMIT

2 PRESUBMIT.py

2

PRESUBMIT.py