chromium/src
0
Fork 0
Code Activity

[CodeHealth] Remove expired Rlz.SetRlzPingSent histogram

Browse Source 
As a part of the CodeHealthRotation, this CL removes the expired
histograms.

OBSOLETE_HISTOGRAM[Rlz.SetRlzPingSent]=The histogram was expired as of M85.

Bug: 1499476
Change-Id: I4ca413b7432c2bc0fee6b34b0d2291879c0c047a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5043670
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1227748}
This commit is contained in:
Minoru Chikamune
2023-11-22 02:11:36 +00:00
committed by Chromium LUCI CQ
parent c8133b3cf8
commit 467ae0cbba
2 changed files with 0 additions and 11 deletions
rlz/chromeos/lib
rlz_value_store_chromeos.cc
tools/metrics/histograms/metadata/others
histograms.xml

3
rlz/chromeos/lib/rlz_value_store_chromeos.cc

@ -18,7 +18,6 @@
#include "base/lazy_instance.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h"
#include "base/metrics/histogram_macros.h"
#include "base/path_service.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_piece.h"
@ -142,12 +141,10 @@ void SetRlzPingSent(int retry_count) {
// Callback invoked for DebugDaemonClient::SetRlzPingSent.
void OnSetRlzPingSent(int retry_count, bool success) {
if (success) {
UMA_HISTOGRAM_BOOLEAN("Rlz.SetRlzPingSent", true);
return;
}
if (retry_count >= RlzValueStoreChromeOS::kMaxRetryCount) {
UMA_HISTOGRAM_BOOLEAN("Rlz.SetRlzPingSent", false);
LOG(ERROR) << "Setting " << ash::system::kShouldSendRlzPingKey
<< " failed after " << RlzValueStoreChromeOS::kMaxRetryCount
<< " attempts.";

8
tools/metrics/histograms/metadata/others/histograms.xml

@ -8551,14 +8551,6 @@ chromium-metrics-reviews@google.com.
</summary>
</histogram>
<histogram name="Rlz.SetRlzPingSent" enum="BooleanSuccess" expires_after="M85">
<owner>wzang@chromium.org</owner>
<summary>
Record if updating |should_send_rlz_ping| in RW_VPD is successful within the
maximum retry counts.
</summary>
</histogram>
<histogram name="Rollback.OobeRestoreResult" enum="Rollback_OobeRestoreResult"
expires_after="2023-11-30">
<owner>mpolzer@google.com</owner>