chromium/src
0
Fork 0
Code Activity

Clear local variable references from ProofVerifierChromiumTest members

Browse Source 
The member variables contain objects with raw_ptr<>s back to stack
variables that have gone out-of-scope, and can will trigger dangling
pointer warnings.

Bug: 1401495
Change-Id: Ic096503767d17a1bffa6d5340fc03f1514e21ab4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4182682
Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1095878}
This commit is contained in:
Tom Sepez
2023-01-23 22:56:12 +00:00
committed by Chromium LUCI CQ
parent 80504e3034
commit 46b4fc1e40
1 changed files with 6 additions and 0 deletions

6
net/quic/crypto/proof_verifier_chromium_test.cc

@ -723,6 +723,8 @@ TEST_F(ProofVerifierChromiumTest, PKPReport) {
EXPECT_EQ(report_uri, report_sender.latest_report_uri());
EXPECT_EQ(network_anonymization_key,
report_sender.latest_network_anonymization_key());
transport_security_state_.SetReportSender(nullptr);
}
// Test that when CT is required (in this case, by the delegate), the
@ -775,6 +777,8 @@ TEST_F(ProofVerifierChromiumTest, CTIsRequired) {
verify_details = static_cast<ProofVerifyDetailsChromium*>(details_.get());
EXPECT_TRUE(verify_details->cert_verify_result.cert_status &
CERT_STATUS_CERTIFICATE_TRANSPARENCY_REQUIRED);
transport_security_state_.SetRequireCTDelegate(nullptr);
}
// Test that CT is considered even when PKP fails.
@ -838,6 +842,8 @@ TEST_F(ProofVerifierChromiumTest, PKPAndCTBothTested) {
CERT_STATUS_PINNED_KEY_MISSING);
EXPECT_TRUE(verify_details->cert_verify_result.cert_status &
CERT_STATUS_CERTIFICATE_TRANSPARENCY_REQUIRED);
transport_security_state_.SetRequireCTDelegate(nullptr);
}
TEST_F(ProofVerifierChromiumTest, UnknownRootRejected) {