chromium/src
0
Fork 0
Code Activity

Revert "[Mall] Enable feature by default"

Browse Source 
This reverts commit 39d6e986aa.

Reason for revert: Regresses Gemini app positioning, see b/398755364

Original change's description:
> [Mall] Enable feature by default
>
> Bug: b/397530175
> Change-Id: I005ea6d164ff5c849a7f01e291487f62e57f38bc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6278262
> Reviewed-by: Alan Cutter <alancutter@chromium.org>
> Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1423742}

Bug: b/397530175
Change-Id: I9d503ada926aa296bbb747829ed589fc6cf81e7f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6300795
Auto-Submit: David Black <dmblack@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1424161}
This commit is contained in:
David Black
2025-02-24 14:25:08 -08:00
committed by Chromium LUCI CQ
parent 4318826ffc
commit 46f365295a
2 changed files with 32 additions and 1 deletions
chromeos/constants
chromeos_features.cc
testing/variations
fieldtrial_testing_config.json

2
chromeos/constants/chromeos_features.cc

@ -62,7 +62,7 @@ BASE_FEATURE(kCrosComponents,
// Enables an app to discover and install other apps. This flag will be enabled
// with Finch.
BASE_FEATURE(kCrosMall, "CrosMall", base::FEATURE_ENABLED_BY_DEFAULT);
BASE_FEATURE(kCrosMall, "CrosMall", base::FEATURE_DISABLED_BY_DEFAULT);
// Enables the Mall app for managed users. Only has an effect when kCrosMall is
// also enabled.

31
testing/variations/fieldtrial_testing_config.json

@ -775,6 +775,37 @@
]
}
],
"AppMallStudy": [
{
"platforms": [
"chromeos"
],
"experiments": [
{
"name": "Enabled_20241010",
"enable_features": [
"CrosMall",
"CrosMallSwa"
]
},
{
"name": "Enabled",
"enable_features": [
"AppInstallServiceUri",
"CrosMall"
]
},
{
"name": "Enabled_20240619",
"enable_features": [
"AppInstallServiceUri",
"CrosMall",
"CrosMallSwa"
]
}
]
}
],
"AppStreamingAccessibilityIntegration": [
{
"platforms": [