[BabelOrca] Add filter to receive only group messages.
This will filter out status messages sent from the backend. Bug: b:405454423 Change-Id: I89092bb6dd6d380d3c30e44987df5c6e25962b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6427465 Commit-Queue: Ahmed Nasr <anasr@google.com> Reviewed-by: Vignesh Shenvi <vshenvi@google.com> Cr-Commit-Position: refs/heads/main@{#1441695}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
4e0138e72a
commit
4a0f290391
chromeos/ash/components/boca/babelorca
@@ -37,6 +37,10 @@ message InboxMessage {
|
||||
MessageClass message_class = 5;
|
||||
}
|
||||
|
||||
message PullOptions {
|
||||
repeated InboxMessage.MessageType message_types = 2;
|
||||
}
|
||||
|
||||
message InboxSendRequest {
|
||||
Id dest_id = 1;
|
||||
InboxMessage message = 2;
|
||||
@@ -60,6 +64,7 @@ message SignInGaiaResponse {
|
||||
|
||||
message ReceiveMessagesRequest {
|
||||
RequestHeader header = 1;
|
||||
PullOptions initial_pull_options = 4;
|
||||
}
|
||||
|
||||
message ReceiveMessagesResponse {
|
||||
|
@@ -102,6 +102,8 @@ void TranscriptReceiver::StartReceivingInternal() {
|
||||
*request.mutable_header() = GetRequestHeaderTemplate();
|
||||
request.mutable_header()->set_auth_token_payload(
|
||||
request_data_provider_->tachyon_token().value());
|
||||
request.mutable_initial_pull_options()->add_message_types(
|
||||
InboxMessage::GROUP);
|
||||
std::unique_ptr<RequestDataWrapper> request_data =
|
||||
std::make_unique<RequestDataWrapper>(
|
||||
kTrafficAnnotation, kReceiveMessagesUrl, /*max_retries=*/0,
|
||||
|
@@ -347,7 +347,7 @@ TEST_F(TranscriptReceiverTest, NewRequestResetsTranscriptBuilder) {
|
||||
EXPECT_TRUE(result_future.IsEmpty());
|
||||
}
|
||||
|
||||
TEST_F(TranscriptReceiverTest, RequestHasTachyonToken) {
|
||||
TEST_F(TranscriptReceiverTest, RequestFieldsSet) {
|
||||
ReceiveMessagesRequest request;
|
||||
|
||||
receiver_->StartReceiving(base::DoNothing(), base::DoNothing());
|
||||
@@ -355,6 +355,9 @@ TEST_F(TranscriptReceiverTest, RequestHasTachyonToken) {
|
||||
ASSERT_TRUE(request.ParseFromString(authed_client_ptr_->GetRequestString()));
|
||||
EXPECT_EQ(request.header().auth_token_payload(),
|
||||
data_provider_.tachyon_token().value());
|
||||
ASSERT_EQ(request.initial_pull_options().message_types().size(), 1);
|
||||
EXPECT_EQ(request.initial_pull_options().message_types()[0],
|
||||
InboxMessage::GROUP);
|
||||
}
|
||||
|
||||
struct TranscriptReceiverMissingDataTestCase {
|
||||
|
Reference in New Issue
Block a user