[GridNG] Synthesized baseline test updates
This change updates several CSS Grid alignment tests that were written under the expectation that synthesized baselines could participate in a baseline sharing group with vertical-RL aligned items. The CSS alignment spec spec at https://www.w3.org/TR/css-align-3/#baseline-export, states "Otherwise, assume either horizontal-tb or vertical-lr writing-mode, whichever is orthogonal to the box’s own writing-mode.", which indicates that a synthesized baseline should not be assumed to ever have vertical-rl alignment, and thus shouldn't be in a baseline sharing group with other vertical-rl items, as these tests were expecting. This change also updates TestExpectations to move the SVG aspect ratio tests that are currently marked as failing under GridNG to their own section, as well as marking the CSS Grid align-content tests as 'fail', so they are marked as failures under both grid and GridNG. Bug: 1045599 Change-Id: I052da46e1944c4b53eac15a11e9dadb09b669a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2911520 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by: Daniel Libby <dlibby@microsoft.com> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#885844}
This commit is contained in:
Kurt Catti-Schmidt (SCHMIDT)
committed by
Chromium LUCI CQ
Chromium LUCI CQ
parent
c75cd0f2b9
commit
4a90e1f50c
third_party/blink/web_tests
28
third_party/blink/web_tests/TestExpectations
vendored
28
third_party/blink/web_tests/TestExpectations
vendored
@ -3648,7 +3648,11 @@ crbug.com/1045599 external/wpt/css/css-grid/alignment/grid-alignment-implies-siz
|
||||
crbug.com/1045599 external/wpt/css/css-grid/alignment/grid-alignment-implies-size-change-036.html [ Failure ]
|
||||
crbug.com/1045599 external/wpt/css/css-grid/alignment/grid-baseline-004.html [ Failure ]
|
||||
crbug.com/941987 external/wpt/css/css-grid/alignment/grid-baseline-align-cycles-001.html [ Failure ]
|
||||
crbug.com/1045599 external/wpt/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-001.html [ Failure ]
|
||||
crbug.com/1045599 external/wpt/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-002.html [ Failure ]
|
||||
crbug.com/1045599 external/wpt/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-003.html [ Failure ]
|
||||
crbug.com/1045599 external/wpt/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-016.html [ Failure ]
|
||||
crbug.com/1045599 external/wpt/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-002.html [ Failure ]
|
||||
crbug.com/1045599 external/wpt/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-001.html [ Failure ]
|
||||
crbug.com/1045599 external/wpt/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-002.html [ Failure ]
|
||||
crbug.com/1171262 external/wpt/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-006.html [ Failure ]
|
||||
@ -3687,6 +3691,12 @@ crbug.com/1114013 external/wpt/css/css-grid/alignment/grid-item-no-aspect-ratio-
|
||||
crbug.com/1114013 external/wpt/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-9.html [ Failure ]
|
||||
crbug.com/1114013 external/wpt/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-10.html [ Failure ]
|
||||
|
||||
# Open discussion of SVG aspect ratios at https://github.com/w3c/csswg-drafts/issues/6286
|
||||
crbug.com/1045599 virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-4.html [ Failure ]
|
||||
crbug.com/1045599 virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-5.html [ Failure ]
|
||||
crbug.com/1045599 virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-6.html [ Failure ]
|
||||
crbug.com/1045599 virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-7.html [ Failure ]
|
||||
|
||||
# The 'last baseline' keyword is not implemented yet
|
||||
crbug.com/885175 external/wpt/css/css-grid/alignment/grid-item-self-baseline-001.html [ Skip ]
|
||||
crbug.com/885175 external/wpt/css/css-grid/alignment/grid-self-alignment-baseline-with-grid-001.html [ Skip ]
|
||||
@ -3727,8 +3737,8 @@ crbug.com/764235 external/wpt/css/css-grid/alignment/grid-item-mixed-baseline-00
|
||||
crbug.com/764235 external/wpt/css/css-grid/alignment/grid-item-mixed-baseline-002.html [ Skip ]
|
||||
crbug.com/764235 external/wpt/css/css-grid/alignment/grid-item-mixed-baseline-003.html [ Skip ]
|
||||
crbug.com/764235 external/wpt/css/css-grid/alignment/grid-item-mixed-baseline-004.html [ Skip ]
|
||||
crbug.com/764235 external/wpt/css/css-grid/alignment/grid-baseline-align-001.html [ Skip ]
|
||||
crbug.com/764235 external/wpt/css/css-grid/alignment/grid-baseline-justify-001.html [ Skip ]
|
||||
crbug.com/764235 external/wpt/css/css-grid/alignment/grid-baseline-align-001.html [ Failure ]
|
||||
crbug.com/764235 external/wpt/css/css-grid/alignment/grid-baseline-justify-001.html [ Failure ]
|
||||
|
||||
# Subgrid is not implemented yet
|
||||
crbug.com/618969 external/wpt/css/css-grid/subgrid/* [ Skip ]
|
||||
@ -3755,6 +3765,10 @@ virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-alignment-implie
|
||||
virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-alignment-implies-size-change-035.html [ Pass ]
|
||||
virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-alignment-implies-size-change-036.html [ Pass ]
|
||||
virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-baseline-004.html [ Pass ]
|
||||
virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-001.html [ Pass ]
|
||||
virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-002.html [ Pass ]
|
||||
virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-003.html [ Pass ]
|
||||
virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-002.html [ Pass ]
|
||||
virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-016.html [ Pass ]
|
||||
virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-001.html [ Pass ]
|
||||
virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-002.html [ Pass ]
|
||||
@ -3788,19 +3802,9 @@ virtual/layout-ng-grid/fast/css-grid-layout/maximize-tracks-definite-indefinite-
|
||||
|
||||
### Tests failing with LayoutNGGrid enabled:
|
||||
crbug.com/1045599 virtual/layout-ng-grid/external/wpt/css/css-grid/abspos/grid-abspos-staticpos-align-self-safe-001.html [ Failure ]
|
||||
crbug.com/1045599 virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-baseline-align-001.html [ Failure ]
|
||||
crbug.com/1045599 virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-baseline-align-cycles-001.html [ Failure ]
|
||||
crbug.com/1045599 virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-baseline-justify-001.html [ Failure ]
|
||||
crbug.com/1045599 virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-content-alignment-overflow-001.html [ Failure ]
|
||||
crbug.com/1045599 virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-4.html [ Failure ]
|
||||
crbug.com/1045599 virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-5.html [ Failure ]
|
||||
crbug.com/1045599 virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-6.html [ Failure ]
|
||||
crbug.com/1045599 virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-7.html [ Failure ]
|
||||
crbug.com/1045599 virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-001.html [ Failure ]
|
||||
crbug.com/1045599 virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-002.html [ Failure ]
|
||||
crbug.com/1045599 virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-003.html [ Failure Crash ]
|
||||
crbug.com/1045599 virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-004.html [ Failure ]
|
||||
crbug.com/1045599 virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-002.html [ Failure ]
|
||||
crbug.com/1045599 virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-003.html [ Failure ]
|
||||
crbug.com/1045599 virtual/layout-ng-grid/external/wpt/css/css-grid/layout-algorithm/grid-intrinsic-size-with-orthogonal-items.html [ Failure ]
|
||||
crbug.com/1045599 virtual/layout-ng-grid/fast/css-grid-layout/percent-padding-margin-resolution-grid-item-update.html [ Failure ]
|
||||
|
||||
@ -37,10 +37,10 @@
|
||||
</script>
|
||||
<body onload="document.fonts.ready.then(() => { checkLayout('.grid'); })">
|
||||
|
||||
<pre>Horizontal grid and verticalRL item</pre>
|
||||
<pre>Horizontal grid and verticalRL items do not share a baseline context</pre>
|
||||
|
||||
<div class="grid width300 justifyItemsBaseline">
|
||||
<div class="firstRowFirstColumn" data-offset-x="60" data-offset-y="0" data-expected-width="200" data-expected-height="100">ÉÉ É ÉÉÉ É ÉÉ É</div>
|
||||
<div class="firstRowFirstColumn" data-offset-x="0" data-offset-y="0" data-expected-width="200" data-expected-height="100">ÉÉ É ÉÉÉ É ÉÉ É</div>
|
||||
<div class="secondRowFirstColumn bigFont paddingRight verticalRL" data-offset-x="0" data-offset-y="100" data-expected-width="125" data-expected-height="200">É É ÉÉ</div>
|
||||
<div class="autoRowSpanning2AutoColumn width25"></div>
|
||||
</div>
|
||||
@ -61,7 +61,7 @@
|
||||
<div class="autoRowSpanning2AutoColumn height25"></div>
|
||||
</div>
|
||||
|
||||
<pre>VerticalLR grid and Horizontal item</pre>
|
||||
<pre>VerticalRL grid and Horizontal item</pre>
|
||||
|
||||
<div class="grid justifyItemsBaseline verticalRL">
|
||||
<div class="firstRowFirstColumn" data-offset-x="200" data-offset-y="0" data-expected-width="100" data-expected-height="200">ÉÉ É ÉÉÉ É ÉÉ É</div>
|
||||
|
||||
@ -48,10 +48,10 @@
|
||||
<div class="autoRowSpanning2AutoColumn width25"></div>
|
||||
</div>
|
||||
|
||||
<pre>Horizontal grid and verticalRL item with fixed width</pre>
|
||||
<pre>Horizontal grid and verticalRL item with fixed width do not share a baseline context</pre>
|
||||
|
||||
<div class="grid width300 justifyItemsBaseline">
|
||||
<div class="firstRowFirstColumn fixedWidth" data-offset-x="60" data-offset-y="0" data-expected-width="125" data-expected-height="100"></div>
|
||||
<div class="firstRowFirstColumn fixedWidth" data-offset-x="0" data-offset-y="0" data-expected-width="125" data-expected-height="100"></div>
|
||||
<div class="secondRowFirstColumn bigFont paddingRight verticalRL" data-offset-x="0" data-offset-y="100" data-expected-width="120" data-expected-height="200">É É ÉÉ</div>
|
||||
<div class="autoRowSpanning2AutoColumn width25"></div>
|
||||
</div>
|
||||
|
||||
@ -48,10 +48,10 @@
|
||||
<div class="autoRowSpanning2AutoColumn width25"></div>
|
||||
</div>
|
||||
|
||||
<pre>Horizontal grid and verticalRL item with relative width</pre>
|
||||
<pre>Horizontal grid and verticalRL item with relative width do not share a baseline context</pre>
|
||||
|
||||
<div class="grid width300 justifyItemsBaseline">
|
||||
<div class="firstRowFirstColumn relativeWidth" data-offset-x="60" data-offset-y="0" data-expected-width="100" data-expected-height="100"></div>
|
||||
<div class="firstRowFirstColumn relativeWidth" data-offset-x="00" data-offset-y="0" data-expected-width="100" data-expected-height="100"></div>
|
||||
<div class="secondRowFirstColumn bigFont paddingRight verticalRL" data-offset-x="0" data-offset-y="100" data-expected-width="120" data-expected-height="200">É É ÉÉ</div>
|
||||
<div class="autoRowSpanning2AutoColumn width25"></div>
|
||||
</div>
|
||||
|
||||
@ -188,6 +188,7 @@
|
||||
</div>
|
||||
|
||||
<pre>auto-sized rows - verticalRL grid and horizontal item - column-axis baseline</pre>
|
||||
<pre>baseline alignment is not supported, because the RL items do not share an alignment context with the LR items</pre>
|
||||
<div class="inline-grid verticalRL alignItemsBaseline columns width200">
|
||||
<div class="firstRowFirstColumn bigFont paddingLeft" data-offset-x="125" data-offset-y="0" data-expected-width="75" data-expected-height="100">É</div>
|
||||
<div class="firstRowSecondColumn horizontalTB" data-offset-x="25" data-offset-y="100" data-expected-width="175" data-expected-height="100">ÉÉ É ÉÉ ÉÉÉÉ É ÉÉ ÉÉÉ ÉÉ É</div>
|
||||
@ -195,6 +196,7 @@
|
||||
</div>
|
||||
|
||||
<pre>min-content-sized rows - verticalRL grid and horizontal item - column-axis baseline</pre>
|
||||
<pre>baseline alignment is not supported, because the RL items do not share an alignment context with the LR items</pre>
|
||||
<div class="inline-grid verticalRL alignItemsBaseline columns min-content-rows">
|
||||
<div class="firstRowFirstColumn bigFont paddingLeft" data-offset-x="25" data-offset-y="0" data-expected-width="75" data-expected-height="100">É</div>
|
||||
<div class="firstRowSecondColumn horizontalTB" data-offset-x="25" data-offset-y="100" data-expected-width="75" data-expected-height="100">ÉÉ É ÉÉ ÉÉÉÉ É ÉÉ ÉÉÉ ÉÉ É</div>
|
||||
@ -202,6 +204,7 @@
|
||||
</div>
|
||||
|
||||
<pre>max-content-sized rows - verticalRL grid and horizontal item - column-axis baseline</pre>
|
||||
<pre>baseline alignment is not supported, because the RL items do not share an alignment context with the LR items</pre>
|
||||
<div class="inline-grid verticalRL alignItemsBaseline columns max-content-rows">
|
||||
<div class="firstRowFirstColumn bigFont paddingLeft" data-offset-x="366" data-offset-y="0" data-expected-width="75" data-expected-height="100">É</div>
|
||||
<div class="firstRowSecondColumn horizontalTB" data-offset-x="25" data-offset-y="100" data-expected-width="416" data-expected-height="100">ÉÉ É ÉÉ ÉÉÉÉ É ÉÉ ÉÉÉ ÉÉ É</div>
|
||||
@ -209,6 +212,7 @@
|
||||
</div>
|
||||
|
||||
<pre>fit-content-sized rows - verticalRL grid and horizontal item - column-axis baseline</pre>
|
||||
<pre>baseline alignment is not supported, because the RL items do not share an alignment context with the LR items</pre>
|
||||
<div class="inline-grid verticalRL alignItemsBaseline auto-columns fit-content-rows">
|
||||
<div class="firstRowFirstColumn bigFont paddingLeft" data-offset-x="366" data-offset-y="0" data-expected-width="75" data-expected-height="50">É</div>
|
||||
<div class="firstRowSecondColumn horizontalTB" data-offset-x="25" data-offset-y="50" data-expected-width="416" data-expected-height="100">ÉÉ É ÉÉ ÉÉÉÉ É ÉÉ ÉÉÉ ÉÉ É</div>
|
||||
@ -216,16 +220,17 @@
|
||||
</div>
|
||||
|
||||
<pre>flex-sized rows - verticalRL grid and horizontal item - column-axis baseline</pre>
|
||||
<pre>baseline alignment is not supported, because the RL items do not share an alignment context with the LR items</pre>
|
||||
<div class="inline-grid verticalRL alignItemsBaseline auto-columns flex-rows">
|
||||
<div class="firstRowFirstColumn bigFont paddingLeft" data-offset-x="366" data-offset-y="0" data-expected-width="75" data-expected-height="50">É</div>
|
||||
<div class="firstRowSecondColumn horizontalTB" data-offset-x="25" data-offset-y="50" data-expected-width="416" data-expected-height="100">ÉÉ É ÉÉ ÉÉÉÉ É ÉÉ ÉÉÉ ÉÉ É</div>
|
||||
<div class="autoRowAutoColumnSpanning2 width25" data-offset-x="0" data-offset-y="0" data-expected-width="25" data-expected-height="150"></div>
|
||||
</div>
|
||||
|
||||
<pre>max-flex-sized rows - verticalRL grid and horizontal item - column-axis baseline<br>baseline is not applied initially, but orthogonal items force repeating the track sizing and height is not indefinite in that phase.</pre>
|
||||
<!-- https://github.com/w3c/csswg-drafts/issues/3046 -->
|
||||
<pre>max-flex-sized rows - verticalRL grid and horizontal item - column-axis baseline</pre>
|
||||
<pre>baseline alignment is not supported, because the RL items do not share an alignment context with the LR items</pre>
|
||||
<div class="inline-grid verticalRL alignItemsBaseline auto-columns max-flex-rows">
|
||||
<div class="firstRowFirstColumn bigFont paddingLeft" data-offset-x="-10" data-offset-y="0" data-expected-width="75" data-expected-height="50">É</div>
|
||||
<div class="firstRowFirstColumn bigFont paddingLeft" data-offset-x="366" data-offset-y="0" data-expected-width="75" data-expected-height="50">É</div>
|
||||
<div class="firstRowSecondColumn horizontalTB" data-offset-x="25" data-offset-y="50" data-expected-width="416" data-expected-height="100">ÉÉ É ÉÉ ÉÉÉÉ É ÉÉ ÉÉÉ ÉÉ É</div>
|
||||
<div class="autoRowAutoColumnSpanning2 width25" data-offset-x="0" data-offset-y="0" data-expected-width="25" data-expected-height="150"></div>
|
||||
</div>
|
||||
|
||||
Reference in New Issue
Block a user