chromium/src
0
Fork 0
Code Activity

Default enable select option and maxlength crowdsourcing

Browse Source 
Permission was given in today's feature sync.

Bug: 393995180, 393999140
Change-Id: Ia44cdbe4353ae6c10bd090501351d462e089b94d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6375289
Reviewed-by: Christoph Schwering <schwering@google.com>
Commit-Queue: Christoph Schwering <schwering@google.com>
Auto-Submit: Jan Keitel <jkeitel@google.com>
Cr-Commit-Position: refs/heads/main@{#1435446}
This commit is contained in:
Jan Keitel
2025-03-20 08:49:42 -07:00
committed by Chromium LUCI CQ
parent 6b97aaf967
commit 4cde01bb24
2 changed files with 4 additions and 44 deletions
components/autofill/core/common
autofill_features.cc
testing/variations
fieldtrial_testing_config.json

8
components/autofill/core/common/autofill_features.cc

@ -357,17 +357,17 @@ const base::FeatureParam<bool>
"autofill_improved_labels_with_differentiating_labels_in_front", false};
// If enabled, we include a `FormFieldData`'s maxlength in crowdsourcing votes.
// TODO(crbug.com/393995180): Clean up when launched.
// TODO(crbug.com/393995180): Clean up in M137.
BASE_FEATURE(kAutofillIncludeMaxLengthInCrowdsourcing,
"AutofillIncludeMaxLengthInCrowdsourcing",
base::FEATURE_DISABLED_BY_DEFAULT);
base::FEATURE_ENABLED_BY_DEFAULT);
// If enabled, we include a <select>'s first, second, and last <option> in
// crowdsourcing votes.
// TODO(crbug.com/393999140): Clean up when launched.
// TODO(crbug.com/393999140): Clean up in M137.
BASE_FEATURE(kAutofillIncludeSelectOptionsInCrowdsourcing,
"AutofillIncludeSelectOptionsInCrowdsourcing",
base::FEATURE_DISABLED_BY_DEFAULT);
base::FEATURE_ENABLED_BY_DEFAULT);
// If enabled, we include a `FormData`'s URL in crowdsourcing votes.
// TODO(crbug.com/385043924): Clean up in M137.

40
testing/variations/fieldtrial_testing_config.json

@ -2268,46 +2268,6 @@
]
}
],
"AutofillIncludeMaxLengthInCrowdsourcing": [
{
"platforms": [
"android",
"chromeos",
"linux",
"ios",
"mac",
"windows"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"AutofillIncludeMaxLengthInCrowdsourcing"
]
}
]
}
],
"AutofillIncludeSelectOptionsInCrowdsourcing": [
{
"platforms": [
"android",
"chromeos",
"linux",
"ios",
"mac",
"windows"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"AutofillIncludeSelectOptionsInCrowdsourcing"
]
}
]
}
],
"AutofillInferLabelFromDefaultSelectText": [
{
"platforms": [