chromium/src
0
Fork 0
Code Activity

DanglingPtr: Mark all of them as untriaged [14/N]

Browse Source 
This patch is a no-op with all the common build flags.

Add the "DanglingUntriaged" raw_ptr annotation. It indicates a raw_ptr
becomes dangling, and it should be triaged/fixed. This will also disable
dangling detection for those pointers, once enabled.

These were identified by running the mac-rel CQ bot with DPD
activated (both build + runtime here: https://crrev.com/c/3941825)

Bug: 1291138
Change-Id: I85e25473bf91cda27538d2b2ca713634cdef3deb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4083641
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Owners-Override: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Ali Hijazi <ahijazi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1080242}
This commit is contained in:
Ali Hijazi
2022-12-07 09:31:40 +00:00
committed by Chromium LUCI CQ
parent aac0ff491f
commit 4dc9ba21b5
2 changed files with 3 additions and 3 deletions
gpu/command_buffer/client
query_tracker.h
net/http
http_request_info.h

4
gpu/command_buffer/client/query_tracker.h

@ -58,10 +58,10 @@ class GLES2_IMPL_EXPORT QuerySyncManager {
: bucket(bucket), sync(bucket->syncs + index) {}
QueryInfo() = default;
uint32_t index() const { return sync - bucket->syncs; }
uint32_t index() const { return sync - bucket->syncs.get(); }
raw_ptr<Bucket, DanglingUntriaged> bucket = nullptr;
raw_ptr<QuerySync> sync = nullptr;
raw_ptr<QuerySync, DanglingUntriaged> sync = nullptr;
int32_t submit_count = 0;
};

2
net/http/http_request_info.h

@ -57,7 +57,7 @@ struct NET_EXPORT HttpRequestInfo {
HttpRequestHeaders extra_headers;
// Any upload data.
raw_ptr<UploadDataStream> upload_data_stream = nullptr;
raw_ptr<UploadDataStream, DanglingUntriaged> upload_data_stream = nullptr;
// Any load flags (see load_flags.h).
int load_flags = 0;