chromium/src
0
Fork 0
Code Activity

Updater: Rename Last Update Check Error protocol fields for consistency.

Browse Source 
This makes the names consistent with other fields used to report errors elsewhere in the protocol.

Also, propagate the protocol additions to the version 4 protocol.

Change-Id: I32511393f36150770974c8762764e375ad4d08ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5835647
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Noah Rose Ledesma <noahrose@google.com>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Noah Rose Ledesma <noahrose@google.com>
Auto-Submit: Noah Anderson <noahanderson@google.com>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Noah Anderson <noahanderson@google.com>
Cr-Commit-Position: refs/heads/main@{#1350933}
This commit is contained in:
Noah Anderson
2024-09-04 18:04:01 +00:00
committed by Chromium LUCI CQ
parent c50eba5e17
commit 4ea9ab1450
3 changed files with 13 additions and 8 deletions
chrome/browser/component_updater
updater_state.cc
docs/updater
protocol_3_1.mdprotocol_4.md

7
chrome/browser/component_updater/updater_state.cc

@ -217,10 +217,11 @@ UpdaterState::Attributes UpdaterState::Serialize() const {
state_->is_autoupdate_check_enabled ? "1" : "0";
attributes["updatepolicy"] = base::NumberToString(state_->update_policy);
attributes["lastupdatecheckerror"] = state_->last_update_check_error.code_;
attributes["lastupdatecheckerrorcategory"] =
attributes["lastupdatecheckerrorcode"] =
state_->last_update_check_error.code_;
attributes["lastupdatecheckerrorcat"] =
static_cast<int>(state_->last_update_check_error.category_);
attributes["lastupdatecheckerrorextracode1"] =
attributes["lastupdatecheckextracode1"] =
state_->last_update_check_error.extra_;
}

8
docs/updater/protocol_3_1.md

@ -497,13 +497,11 @@ object has the following members:
>* 0: [0, 336) hours ago (0 to < ~2 weeks)
>* 336: [336, 1344) hours ago (~2 weeks to ~2×28 days)
>* 1344: at least 1344 hours ago (~2×28 days or more)
* `lastupdatecheckerror`: The numeric error code encountered on the last
update check. 0 for success. Default: "0".
* `lastupdatecheckerrorcategory`: The numeric error category encountered on
* `lastupdatecheckerrorcat`: The numeric error category encountered on
the last update check. 0 for success. Default: "0".
* `lastupdatecheckerror`: The numeric error code encountered on the last
* `lastupdatecheckerrorcode`: The numeric error code encountered on the last
update check. 0 for success. Default: "0".
* `lastupdatecheckerrorextracode1`: The numeric extra code encountered on the
* `lastupdatecheckextracode1`: The numeric extra code encountered on the
last update check. 0 for success. Default: "0".
* `laststarted`: An estimated number of hours since the other updater
successfully ran (started and exited without crashing). A value of -1

6
docs/updater/protocol_4.md

@ -524,6 +524,12 @@ object has the following members:
>* 0: [0, 336) hours ago (0 to < ~2 weeks)
>* 336: [336, 1344) hours ago (~2 weeks to ~2×28 days)
>* 1344: at least 1344 hours ago (~2×28 days or more)
* `lastupdatecheckerrorcat`: The numeric error category encountered on
the last update check. 0 for success. Default: "0".
* `lastupdatecheckerrorcode`: The numeric error code encountered on the last
update check. 0 for success. Default: "0".
* `lastupdatecheckextracode1`: The numeric extra code encountered on the
last update check. 0 for success. Default: "0".
* `laststarted`: An estimated number of hours since the other updater
successfully ran (started and exited without crashing). A value of -1
indicates the last check time is unknown. Default: -1. Clients should