0

[CodeHealth] Clean up the feature ZstdContentEncoding

Bug: 362247962
Change-Id: Ic025bea1f1665cd6316aa1a82569c585d964c0cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6038659
Reviewed-by: Salma Elmahallawy <esalma@google.com>
Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Seung Jae Lim <andysjlim@chromium.org>
Reviewed-by: Richard (Torne) Coles <torne@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1386926}
This commit is contained in:
Seung Jae Lim
2024-11-22 18:06:29 +00:00
committed by Chromium LUCI CQ
parent db816c7b05
commit 4f1248e196
14 changed files with 4 additions and 54 deletions

@ -80,7 +80,6 @@
#include "content/public/browser/web_contents.h"
#include "content/public/browser/zoom_level_delegate.h"
#include "media/mojo/buildflags.h"
#include "net/base/features.h"
#include "net/http/http_no_vary_search_data.h"
#include "net/http/http_request_headers.h"
#include "net/http/http_util.h"
@ -637,8 +636,7 @@ void AwBrowserContext::ConfigureNetworkContextParams(
context_params->enforce_chrome_ct_policy = false;
context_params->enable_brotli = true;
context_params->enable_zstd =
base::FeatureList::IsEnabled(net::features::kZstdContentEncoding);
context_params->enable_zstd = true;
context_params->check_clear_text_permitted =
AwContentBrowserClient::get_check_cleartext_permitted();

@ -191,9 +191,6 @@ public final class ProductionSupportedFlagList {
VizFeatures.DRAW_IMMEDIATELY_WHEN_INTERACTIVE,
"Enable optimization for immediate activation and draw when interactive."),
Flag.baseFeature(GpuFeatures.USE_GLES2_FOR_OOP_R, "Force Skia context to use es2 only."),
Flag.baseFeature(
NetFeatures.ZSTD_CONTENT_ENCODING,
"Enables zstd content-encoding support in the browser."),
Flag.baseFeature(
NetFeatures.USE_NEW_ALPS_CODEPOINT_QUIC,
"Enables using the new ALPS codepoint to negotiate application settings for QUIC."),

@ -10098,11 +10098,6 @@ const FeatureEntry kFeatureEntries[] = {
kOsAll,
FEATURE_VALUE_TYPE(features::kComputePressureBreakCalibrationMitigation)},
{"enable-zstd-content-encoding",
flag_descriptions::kZstdContentEncodingName,
flag_descriptions::kZstdContentEncodingDescription, kOsAll,
FEATURE_VALUE_TYPE(net::features::kZstdContentEncoding)},
{"enable-shared-zstd", flag_descriptions::kSharedZstdName,
flag_descriptions::kSharedZstdDescription, kOsAll,
FEATURE_VALUE_TYPE(network::features::kSharedZstd)},

@ -4256,11 +4256,6 @@
"owners": ["bgeffon@google.com", "chromeos-memory@google.com"],
"expiry_milestone": 140
},
{
"name": "enable-zstd-content-encoding",
"owners": ["nidhijaju@chromium.org", "net-dev@chromium.org" ],
"expiry_milestone": 130
},
{
"name": "enforce-system-aec",
"owners": [ "peah@chromium.org" ],

@ -4078,10 +4078,6 @@ const char kZeroCopyName[] = "Zero-copy rasterizer";
const char kZeroCopyDescription[] =
"Raster threads write directly to GPU memory associated with tiles.";
const char kZstdContentEncodingName[] = "Zstd Content-Encoding";
const char kZstdContentEncodingDescription[] =
"Enables Zstandard Content-Encoding support.";
const char kEnableVulkanName[] = "Vulkan";
const char kEnableVulkanDescription[] = "Use vulkan as the graphics backend.";

@ -2352,9 +2352,6 @@ extern const char kWebXrIncubationsDescription[];
extern const char kZeroCopyName[];
extern const char kZeroCopyDescription[];
extern const char kZstdContentEncodingName[];
extern const char kZstdContentEncodingDescription[];
extern const char kEnableVulkanName[];
extern const char kEnableVulkanDescription[];

@ -4,25 +4,14 @@
#include "base/run_loop.h"
#include "base/test/bind.h"
#include "base/test/scoped_feature_list.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "media/media_buildflags.h"
#include "net/base/features.h"
#include "net/test/embedded_test_server/http_request.h"
class ChromeAcceptEncodingHeaderTest : public InProcessBrowserTest {
public:
ChromeAcceptEncodingHeaderTest() {
feature_list_.InitAndEnableFeature(net::features::kZstdContentEncoding);
}
~ChromeAcceptEncodingHeaderTest() override = default;
private:
base::test::ScopedFeatureList feature_list_;
};
using ChromeAcceptEncodingHeaderTest = InProcessBrowserTest;
IN_PROC_BROWSER_TEST_F(ChromeAcceptEncodingHeaderTest, Check) {
net::EmbeddedTestServer server(net::EmbeddedTestServer::TYPE_HTTPS);

@ -1260,7 +1260,6 @@ void ProfileNetworkContextService::ConfigureNetworkContextParamsInternal(
->ConfigureDefaultNetworkContextParams(network_context_params);
network_context_params->enable_zstd =
base::FeatureList::IsEnabled(net::features::kZstdContentEncoding) &&
g_browser_process->local_state()->GetBoolean(
prefs::kZstdContentEncodingEnabled);
network_context_params->accept_language = ComputeAcceptLanguage();

@ -871,7 +871,6 @@ void SystemNetworkContextManager::ConfigureDefaultNetworkContextParams(
network_context_params->enable_brotli = true;
network_context_params->enable_zstd =
base::FeatureList::IsEnabled(net::features::kZstdContentEncoding) &&
local_state_->GetBoolean(prefs::kZstdContentEncodingEnabled);
network_context_params->user_agent = embedder_support::GetUserAgent();

@ -4,7 +4,6 @@
#include "base/run_loop.h"
#include "base/test/bind.h"
#include "base/test/scoped_feature_list.h"
#include "chrome/browser/policy/policy_test_utils.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
@ -23,9 +22,7 @@ namespace policy {
class ZstdContentEncodingPolicyTest : public PolicyTest {
public:
ZstdContentEncodingPolicyTest() {
feature_list_.InitAndEnableFeature(net::features::kZstdContentEncoding);
}
ZstdContentEncodingPolicyTest() = default;
~ZstdContentEncodingPolicyTest() override = default;
void SetUp() override {
@ -78,8 +75,6 @@ class ZstdContentEncodingPolicyTest : public PolicyTest {
}
return false;
}
base::test::ScopedFeatureList feature_list_;
};
IN_PROC_BROWSER_TEST_F(ZstdContentEncodingPolicyTest,

@ -232,8 +232,7 @@ void HeadlessRequestContextManager::ConfigureNetworkContextParamsInternal(
cert_verifier_creation_params) {
context_params->user_agent = user_agent_;
context_params->accept_language = accept_language_;
context_params->enable_zstd =
base::FeatureList::IsEnabled(net::features::kZstdContentEncoding);
context_params->enable_zstd = true;
// TODO(crbug.com/40405715): Allow
// context_params->http_auth_static_network_context_params->allow_default_credentials

@ -525,10 +525,6 @@ BASE_FEATURE(kEnableWebTransportDraft07,
"EnableWebTransportDraft07",
base::FEATURE_DISABLED_BY_DEFAULT);
BASE_FEATURE(kZstdContentEncoding,
"ZstdContentEncoding",
base::FEATURE_ENABLED_BY_DEFAULT);
// When enabled, partitioned storage will be allowed even if third-party cookies
// are disabled by default. Partitioned storage will not be allowed if
// third-party cookies are disabled due to a specific rule.

@ -552,9 +552,6 @@ NET_EXPORT BASE_DECLARE_FEATURE(kEnableEarlyHintsOnHttp11);
// Enables draft-07 version of WebTransport over HTTP/3.
NET_EXPORT BASE_DECLARE_FEATURE(kEnableWebTransportDraft07);
// Enables Zstandard Content-Encoding support.
NET_EXPORT BASE_DECLARE_FEATURE(kZstdContentEncoding);
NET_EXPORT BASE_DECLARE_FEATURE(kThirdPartyPartitionedStorageAllowedByDefault);
// Enables a more efficient implementation of SpdyHeadersToHttpResponse().

@ -24615,7 +24615,6 @@ from previous Chrome versions.
<int value="1724706885" label="EnableEdgeDetection:disabled"/>
<int value="1724800383" label="AsmJsToWebAssembly:disabled"/>
<int value="1725438666" label="NewStyleNotifications:enabled"/>
<int value="1726144143" label="ZstdContentEncoding:enabled"/>
<int value="1726197412" label="FencedFramesDefaultMode:disabled"/>
<int value="1726474125"
label="AccessibilityDictationKeyboardImprovements:disabled"/>
@ -24641,7 +24640,6 @@ from previous Chrome versions.
<int value="1739456903" label="PWAFullCodeCache:enabled"/>
<int value="1739507233" label="EarlyEstablishGpuChannel:enabled"/>
<int value="1739782037" label="LinkDoctorDeprecationAndroid:enabled"/>
<int value="1739919484" label="ZstdContentEncoding:disabled"/>
<int value="1740660782" label="VideoPictureInPictureMinimizeButton:disabled"/>
<int value="1741751043"
label="MinorModeRestrictionsForHistorySyncOptIn:enabled"/>