0

[AW][Dev-UI] measure longer user sessions

No change to logic. This swaps "Android.WebView.DevUi.SessionDuration"
for "Android.WebView.DevUi.SessionDuration2" to capture sessions up to
1 hour (by using recordLongTimesHistogram100).

Fixed: 1087152
Test: None
Change-Id: Ie0289f6303ea286494c84466beacb189e2d5bf43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225820
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Hazem Ashmawy <hazems@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774449}
This commit is contained in:
Nate Fischer
2020-06-03 02:11:43 +00:00
committed by Commit Bot
parent 91290d4bc1
commit 4fbed1359b
2 changed files with 21 additions and 2 deletions
android_webview/nonembedded/java/src/org/chromium/android_webview/devui
tools/metrics/histograms

@ -44,8 +44,8 @@ public abstract class DevUiBaseFragment extends Fragment {
// Note: keep this if-else ladder synchronized with the AndroidWebViewFragments
// histogram_suffix
long endOfSession = SystemClock.elapsedRealtime();
RecordHistogram.recordTimesHistogram(
"Android.WebView.DevUi.SessionDuration." + suffix, endOfSession - mStartOfSession);
RecordHistogram.recordLongTimesHistogram100(
"Android.WebView.DevUi.SessionDuration2." + suffix, endOfSession - mStartOfSession);
}
@Override

@ -5008,6 +5008,24 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram base="true" name="Android.WebView.DevUi.SessionDuration" units="ms"
expires_after="2021-01-20">
<obsolete>
Removed May 2020 because this only captures sessions up to 10 seconds long.
Use Android.WebView.DevUi.SessionDuration2 instead, which captures sessions
up to an hour.
</obsolete>
<!-- Name completed by histogram_suffixes
name="AndroidWebViewFragments" -->
<owner>ntfschr@chromium.org</owner>
<owner>hazems@chromium.org</owner>
<owner>src/android_webview/OWNERS</owner>
<summary>
Records the time spent using a specific tool, from creation to destruction.
</summary>
</histogram>
<histogram base="true" name="Android.WebView.DevUi.SessionDuration2" units="ms"
expires_after="2021-01-20">
<!-- Name completed by histogram_suffixes
name="AndroidWebViewFragments" -->
@ -191041,6 +191059,7 @@ regressions. -->
<suffix name="Unknown"
label="Unknown Fragment (the histogram may need to be updated)."/>
<affected-histogram name="Android.WebView.DevUi.SessionDuration"/>
<affected-histogram name="Android.WebView.DevUi.SessionDuration2"/>
</histogram_suffixes>
<histogram_suffixes name="AppListFirstPaintWarmStartFast" separator="">